From: Vinod Koul <vkoul@kernel.org>
To: Shunyong Yang <shunyong.yang@hxt-semitech.com>
Cc: okaya@kernel.org, andy.gross@linaro.org, david.brown@linaro.org,
dan.j.williams@intel.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org,
Joey Zheng <yu.zheng@hxt-semitech.com>
Subject: [v2,1/2] dmaengine: qcom_hidma: initialize tx flags in hidma_prep_dma_*
Date: Sun, 20 Jan 2019 10:44:05 +0530 [thread overview]
Message-ID: <20190120051405.GI4635@vkoul-mobl> (raw)
On 07-01-19, 09:32, Shunyong Yang wrote:
> In async_tx_test_ack(), it uses flags in struct dma_async_tx_descriptor
> to check the ACK status. As hidma reuses the descriptor in a free list
> when hidma_prep_dma_*(memcpy/memset) is called, the flag will keep ACKed
> if the descriptor has been used before. This will cause a BUG_ON in
> async_tx_quiesce().
>
> kernel BUG at crypto/async_tx/async_tx.c:282!
> Internal error: Oops - BUG: 0 1 SMP
> ...
> task: ffff8017dd3ec000 task.stack: ffff8017dd3e8000
> PC is at async_tx_quiesce+0x54/0x78 [async_tx]
> LR is at async_trigger_callback+0x98/0x110 [async_tx]
>
> This patch initializes flags in dma_async_tx_descriptor by the flags
> passed from the caller when hidma_prep_dma_*(memcpy/memset) is called.
Applied both, thanks
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Shunyong Yang <shunyong.yang@hxt-semitech.com>
Cc: okaya@kernel.org, andy.gross@linaro.org, david.brown@linaro.org,
dan.j.williams@intel.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org,
Joey Zheng <yu.zheng@hxt-semitech.com>
Subject: Re: [PATCH v2 1/2] dmaengine: qcom_hidma: initialize tx flags in hidma_prep_dma_*
Date: Sun, 20 Jan 2019 10:44:05 +0530 [thread overview]
Message-ID: <20190120051405.GI4635@vkoul-mobl> (raw)
In-Reply-To: <8109d1ab70fe6dbacdbe89fda38d8dcb450c884c.1546823811.git.shunyong.yang@hxt-semitech.com>
On 07-01-19, 09:32, Shunyong Yang wrote:
> In async_tx_test_ack(), it uses flags in struct dma_async_tx_descriptor
> to check the ACK status. As hidma reuses the descriptor in a free list
> when hidma_prep_dma_*(memcpy/memset) is called, the flag will keep ACKed
> if the descriptor has been used before. This will cause a BUG_ON in
> async_tx_quiesce().
>
> kernel BUG at crypto/async_tx/async_tx.c:282!
> Internal error: Oops - BUG: 0 1 SMP
> ...
> task: ffff8017dd3ec000 task.stack: ffff8017dd3e8000
> PC is at async_tx_quiesce+0x54/0x78 [async_tx]
> LR is at async_trigger_callback+0x98/0x110 [async_tx]
>
> This patch initializes flags in dma_async_tx_descriptor by the flags
> passed from the caller when hidma_prep_dma_*(memcpy/memset) is called.
Applied both, thanks
--
~Vinod
next reply other threads:[~2019-01-20 5:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-20 5:14 Vinod Koul [this message]
2019-01-20 5:14 ` [PATCH v2 1/2] dmaengine: qcom_hidma: initialize tx flags in hidma_prep_dma_* Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2019-01-07 1:34 [v2,2/2] dmaengine: qcom_hidma: assign channel cookie correctly Yang Shunyong
2019-01-07 1:34 ` [PATCH v2 2/2] " Shunyong Yang
2019-01-07 1:32 [v2,1/2] dmaengine: qcom_hidma: initialize tx flags in hidma_prep_dma_* Yang Shunyong
2019-01-07 1:32 ` [PATCH v2 1/2] " Shunyong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190120051405.GI4635@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=andy.gross@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=david.brown@linaro.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=okaya@kernel.org \
--cc=shunyong.yang@hxt-semitech.com \
--cc=yu.zheng@hxt-semitech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.