All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Cc: Petri Latvala <petri.latvala@intel.com>,
	intel-gfx@lists.freedesktop.org, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_flip: Add test to check suspend/resume
Date: Mon, 21 Jan 2019 11:10:43 +0100	[thread overview]
Message-ID: <20190121101043.GS3271@phenom.ffwll.local> (raw)
In-Reply-To: <20190121093432.jf6vfbmjmb2rzlyz@smtp.gmail.com>

On Mon, Jan 21, 2019 at 07:34:32AM -0200, Rodrigo Siqueira wrote:
> Hi,
> 
> On 01/18, Shayenne Moura wrote:
> > This patch adds one test to evaluate suspend/resume operations using kms_flip.
> > 
> > Signed-off-by: Shayenne Moura <shayenneluzmoura@gmail.com>
> > ---
> >  tests/kms_flip.c | 1 +
> >  1 file changed, 1 insertion(+)
> >  mode change 100644 => 100755 tests/kms_flip.c
> > 
> > diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> > old mode 100644
> > new mode 100755
> > index f28272dd..3ca2fdfc
> > --- a/tests/kms_flip.c
> > +++ b/tests/kms_flip.c
> > @@ -1567,6 +1567,7 @@ int main(int argc, char **argv)
> >  		{ 10, TEST_DPMS_OFF | TEST_DPMS | TEST_VBLANK_RACE, "dpms-vs-vblank-race" },
> >  		{ 10, TEST_MODESET | TEST_VBLANK_RACE, "modeset-vs-vblank-race" },
> >  		{ 0, TEST_BO_TOOBIG | TEST_NO_2X_OUTPUT, "bo-too-big" },
> > +		{ 30, TEST_FLIP | TEST_SUSPEND, "flip-vs-suspend" },
> 
> I remember to follow a conversation in the IRC that you said that VKMS
> pass this test. I tried it here on my VM, and after running the test my
> system got freeze. My VM uses Arch Linux with Kernel 5.0.0-rc1. Did I
> miss something?
> 
> Also, I tested it on my host machine with i915 driver and I noticed that
> the test took much more than 30 seconds to finish. Is it right?

Yeah should probably reduce to 10 or something. The susend-resume will
take 10+ seconds at least, and we'lld do one per CRTC, so this is going to
take a while anyway. Note that the test timeout is per-CRTC iirc.
-Daniel

> 
> Thanks
> Best Regards
> 
> >  	};
> >  	int i;
> >  
> > -- 
> > 2.17.1
> > 
> 
> -- 
> Rodrigo Siqueira
> https://siqueira.tech
> Graduate Student
> Department of Computer Science
> University of São Paulo



-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	intel-gfx@lists.freedesktop.org, igt-dev@lists.freedesktop.org,
	Shayenne Moura <shayenneluzmoura@gmail.com>
Subject: Re: [PATCH i-g-t] tests/kms_flip: Add test to check suspend/resume
Date: Mon, 21 Jan 2019 11:10:43 +0100	[thread overview]
Message-ID: <20190121101043.GS3271@phenom.ffwll.local> (raw)
In-Reply-To: <20190121093432.jf6vfbmjmb2rzlyz@smtp.gmail.com>

On Mon, Jan 21, 2019 at 07:34:32AM -0200, Rodrigo Siqueira wrote:
> Hi,
> 
> On 01/18, Shayenne Moura wrote:
> > This patch adds one test to evaluate suspend/resume operations using kms_flip.
> > 
> > Signed-off-by: Shayenne Moura <shayenneluzmoura@gmail.com>
> > ---
> >  tests/kms_flip.c | 1 +
> >  1 file changed, 1 insertion(+)
> >  mode change 100644 => 100755 tests/kms_flip.c
> > 
> > diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> > old mode 100644
> > new mode 100755
> > index f28272dd..3ca2fdfc
> > --- a/tests/kms_flip.c
> > +++ b/tests/kms_flip.c
> > @@ -1567,6 +1567,7 @@ int main(int argc, char **argv)
> >  		{ 10, TEST_DPMS_OFF | TEST_DPMS | TEST_VBLANK_RACE, "dpms-vs-vblank-race" },
> >  		{ 10, TEST_MODESET | TEST_VBLANK_RACE, "modeset-vs-vblank-race" },
> >  		{ 0, TEST_BO_TOOBIG | TEST_NO_2X_OUTPUT, "bo-too-big" },
> > +		{ 30, TEST_FLIP | TEST_SUSPEND, "flip-vs-suspend" },
> 
> I remember to follow a conversation in the IRC that you said that VKMS
> pass this test. I tried it here on my VM, and after running the test my
> system got freeze. My VM uses Arch Linux with Kernel 5.0.0-rc1. Did I
> miss something?
> 
> Also, I tested it on my host machine with i915 driver and I noticed that
> the test took much more than 30 seconds to finish. Is it right?

Yeah should probably reduce to 10 or something. The susend-resume will
take 10+ seconds at least, and we'lld do one per CRTC, so this is going to
take a while anyway. Note that the test timeout is per-CRTC iirc.
-Daniel

> 
> Thanks
> Best Regards
> 
> >  	};
> >  	int i;
> >  
> > -- 
> > 2.17.1
> > 
> 
> -- 
> Rodrigo Siqueira
> https://siqueira.tech
> Graduate Student
> Department of Computer Science
> University of São Paulo



-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-01-21 10:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-18 11:29 [igt-dev] [PATCH i-g-t] tests/kms_flip: Add test to check suspend/resume Shayenne Moura
2019-01-18 11:29 ` Shayenne Moura
2019-01-18 12:06 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-18 17:43 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-01-21  9:34 ` [igt-dev] [PATCH i-g-t] " Rodrigo Siqueira
2019-01-21  9:34   ` Rodrigo Siqueira
2019-01-21 10:10   ` Daniel Vetter [this message]
2019-01-21 10:10     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190121101043.GS3271@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    --cc=rodrigosiqueiramelo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.