From: Mark Brown <broonie@kernel.org>
To: Curtis Malainey <cujomalainey@google.com>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Matthias Reichl <hias@horus.com>,
rohkumar@qti.qualcomm.com, alsa-devel@alsa-project.org,
bgoswami@codeaurora.org, vinod.koul@linaro.org,
lgirdwood@gmail.com, plai@codeaurora.org,
linux-kernel@vger.kernel.org, tiwai@suse.com,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
srinivas.kandagatla@linaro.org,
Rohit kumar <rohitkr@codeaurora.org>,
asishb@codeaurora.org, Ajit Pandey <ajitp@codeaurora.org>,
Curtis Malainey <cujomalainey@chromium.org>,
Dylan Reid <dgreid@google.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: soc-core: Fix null pointer dereference in soc_find_component
Date: Mon, 21 Jan 2019 18:30:54 +0000 [thread overview]
Message-ID: <20190121183054.GF12679@sirena.org.uk> (raw)
In-Reply-To: <CAOReqxjLcdN6rT9w3_6MJaqE-hpiCsZ+3Luic+e793GwPde+Qg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 530 bytes --]
On Fri, Jan 18, 2019 at 05:15:32PM -0800, Curtis Malainey wrote:
> of_node was never getting set but the pointer was becoming populated
> (outside of the probe call) which traced to soc_init_platform function
> which was not reallocating memory on a EPROBE_DEFER even though it was
> getting freed by devm. I am not very familiar with devm but my local
> maintainers say that it should be freeing the memory even on a
> PROBE_DEFER.
Probe deferral is just like any other error from probe, any managed
resources will be unwound.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-01-21 18:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 8:14 [PATCH] ASoC: soc-core: Fix null pointer dereference in soc_find_component Rohit kumar
2019-01-11 15:44 ` [alsa-devel] " Pierre-Louis Bossart
2019-01-11 21:49 ` Pierre-Louis Bossart
2019-01-12 6:07 ` Rohit kumar
2019-01-14 15:40 ` [alsa-devel] " Liam Girdwood
2019-01-15 0:06 ` Mark Brown
2019-01-15 3:08 ` Pierre-Louis Bossart
2019-01-15 19:35 ` [alsa-devel] " Pierre-Louis Bossart
2019-01-15 21:07 ` Mark Brown
2019-01-15 21:11 ` Matthias Reichl
2019-01-15 21:16 ` [alsa-devel] " Pierre-Louis Bossart
2019-01-15 21:41 ` Mark Brown
2019-01-15 21:48 ` [alsa-devel] " Matthias Reichl
2019-01-18 23:02 ` Pierre-Louis Bossart
2019-01-19 1:12 ` Curtis Malainey
2019-01-19 1:15 ` [alsa-devel] " Curtis Malainey
2019-01-21 18:30 ` Mark Brown [this message]
2019-01-22 20:11 ` Pierre-Louis Bossart
2019-01-23 1:36 ` [alsa-devel] " Curtis Malainey
2019-01-23 2:01 ` Pierre-Louis Bossart
2019-01-24 18:44 ` Mark Brown
2019-01-24 19:07 ` [alsa-devel] " Pierre-Louis Bossart
2019-01-24 19:26 ` Mark Brown
2019-01-25 1:32 ` Curtis Malainey
2019-01-21 19:17 ` Mark Brown
2019-01-14 23:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121183054.GF12679@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ajitp@codeaurora.org \
--cc=alsa-devel@alsa-project.org \
--cc=asishb@codeaurora.org \
--cc=bgoswami@codeaurora.org \
--cc=cujomalainey@chromium.org \
--cc=cujomalainey@google.com \
--cc=dgreid@google.com \
--cc=hias@horus.com \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=plai@codeaurora.org \
--cc=rohitkr@codeaurora.org \
--cc=rohkumar@qti.qualcomm.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=vinod.koul@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.