From: Rob Herring <robh@kernel.org>
To: Aisheng Dong <aisheng.dong@nxp.com>
Cc: "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH RESEND v1 2/4] dt-bindings: fsl: scu: add imx8qm scu clock support
Date: Mon, 21 Jan 2019 17:27:30 -0600 [thread overview]
Message-ID: <20190121232730.GA22676@bogus> (raw)
In-Reply-To: <1547207400-28307-3-git-send-email-aisheng.dong@nxp.com>
On Fri, Jan 11, 2019 at 11:56:00AM +0000, Aisheng Dong wrote:
> Add imx8qm scu clock support
>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> index 5ec6dca..b6a883e 100644
> --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> @@ -71,7 +71,8 @@ This binding uses the common clock binding[1].
>
> Required properties:
> - compatible: Should be one of:
> - "fsl,imx8qxp-clock"
> + "fsl,imx8qm-clock",
> + "fsl,imx8qxp-clock".
No need for the punctuation here. The whole point of one per line is to
have 1 line changes. Otherwise,
Reviewed-by: Rob Herring <robh@kernel.org>
> followed by "fsl,scu-clk"
> - #clock-cells: Should be 1. Contains the Clock ID value.
> - clocks: List of clock specifiers, must contain an entry for
> --
> 2.7.4
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Aisheng Dong <aisheng.dong@nxp.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH RESEND v1 2/4] dt-bindings: fsl: scu: add imx8qm scu clock support
Date: Mon, 21 Jan 2019 17:27:30 -0600 [thread overview]
Message-ID: <20190121232730.GA22676@bogus> (raw)
In-Reply-To: <1547207400-28307-3-git-send-email-aisheng.dong@nxp.com>
On Fri, Jan 11, 2019 at 11:56:00AM +0000, Aisheng Dong wrote:
> Add imx8qm scu clock support
>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> index 5ec6dca..b6a883e 100644
> --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> @@ -71,7 +71,8 @@ This binding uses the common clock binding[1].
>
> Required properties:
> - compatible: Should be one of:
> - "fsl,imx8qxp-clock"
> + "fsl,imx8qm-clock",
> + "fsl,imx8qxp-clock".
No need for the punctuation here. The whole point of one per line is to
have 1 line changes. Otherwise,
Reviewed-by: Rob Herring <robh@kernel.org>
> followed by "fsl,scu-clk"
> - #clock-cells: Should be 1. Contains the Clock ID value.
> - clocks: List of clock specifiers, must contain an entry for
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Aisheng Dong <aisheng.dong@nxp.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH RESEND v1 2/4] dt-bindings: fsl: scu: add imx8qm scu clock support
Date: Mon, 21 Jan 2019 17:27:30 -0600 [thread overview]
Message-ID: <20190121232730.GA22676@bogus> (raw)
In-Reply-To: <1547207400-28307-3-git-send-email-aisheng.dong@nxp.com>
On Fri, Jan 11, 2019 at 11:56:00AM +0000, Aisheng Dong wrote:
> Add imx8qm scu clock support
>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> index 5ec6dca..b6a883e 100644
> --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> @@ -71,7 +71,8 @@ This binding uses the common clock binding[1].
>
> Required properties:
> - compatible: Should be one of:
> - "fsl,imx8qxp-clock"
> + "fsl,imx8qm-clock",
> + "fsl,imx8qxp-clock".
No need for the punctuation here. The whole point of one per line is to
have 1 line changes. Otherwise,
Reviewed-by: Rob Herring <robh@kernel.org>
> followed by "fsl,scu-clk"
> - #clock-cells: Should be 1. Contains the Clock ID value.
> - clocks: List of clock specifiers, must contain an entry for
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-01-21 23:27 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 11:55 [PATCH RESEND v1 0/4] dt-binding: clk: prepare for imx8qm clock support Aisheng Dong
2019-01-11 11:55 ` Aisheng Dong
2019-01-11 11:55 ` Aisheng Dong
2019-01-11 11:55 ` [PATCH RESEND v1 1/4] dt-bindings: fsl: scu: add fallback compatible string for clock Aisheng Dong
2019-01-11 11:55 ` Aisheng Dong
2019-01-11 11:55 ` Aisheng Dong
2019-01-21 23:25 ` Rob Herring
2019-01-21 23:25 ` Rob Herring
2019-01-21 23:25 ` Rob Herring
2019-01-22 19:05 ` Stephen Boyd
2019-01-22 19:05 ` Stephen Boyd
2019-01-22 19:05 ` Stephen Boyd
2019-01-11 11:56 ` [PATCH RESEND v1 2/4] dt-bindings: fsl: scu: add imx8qm scu clock support Aisheng Dong
2019-01-11 11:56 ` Aisheng Dong
2019-01-11 11:56 ` Aisheng Dong
2019-01-21 23:27 ` Rob Herring [this message]
2019-01-21 23:27 ` Rob Herring
2019-01-21 23:27 ` Rob Herring
2019-01-22 12:58 ` Aisheng Dong
2019-01-22 12:58 ` Aisheng Dong
2019-01-22 12:58 ` Aisheng Dong
2019-01-22 19:06 ` Stephen Boyd
2019-01-22 19:06 ` Stephen Boyd
2019-01-22 19:06 ` Stephen Boyd
2019-01-11 11:56 ` [PATCH RESEND v1 3/4] clk: imx: scu: add fallback compatible string support Aisheng Dong
2019-01-11 11:56 ` Aisheng Dong
2019-01-11 11:56 ` Aisheng Dong
2019-01-11 11:56 ` [PATCH RESEND v1 4/4] dt-bindings: imx8-clock: add a53 and a72 clock id Aisheng Dong
2019-01-11 11:56 ` Aisheng Dong
2019-01-11 11:56 ` Aisheng Dong
2019-01-22 0:10 ` Rob Herring
2019-01-22 0:10 ` Rob Herring
2019-01-22 0:10 ` Rob Herring
2019-01-22 12:59 ` Aisheng Dong
2019-01-22 12:59 ` Aisheng Dong
2019-01-22 12:59 ` Aisheng Dong
2019-01-30 16:45 ` Rob Herring
2019-01-30 16:45 ` Rob Herring
2019-01-30 16:45 ` Rob Herring
2019-01-16 5:40 ` [PATCH RESEND v1 0/4] dt-binding: clk: prepare for imx8qm clock support Aisheng Dong
2019-01-16 5:40 ` Aisheng Dong
2019-01-16 5:40 ` Aisheng Dong
2019-01-16 11:02 ` Shawn Guo
2019-01-16 11:02 ` Shawn Guo
2019-01-16 11:02 ` Shawn Guo
2019-01-22 19:06 ` Stephen Boyd
2019-01-22 19:06 ` Stephen Boyd
2019-01-22 19:06 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121232730.GA22676@bogus \
--to=robh@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.