From: Sinan Kaya <okaya@kernel.org>
To: linux-next@vger.kernel.org
Cc: Sinan Kaya <okaya@kernel.org>,
Johannes Berg <johannes.berg@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Luca Coelho <luciano.coelho@intel.com>,
Intel Linux Wireless <linuxwifi@intel.com>,
Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
"open list:INTEL WIRELESS WIFI LINK iwlwifi"
<linux-wireless@vger.kernel.org>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: [for next][PATCH] iwlwifi: Fix unmet dependency error for IWLWIFI_LEDS
Date: Mon, 21 Jan 2019 23:31:02 +0000 [thread overview]
Message-ID: <20190121233102.13705-1-okaya@kernel.org> (raw)
There is an unresolved dependency as follows:
IWLWIFI_LEDS selects MAC80211_LEDS.
MAC80211_LEDS depends on MAC80211.
It is possible to choose MAC80211_LEDS (y) but not choose MAC80211 (n)
WARNING: unmet direct dependencies detected for MAC80211_LEDS
Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=n] && LEDS_CLASS [=y]
Selected by [y]:
- IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_INTEL [=y] && IWLWIFI [=y] && (LEDS_CLASS [=y]=y || LEDS_CLASS [=y]=IWLWIFI [=y])
Move the MAC80211 dependency into IWLWIFI_LEDS so that we avoid this
configuration.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/net/wireless/intel/iwlwifi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig
index 491ca3c8b43c..74f0d0bbed34 100644
--- a/drivers/net/wireless/intel/iwlwifi/Kconfig
+++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
@@ -46,7 +46,7 @@ if IWLWIFI
config IWLWIFI_LEDS
bool
- depends on LEDS_CLASS=y || LEDS_CLASS=IWLWIFI
+ depends on MAC80211 && (LEDS_CLASS=y || LEDS_CLASS=IWLWIFI)
select LEDS_TRIGGERS
select MAC80211_LEDS
default y
--
2.19.0
WARNING: multiple messages have this Message-ID (diff)
From: Sinan Kaya <okaya@kernel.org>
To: linux-next@vger.kernel.org
Cc: Sinan Kaya <okaya@kernel.org>,
Johannes Berg <johannes.berg@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Luca Coelho <luciano.coelho@intel.com>,
Intel Linux Wireless <linuxwifi@intel.com>,
Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org (open list:INTEL WIRELESS WIFI
LINK (iwlwifi)),
netdev@vger.kernel.org (open list:NETWORKING DRIVERS),
linux-kernel@vger.kernel.org (open list)
Subject: [for next][PATCH] iwlwifi: Fix unmet dependency error for IWLWIFI_LEDS
Date: Mon, 21 Jan 2019 23:31:02 +0000 [thread overview]
Message-ID: <20190121233102.13705-1-okaya@kernel.org> (raw)
There is an unresolved dependency as follows:
IWLWIFI_LEDS selects MAC80211_LEDS.
MAC80211_LEDS depends on MAC80211.
It is possible to choose MAC80211_LEDS (y) but not choose MAC80211 (n)
WARNING: unmet direct dependencies detected for MAC80211_LEDS
Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=n] && LEDS_CLASS [=y]
Selected by [y]:
- IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_INTEL [=y] && IWLWIFI [=y] && (LEDS_CLASS [=y]=y || LEDS_CLASS [=y]=IWLWIFI [=y])
Move the MAC80211 dependency into IWLWIFI_LEDS so that we avoid this
configuration.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/net/wireless/intel/iwlwifi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig
index 491ca3c8b43c..74f0d0bbed34 100644
--- a/drivers/net/wireless/intel/iwlwifi/Kconfig
+++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
@@ -46,7 +46,7 @@ if IWLWIFI
config IWLWIFI_LEDS
bool
- depends on LEDS_CLASS=y || LEDS_CLASS=IWLWIFI
+ depends on MAC80211 && (LEDS_CLASS=y || LEDS_CLASS=IWLWIFI)
select LEDS_TRIGGERS
select MAC80211_LEDS
default y
--
2.19.0
next reply other threads:[~2019-01-21 23:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 23:31 Sinan Kaya [this message]
2019-01-21 23:31 ` [for next][PATCH] iwlwifi: Fix unmet dependency error for IWLWIFI_LEDS Sinan Kaya
2019-01-22 10:15 ` Luciano Coelho
2019-01-22 10:15 ` Luciano Coelho
2019-01-22 16:12 ` Sinan Kaya
2019-01-22 16:17 ` Kalle Valo
2019-01-22 16:17 ` Kalle Valo
2019-01-22 16:20 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121233102.13705-1-okaya@kernel.org \
--to=okaya@kernel.org \
--cc=davem@davemloft.net \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.