From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: kernel-hardening@lists.openwall.com,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Jiri Slaby <jslaby@suse.com>
Subject: Re: [PATCH] tty: ldisc: add sysctl to prevent autoloading of ldiscs
Date: Mon, 21 Jan 2019 19:01:42 -0500 [thread overview]
Message-ID: <20190122000142.GB19379@mit.edu> (raw)
In-Reply-To: <20190121162642.GA2944@kroah.com>
On Mon, Jan 21, 2019 at 05:26:42PM +0100, Greg Kroah-Hartman wrote:
> By default, the kernel will automatically load the module of any line
> dicipline that is asked for. As this sometimes isn't the safest thing
> to do, provide a sysctl to disable this feature.
>
> By default, we set this to 'y' as that is the historical way that Linux
> has worked, and we do not want to break working systems. But in the
> future, perhaps this can default to 'n' to prevent this functionality.
>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <kernel-hardening@lists.openwall.com>,
<linux-kernel@vger.kernel.org>, <linux-serial@vger.kernel.org>,
Jiri Slaby <jslaby@suse.com>
Subject: Re: [PATCH] tty: ldisc: add sysctl to prevent autoloading of ldiscs
Date: Mon, 21 Jan 2019 19:01:42 -0500 [thread overview]
Message-ID: <20190122000142.GB19379@mit.edu> (raw)
In-Reply-To: <20190121162642.GA2944@kroah.com>
On Mon, Jan 21, 2019 at 05:26:42PM +0100, Greg Kroah-Hartman wrote:
> By default, the kernel will automatically load the module of any line
> dicipline that is asked for. As this sometimes isn't the safest thing
> to do, provide a sysctl to disable this feature.
>
> By default, we set this to 'y' as that is the historical way that Linux
> has worked, and we do not want to break working systems. But in the
> future, perhaps this can default to 'n' to prevent this functionality.
>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
next prev parent reply other threads:[~2019-01-22 0:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 16:26 [PATCH] tty: ldisc: add sysctl to prevent autoloading of ldiscs Greg Kroah-Hartman
2019-01-22 0:01 ` Theodore Y. Ts'o [this message]
2019-01-22 0:01 ` Theodore Y. Ts'o
2019-01-30 8:28 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122000142.GB19379@mit.edu \
--to=tytso@mit.edu \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.