From: Shawn Guo <shawnguo@kernel.org>
To: Stefan Agner <stefan@agner.ch>
Cc: kernel@pengutronix.de, marcel.ziswiler@toradex.com,
s.hauer@pengutronix.de, linux-kernel@vger.kernel.org,
linux-imx@nxp.com, max.krummenacher@toradex.com,
fabio.estevam@nxp.com, dev@pschenker.ch,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: imx6*-apalis/-colibri: mark I2C recovery GPIOs as open drain
Date: Tue, 22 Jan 2019 13:32:21 +0800 [thread overview]
Message-ID: <20190122053220.GE19233@dragon> (raw)
In-Reply-To: <20190118133113.19484-1-stefan@agner.ch>
On Fri, Jan 18, 2019 at 02:31:13PM +0100, Stefan Agner wrote:
> Since commit d2d0ad2aec4a ("i2c: imx: use open drain for recovery
> GPIO") GPIO lib expects this GPIO to be configured as open drain.
> Make sure we define this GPIO as open drain in the device tree.
> This gets rid of the following warning:
> gpio-81 (scl): enforced open drain please flag it properly in DT/ACPI DSDT/board file
>
> Note that currently the i.MX pinctrl driver does not support
> enabling open drain directly, so this patch has no effect in
> practice. Open drain is enabled by the fixed pinmux entry.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Stefan Agner <stefan@agner.ch>
Cc: s.hauer@pengutronix.de, max.krummenacher@toradex.com,
marcel.ziswiler@toradex.com, dev@pschenker.ch,
kernel@pengutronix.de, fabio.estevam@nxp.com, linux-imx@nxp.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: imx6*-apalis/-colibri: mark I2C recovery GPIOs as open drain
Date: Tue, 22 Jan 2019 13:32:21 +0800 [thread overview]
Message-ID: <20190122053220.GE19233@dragon> (raw)
In-Reply-To: <20190118133113.19484-1-stefan@agner.ch>
On Fri, Jan 18, 2019 at 02:31:13PM +0100, Stefan Agner wrote:
> Since commit d2d0ad2aec4a ("i2c: imx: use open drain for recovery
> GPIO") GPIO lib expects this GPIO to be configured as open drain.
> Make sure we define this GPIO as open drain in the device tree.
> This gets rid of the following warning:
> gpio-81 (scl): enforced open drain please flag it properly in DT/ACPI DSDT/board file
>
> Note that currently the i.MX pinctrl driver does not support
> enabling open drain directly, so this patch has no effect in
> practice. Open drain is enabled by the fixed pinmux entry.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Applied, thanks.
next prev parent reply other threads:[~2019-01-22 5:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 13:31 [PATCH] ARM: dts: imx6*-apalis/-colibri: mark I2C recovery GPIOs as open drain Stefan Agner
2019-01-18 13:31 ` Stefan Agner
2019-01-21 8:43 ` Philippe Schenker
2019-01-21 8:43 ` Philippe Schenker
2019-01-22 5:32 ` Shawn Guo [this message]
2019-01-22 5:32 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122053220.GE19233@dragon \
--to=shawnguo@kernel.org \
--cc=dev@pschenker.ch \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=max.krummenacher@toradex.com \
--cc=s.hauer@pengutronix.de \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.