All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de
Subject: Re: [PATCH] ARM: dts: imx: Remove 'simple-bus' from anatop compatible
Date: Tue, 22 Jan 2019 14:06:25 +0800	[thread overview]
Message-ID: <20190122060624.GD19929@dragon> (raw)
In-Reply-To: <20190121202905.31224-1-festevam@gmail.com>

On Mon, Jan 21, 2019 at 06:29:05PM -0200, Fabio Estevam wrote:
> dtc gives the following warnings when building with W=1:
> 
> arch/arm/boot/dts/imx6qdl.dtsi:702.19-715.7: Warning (simple_bus_reg): /soc/aips-bus@2000000/anatop@20c8000/regulator-1p1: missing or empty reg/ranges property
> arch/arm/boot/dts/imx6qdl.dtsi:717.19-730.7: Warning (simple_bus_reg): /soc/aips-bus@2000000/anatop@20c8000/regulator-3p0: missing or empty reg/ranges property
> arch/arm/boot/dts/imx6qdl.dtsi:732.19-745.7: Warning (simple_bus_reg): /soc/aips-bus@2000000/anatop@20c8000/regulator-2p5: missing or empty reg/ranges property
> arch/arm/boot/dts/imx6qdl.dtsi:747.32-762.7: Warning (simple_bus_reg): /soc/aips-bus@2000000/anatop@20c8000/regulator-vddcore: missing or empty reg/ranges property
> arch/arm/boot/dts/imx6qdl.dtsi:764.29-779.7: Warning (simple_bus_reg): /soc/aips-bus@2000000/anatop@20c8000/regulator-vddpu: missing or empty reg/ranges property
> arch/arm/boot/dts/imx6qdl.dtsi:781.31-796.7: Warning (simple_bus_reg): /soc/aips-bus@2000000/anatop@20c8000/regulator-vddsoc: missing or empty reg/ranges property
> 
> Remove 'simple-bus' from the compatible list of anatop, since it is a
> regulator and thus should not be described as 'simple-bus'.

Will the child regulator devices still be populated by kernel?

Shawn

> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  arch/arm/boot/dts/imx6qdl.dtsi | 2 +-
>  arch/arm/boot/dts/imx6sl.dtsi  | 2 +-
>  arch/arm/boot/dts/imx6sll.dtsi | 2 +-
>  arch/arm/boot/dts/imx6sx.dtsi  | 2 +-
>  arch/arm/boot/dts/imx6ul.dtsi  | 2 +-
>  arch/arm/boot/dts/imx7s.dtsi   | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index fe17a3405edc..5b54f1bfa03d 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -693,7 +693,7 @@
>  			};
>  
>  			anatop: anatop@20c8000 {
> -				compatible = "fsl,imx6q-anatop", "syscon", "simple-bus";
> +				compatible = "fsl,imx6q-anatop", "syscon";
>  				reg = <0x020c8000 0x1000>;
>  				interrupts = <0 49 IRQ_TYPE_LEVEL_HIGH>,
>  					     <0 54 IRQ_TYPE_LEVEL_HIGH>,
> diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
> index 4b4813f176cd..1bbcfcf6b2fc 100644
> --- a/arch/arm/boot/dts/imx6sl.dtsi
> +++ b/arch/arm/boot/dts/imx6sl.dtsi
> @@ -518,7 +518,7 @@
>  			anatop: anatop@20c8000 {
>  				compatible = "fsl,imx6sl-anatop",
>  					     "fsl,imx6q-anatop",
> -					     "syscon", "simple-bus";
> +					     "syscon";
>  				reg = <0x020c8000 0x1000>;
>  				interrupts = <0 49 IRQ_TYPE_LEVEL_HIGH>,
>  					     <0 54 IRQ_TYPE_LEVEL_HIGH>,
> diff --git a/arch/arm/boot/dts/imx6sll.dtsi b/arch/arm/boot/dts/imx6sll.dtsi
> index 62847c68330b..b2caf86dd9a9 100644
> --- a/arch/arm/boot/dts/imx6sll.dtsi
> +++ b/arch/arm/boot/dts/imx6sll.dtsi
> @@ -506,7 +506,7 @@
>  			anatop: anatop@20c8000 {
>  				compatible = "fsl,imx6sll-anatop",
>  					     "fsl,imx6q-anatop",
> -					     "syscon", "simple-bus";
> +					     "syscon";
>  				reg = <0x020c8000 0x4000>;
>  				interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>,
>  					     <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>,
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 5b16e65f7696..44b2824a0a3f 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -594,7 +594,7 @@
>  
>  			anatop: anatop@20c8000 {
>  				compatible = "fsl,imx6sx-anatop", "fsl,imx6q-anatop",
> -					     "syscon", "simple-bus";
> +					     "syscon";
>  				reg = <0x020c8000 0x1000>;
>  				interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>,
>  					     <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>,
> diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
> index 3282eed497ea..6916d8ea1abc 100644
> --- a/arch/arm/boot/dts/imx6ul.dtsi
> +++ b/arch/arm/boot/dts/imx6ul.dtsi
> @@ -557,7 +557,7 @@
>  
>  			anatop: anatop@20c8000 {
>  				compatible = "fsl,imx6ul-anatop", "fsl,imx6q-anatop",
> -					     "syscon", "simple-bus";
> +					     "syscon";
>  				reg = <0x020c8000 0x1000>;
>  				interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>,
>  					     <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>,
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> index 81fe18c0b7da..73fea5b16b6c 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -519,7 +519,7 @@
>  
>  			anatop: anatop@30360000 {
>  				compatible = "fsl,imx7d-anatop", "fsl,imx6q-anatop",
> -					"syscon", "simple-bus";
> +					"syscon";
>  				reg = <0x30360000 0x10000>;
>  				interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>,
>  					<GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH>;
> -- 
> 2.17.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de
Subject: Re: [PATCH] ARM: dts: imx: Remove 'simple-bus' from anatop compatible
Date: Tue, 22 Jan 2019 14:06:25 +0800	[thread overview]
Message-ID: <20190122060624.GD19929@dragon> (raw)
In-Reply-To: <20190121202905.31224-1-festevam@gmail.com>

On Mon, Jan 21, 2019 at 06:29:05PM -0200, Fabio Estevam wrote:
> dtc gives the following warnings when building with W=1:
> 
> arch/arm/boot/dts/imx6qdl.dtsi:702.19-715.7: Warning (simple_bus_reg): /soc/aips-bus@2000000/anatop@20c8000/regulator-1p1: missing or empty reg/ranges property
> arch/arm/boot/dts/imx6qdl.dtsi:717.19-730.7: Warning (simple_bus_reg): /soc/aips-bus@2000000/anatop@20c8000/regulator-3p0: missing or empty reg/ranges property
> arch/arm/boot/dts/imx6qdl.dtsi:732.19-745.7: Warning (simple_bus_reg): /soc/aips-bus@2000000/anatop@20c8000/regulator-2p5: missing or empty reg/ranges property
> arch/arm/boot/dts/imx6qdl.dtsi:747.32-762.7: Warning (simple_bus_reg): /soc/aips-bus@2000000/anatop@20c8000/regulator-vddcore: missing or empty reg/ranges property
> arch/arm/boot/dts/imx6qdl.dtsi:764.29-779.7: Warning (simple_bus_reg): /soc/aips-bus@2000000/anatop@20c8000/regulator-vddpu: missing or empty reg/ranges property
> arch/arm/boot/dts/imx6qdl.dtsi:781.31-796.7: Warning (simple_bus_reg): /soc/aips-bus@2000000/anatop@20c8000/regulator-vddsoc: missing or empty reg/ranges property
> 
> Remove 'simple-bus' from the compatible list of anatop, since it is a
> regulator and thus should not be described as 'simple-bus'.

Will the child regulator devices still be populated by kernel?

Shawn

> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  arch/arm/boot/dts/imx6qdl.dtsi | 2 +-
>  arch/arm/boot/dts/imx6sl.dtsi  | 2 +-
>  arch/arm/boot/dts/imx6sll.dtsi | 2 +-
>  arch/arm/boot/dts/imx6sx.dtsi  | 2 +-
>  arch/arm/boot/dts/imx6ul.dtsi  | 2 +-
>  arch/arm/boot/dts/imx7s.dtsi   | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index fe17a3405edc..5b54f1bfa03d 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -693,7 +693,7 @@
>  			};
>  
>  			anatop: anatop@20c8000 {
> -				compatible = "fsl,imx6q-anatop", "syscon", "simple-bus";
> +				compatible = "fsl,imx6q-anatop", "syscon";
>  				reg = <0x020c8000 0x1000>;
>  				interrupts = <0 49 IRQ_TYPE_LEVEL_HIGH>,
>  					     <0 54 IRQ_TYPE_LEVEL_HIGH>,
> diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
> index 4b4813f176cd..1bbcfcf6b2fc 100644
> --- a/arch/arm/boot/dts/imx6sl.dtsi
> +++ b/arch/arm/boot/dts/imx6sl.dtsi
> @@ -518,7 +518,7 @@
>  			anatop: anatop@20c8000 {
>  				compatible = "fsl,imx6sl-anatop",
>  					     "fsl,imx6q-anatop",
> -					     "syscon", "simple-bus";
> +					     "syscon";
>  				reg = <0x020c8000 0x1000>;
>  				interrupts = <0 49 IRQ_TYPE_LEVEL_HIGH>,
>  					     <0 54 IRQ_TYPE_LEVEL_HIGH>,
> diff --git a/arch/arm/boot/dts/imx6sll.dtsi b/arch/arm/boot/dts/imx6sll.dtsi
> index 62847c68330b..b2caf86dd9a9 100644
> --- a/arch/arm/boot/dts/imx6sll.dtsi
> +++ b/arch/arm/boot/dts/imx6sll.dtsi
> @@ -506,7 +506,7 @@
>  			anatop: anatop@20c8000 {
>  				compatible = "fsl,imx6sll-anatop",
>  					     "fsl,imx6q-anatop",
> -					     "syscon", "simple-bus";
> +					     "syscon";
>  				reg = <0x020c8000 0x4000>;
>  				interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>,
>  					     <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>,
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 5b16e65f7696..44b2824a0a3f 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -594,7 +594,7 @@
>  
>  			anatop: anatop@20c8000 {
>  				compatible = "fsl,imx6sx-anatop", "fsl,imx6q-anatop",
> -					     "syscon", "simple-bus";
> +					     "syscon";
>  				reg = <0x020c8000 0x1000>;
>  				interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>,
>  					     <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>,
> diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
> index 3282eed497ea..6916d8ea1abc 100644
> --- a/arch/arm/boot/dts/imx6ul.dtsi
> +++ b/arch/arm/boot/dts/imx6ul.dtsi
> @@ -557,7 +557,7 @@
>  
>  			anatop: anatop@20c8000 {
>  				compatible = "fsl,imx6ul-anatop", "fsl,imx6q-anatop",
> -					     "syscon", "simple-bus";
> +					     "syscon";
>  				reg = <0x020c8000 0x1000>;
>  				interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>,
>  					     <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>,
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> index 81fe18c0b7da..73fea5b16b6c 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -519,7 +519,7 @@
>  
>  			anatop: anatop@30360000 {
>  				compatible = "fsl,imx7d-anatop", "fsl,imx6q-anatop",
> -					"syscon", "simple-bus";
> +					"syscon";
>  				reg = <0x30360000 0x10000>;
>  				interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>,
>  					<GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH>;
> -- 
> 2.17.1
> 

  reply	other threads:[~2019-01-22  6:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-21 20:29 [PATCH] ARM: dts: imx: Remove 'simple-bus' from anatop compatible Fabio Estevam
2019-01-21 20:29 ` Fabio Estevam
2019-01-22  6:06 ` Shawn Guo [this message]
2019-01-22  6:06   ` Shawn Guo
2019-01-22 12:04   ` Fabio Estevam
2019-01-22 12:04     ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190122060624.GD19929@dragon \
    --to=shawnguo@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.