From: Wolfram Sang <wsa@the-dreams.de>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: imx: fix inconsistent IS_ERR and PTR_ERR
Date: Wed, 23 Jan 2019 09:28:49 +0100 [thread overview]
Message-ID: <20190123082849.GA1129@kunai> (raw)
In-Reply-To: <20190123003741.GA12068@embeddedor>
[-- Attachment #1: Type: text/plain, Size: 468 bytes --]
On Tue, Jan 22, 2019 at 06:37:41PM -0600, Gustavo A. R. Silva wrote:
> Fix inconsistent IS_ERR and PTR_ERR in i2c_imx_dma_request.
>
> The proper pointer to be passed as argument is dma->chan_tx.
>
> This bug was detected with the help of Coccinelle.
>
> Fixes: 5b3a23a3cc94 ("i2c: imx: notify about real errors on dma i2c_imx_dma_request")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
I pushed a similar fix to linux-next yesterday.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org,
Oleksij Rempel <o.rempel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: imx: fix inconsistent IS_ERR and PTR_ERR
Date: Wed, 23 Jan 2019 09:28:49 +0100 [thread overview]
Message-ID: <20190123082849.GA1129@kunai> (raw)
In-Reply-To: <20190123003741.GA12068@embeddedor>
[-- Attachment #1.1: Type: text/plain, Size: 468 bytes --]
On Tue, Jan 22, 2019 at 06:37:41PM -0600, Gustavo A. R. Silva wrote:
> Fix inconsistent IS_ERR and PTR_ERR in i2c_imx_dma_request.
>
> The proper pointer to be passed as argument is dma->chan_tx.
>
> This bug was detected with the help of Coccinelle.
>
> Fixes: 5b3a23a3cc94 ("i2c: imx: notify about real errors on dma i2c_imx_dma_request")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
I pushed a similar fix to linux-next yesterday.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-23 8:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 0:37 [PATCH] i2c: imx: fix inconsistent IS_ERR and PTR_ERR Gustavo A. R. Silva
2019-01-23 0:37 ` Gustavo A. R. Silva
2019-01-23 0:37 ` Gustavo A. R. Silva
2019-01-23 8:28 ` Wolfram Sang [this message]
2019-01-23 8:28 ` Wolfram Sang
2019-01-23 8:55 ` Gustavo A. R. Silva
2019-01-23 8:55 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123082849.GA1129@kunai \
--to=wsa@the-dreams.de \
--cc=fabio.estevam@nxp.com \
--cc=gustavo@embeddedor.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.