From: Borislav Petkov <bp@alien8.de>
To: James Morse <james.morse@arm.com>
Cc: Rui Zhao <ruizhao@microsoft.com>, Sasha Levin <sashal@kernel.org>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux Kernel <linux-kernel@microsoft.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"okaya@kernel.org" <okaya@kernel.org>
Subject: EDAC, dmc520:: add DMC520 EDAC driver
Date: Wed, 23 Jan 2019 19:46:39 +0100 [thread overview]
Message-ID: <20190123184639.GD3227@zn.tnic> (raw)
On Wed, Jan 23, 2019 at 06:36:23PM +0000, James Morse wrote:
> > Would like to know what's the impact if this error happens, and how to fit it
> > with current reporting in EDAC core.
>
> At a guess the interrupt triggers when link_err_count increases. (link_err has
> an overflow bit, so the interrupt must be related to a counter).
>
> If we could associate a link with a layer in edac, we could report errors
> against that point. But I've no idea how 'links' correspond with 'ranks and banks'!
Well, I have no clue what kind of links you guys are talking but if
those are per-chance coherent links used by cores to communicate in a
coherent fabric, or cores and devices, what would showing those errors
to the user bring ya?
Or are ya talking about different kinds of links?
In any case, the first question to ask would be, can some agent or the
user do something with the information that X or Y link errors happened?
If not, then why bother?
If yes, then that's a different story.
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: James Morse <james.morse@arm.com>
Cc: Rui Zhao <ruizhao@microsoft.com>, Sasha Levin <sashal@kernel.org>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux Kernel <linux-kernel@microsoft.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"okaya@kernel.org" <okaya@kernel.org>
Subject: Re: [PATCH] EDAC, dmc520:: add DMC520 EDAC driver
Date: Wed, 23 Jan 2019 19:46:39 +0100 [thread overview]
Message-ID: <20190123184639.GD3227@zn.tnic> (raw)
In-Reply-To: <7d404c61-a916-5d5e-35cc-0f6f016cd8a9@arm.com>
On Wed, Jan 23, 2019 at 06:36:23PM +0000, James Morse wrote:
> > Would like to know what's the impact if this error happens, and how to fit it
> > with current reporting in EDAC core.
>
> At a guess the interrupt triggers when link_err_count increases. (link_err has
> an overflow bit, so the interrupt must be related to a counter).
>
> If we could associate a link with a layer in edac, we could report errors
> against that point. But I've no idea how 'links' correspond with 'ranks and banks'!
Well, I have no clue what kind of links you guys are talking but if
those are per-chance coherent links used by cores to communicate in a
coherent fabric, or cores and devices, what would showing those errors
to the user bring ya?
Or are ya talking about different kinds of links?
In any case, the first question to ask would be, can some agent or the
user do something with the information that X or Y link errors happened?
If not, then why bother?
If yes, then that's a different story.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next reply other threads:[~2019-01-23 18:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 18:46 Borislav Petkov [this message]
2019-01-23 18:46 ` [PATCH] EDAC, dmc520:: add DMC520 EDAC driver Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2019-03-06 5:20 Rui Zhao
2019-03-06 5:20 ` [PATCH] " Rui Zhao
2019-02-05 17:31 James Morse
2019-02-05 17:31 ` [PATCH] " James Morse
2019-02-05 17:31 James Morse
2019-02-05 17:31 ` [PATCH] " James Morse
2019-01-23 22:08 Rui Zhao
2019-01-23 22:08 ` [PATCH] " Rui Zhao
2019-01-23 19:09 Sasha Levin
2019-01-23 19:09 ` [PATCH] " Sasha Levin
2019-01-23 19:03 Borislav Petkov
2019-01-23 19:03 ` [PATCH] " Borislav Petkov
2019-01-23 18:50 Sasha Levin
2019-01-23 18:50 ` [PATCH] " Sasha Levin
2019-01-23 18:36 James Morse
2019-01-23 18:36 ` [PATCH] " James Morse
2019-01-21 17:09 James Morse
2019-01-21 17:09 ` [PATCH] " James Morse
2019-01-21 12:35 Borislav Petkov
2019-01-21 12:35 ` [PATCH] " Borislav Petkov
2019-01-18 16:23 Sasha Levin
2019-01-18 16:23 ` [PATCH] " Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123184639.GD3227@zn.tnic \
--to=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=okaya@kernel.org \
--cc=ruizhao@microsoft.com \
--cc=sashal@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.