From: Marek Behun <marek.behun@nic.cz>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next v1 1/2] net: dsa: mv88e6xxx: Default CMODE to 1000BaseX only on 6390X
Date: Thu, 24 Jan 2019 17:29:16 +0100 [thread overview]
Message-ID: <20190124172916.66e15b29@nic.cz> (raw)
In-Reply-To: <20190124161147.GG482@lunn.ch>
> Hi Marek
>
> Although the previous behaviour might of allowed the cmode to be NA,
> i'm not sure that is a good idea. How do you know the port actually is
> using 2500BaseX, and not SGMII for example?
>
> You really should set the interface mode in the device tree file, so
> you know it does have the value you want.
>
> Andrew
Hi Andrew,
yes, I wanted to set the cpu port mode in DTS at first, but if I
understood the code correctly (maybe I made a mistake), the CPU port
mode is not determined from DTS (since there is no phy). Am I wrong?
It would be better if it was forced from DTS from the CPU port node.
On Turris Mox the mode is set by pin configuration after reset.
Marek
next prev parent reply other threads:[~2019-01-24 16:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 15:43 [PATCH net-next v1 1/2] net: dsa: mv88e6xxx: Default CMODE to 1000BaseX only on 6390X Marek Behún
2019-01-24 15:43 ` [PATCH net-next v1 2/2] net: dsa: mv88e6xxx: Fix phylink_validate for Topaz family Marek Behún
2019-01-24 16:01 ` Andrew Lunn
2019-01-24 16:11 ` [PATCH net-next v1 1/2] net: dsa: mv88e6xxx: Default CMODE to 1000BaseX only on 6390X Andrew Lunn
2019-01-24 16:29 ` Marek Behun [this message]
2019-01-24 16:48 ` Andrew Lunn
2019-01-24 18:04 ` Marek Behun
2019-01-24 18:11 ` Andrew Lunn
2019-01-24 19:24 ` Marek Behun
2019-01-24 19:27 ` Florian Fainelli
2019-01-24 19:31 ` Andrew Lunn
2019-01-24 19:37 ` Marek Behun
2019-01-24 19:56 ` Florian Fainelli
2019-01-24 19:39 ` Marek Behun
2019-01-25 18:48 ` Florian Fainelli
2019-01-25 19:25 ` Marek Behun
2019-01-28 20:34 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190124172916.66e15b29@nic.cz \
--to=marek.behun@nic.cz \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.