From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Marek Behun <marek.behun@nic.cz>,
netdev@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next v1 1/2] net: dsa: mv88e6xxx: Default CMODE to 1000BaseX only on 6390X
Date: Thu, 24 Jan 2019 20:31:18 +0100 [thread overview]
Message-ID: <20190124193118.GA13964@lunn.ch> (raw)
In-Reply-To: <3c81ed78-4f0e-37b1-710c-6d96c3e76577@gmail.com>
> > The function dsa_port_fixed_link_register_of creates this phy device,
> > adjusts the link and then calls put_device(&phydev->mdio.dev);
> > Does this mean that the phy device is immediately destroyed?
>
> Yes, we should actually migrate that code over to PHYLINK, because in
> PHYLINK the fixed links don't require creating a phy_device instance.
> This is something that has a potential of breaking a lot of people, so I
> have not really started doing it just yet :)
Hi Florian
It also has the advantage of being easier to implement. In order to
support 2.5G, i think we need C45 support, etc in the simulator.
Avoiding that would be nice.
Andrew
next prev parent reply other threads:[~2019-01-24 19:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 15:43 [PATCH net-next v1 1/2] net: dsa: mv88e6xxx: Default CMODE to 1000BaseX only on 6390X Marek Behún
2019-01-24 15:43 ` [PATCH net-next v1 2/2] net: dsa: mv88e6xxx: Fix phylink_validate for Topaz family Marek Behún
2019-01-24 16:01 ` Andrew Lunn
2019-01-24 16:11 ` [PATCH net-next v1 1/2] net: dsa: mv88e6xxx: Default CMODE to 1000BaseX only on 6390X Andrew Lunn
2019-01-24 16:29 ` Marek Behun
2019-01-24 16:48 ` Andrew Lunn
2019-01-24 18:04 ` Marek Behun
2019-01-24 18:11 ` Andrew Lunn
2019-01-24 19:24 ` Marek Behun
2019-01-24 19:27 ` Florian Fainelli
2019-01-24 19:31 ` Andrew Lunn [this message]
2019-01-24 19:37 ` Marek Behun
2019-01-24 19:56 ` Florian Fainelli
2019-01-24 19:39 ` Marek Behun
2019-01-25 18:48 ` Florian Fainelli
2019-01-25 19:25 ` Marek Behun
2019-01-28 20:34 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190124193118.GA13964@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=marek.behun@nic.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.