From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jiri Slaby <jslaby@suse.cz>
Cc: thomas@winischhofer.net, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [1/4] tty: sisusb_con, convert addr macros to functions
Date: Fri, 25 Jan 2019 10:03:28 +0100 [thread overview]
Message-ID: <20190125090328.GA11818@kroah.com> (raw)
On Tue, Jan 22, 2019 at 04:26:12PM +0100, Jiri Slaby wrote:
> On 22. 01. 19, 16:23, Greg KH wrote:
> > On Tue, Jan 22, 2019 at 04:11:59PM +0100, Jiri Slaby wrote:
> >> Convert SISUSB_VADDR and SISUSB_HADDR to inline functions. Now, there
> >> are no more hidden accesses to local variables (vc_data and
> >> sisusb_usb_data).
> >>
> >> sisusb_haddr returns unsigned long from now on, not u16 *, as ulong is
> >> what every caller expects -- we can remove some casts.
> >>
> >> Call sites were aligned to be readable too.
> >>
> >> Use sisusb_haddr on 4 more places in sisusbcon_blank and
> >> sisusbcon_scroll. It was open coded there with [x, y] being [0, 0].
> >>
> >> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> >> ---
> >> drivers/usb/misc/sisusbvga/sisusb_con.c | 78 ++++++++++++-------------
> >> 1 file changed, 39 insertions(+), 39 deletions(-)
> >
> > Subject says "tty", yet this is the USB driver. typo?
>
> Originally, I had these as a part of various tty cleanups and the tty
> remained there. I will wait for some feedback, if any and drop them in
> v2.
No problem, I fixed it up and queued it up already, as it looks good,
thanks!
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Jiri Slaby <jslaby@suse.cz>
Cc: thomas@winischhofer.net, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] tty: sisusb_con, convert addr macros to functions
Date: Fri, 25 Jan 2019 10:03:28 +0100 [thread overview]
Message-ID: <20190125090328.GA11818@kroah.com> (raw)
In-Reply-To: <15c671db-581d-7155-ea40-40d239069cb4@suse.cz>
On Tue, Jan 22, 2019 at 04:26:12PM +0100, Jiri Slaby wrote:
> On 22. 01. 19, 16:23, Greg KH wrote:
> > On Tue, Jan 22, 2019 at 04:11:59PM +0100, Jiri Slaby wrote:
> >> Convert SISUSB_VADDR and SISUSB_HADDR to inline functions. Now, there
> >> are no more hidden accesses to local variables (vc_data and
> >> sisusb_usb_data).
> >>
> >> sisusb_haddr returns unsigned long from now on, not u16 *, as ulong is
> >> what every caller expects -- we can remove some casts.
> >>
> >> Call sites were aligned to be readable too.
> >>
> >> Use sisusb_haddr on 4 more places in sisusbcon_blank and
> >> sisusbcon_scroll. It was open coded there with [x, y] being [0, 0].
> >>
> >> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> >> ---
> >> drivers/usb/misc/sisusbvga/sisusb_con.c | 78 ++++++++++++-------------
> >> 1 file changed, 39 insertions(+), 39 deletions(-)
> >
> > Subject says "tty", yet this is the USB driver. typo?
>
> Originally, I had these as a part of various tty cleanups and the tty
> remained there. I will wait for some feedback, if any and drop them in
> v2.
No problem, I fixed it up and queued it up already, as it looks good,
thanks!
greg k-h
next reply other threads:[~2019-01-25 9:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 9:03 Greg Kroah-Hartman [this message]
2019-01-25 9:03 ` [PATCH 1/4] tty: sisusb_con, convert addr macros to functions Greg KH
-- strict thread matches above, loose matches on Subject: below --
2019-01-22 15:57 [4/4] sisusb: remove useless macros and compact the code Joe Perches
2019-01-22 15:57 ` [PATCH 4/4] " Joe Perches
2019-01-22 15:26 [1/4] tty: sisusb_con, convert addr macros to functions Jiri Slaby
2019-01-22 15:26 ` [PATCH 1/4] " Jiri Slaby
2019-01-22 15:23 [1/4] " Greg Kroah-Hartman
2019-01-22 15:23 ` [PATCH 1/4] " Greg KH
2019-01-22 15:12 [4/4] sisusb: remove useless macros and compact the code Jiri Slaby
2019-01-22 15:12 ` [PATCH 4/4] " Jiri Slaby
2019-01-22 15:12 [3/4] sisusb: let files build only when needed Jiri Slaby
2019-01-22 15:12 ` [PATCH 3/4] " Jiri Slaby
2019-01-22 15:12 [2/4] tty: sisusb_con, cleanup configs Jiri Slaby
2019-01-22 15:12 ` [PATCH 2/4] " Jiri Slaby
2019-01-22 15:11 [1/4] tty: sisusb_con, convert addr macros to functions Jiri Slaby
2019-01-22 15:11 ` [PATCH 1/4] " Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125090328.GA11818@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=thomas@winischhofer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.