From: Keith Busch <keith.busch@intel.com>
To: Dongdong Liu <liudongdong3@huawei.com>
Cc: Sinan Kaya <okaya@kernel.org>,
"helgaas@kernel.org" <helgaas@kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linuxarm@huawei.com" <linuxarm@huawei.com>,
Bjorn Helgaas <bhelgaas@google.com>,
tanxiaofei <tanxiaofei@huawei.com>
Subject: Re: [PATCH] PCI/ERR: Fix run error recovery callbacks for all affected devices
Date: Fri, 25 Jan 2019 10:17:13 -0700 [thread overview]
Message-ID: <20190125171713.GB11210@localhost.localdomain> (raw)
In-Reply-To: <5d58ea17-115f-139d-93db-fe6e9ce573cb@huawei.com>
On Fri, Jan 25, 2019 at 06:28:03AM -0800, Dongdong Liu wrote:
> I want to fix 2 points by the patch.
>
> 1. For EP devices (such as multi-function EP device) under the same bus,
> when one of the EP devices met non-fatal error, should report non-fatal
> error only to the error endpoint device, no need to broadcast all of them.
> That is the patch (PCI/AER: Report non-fatal errors only to the affected endpoint #4.15)
> have done, but current code PATCH [1] broken this.
How do you know a non-fatal affects only the reporting end point? These can
certainly be bus errors, and it's not the first to detect may be affected.
In any case, what harm does the broadcast cause?
next prev parent reply other threads:[~2019-01-25 17:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 13:50 [PATCH] PCI/ERR: Fix run error recovery callbacks for all affected devices Dongdong Liu
2019-01-24 18:18 ` Sinan Kaya
2019-01-24 21:37 ` Keith Busch
2019-01-25 14:28 ` Dongdong Liu
2019-01-25 17:09 ` Sinan Kaya
2019-01-28 14:05 ` Dongdong Liu
2019-01-25 17:17 ` Keith Busch [this message]
2019-01-25 17:37 ` Sinan Kaya
2019-01-25 17:46 ` Keith Busch
2019-01-25 17:46 ` Sinan Kaya
2019-01-28 14:54 ` Dongdong Liu
2019-01-28 15:47 ` Sinan Kaya
2019-01-28 16:15 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125171713.GB11210@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liudongdong3@huawei.com \
--cc=okaya@kernel.org \
--cc=tanxiaofei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.