From: Sinan Kaya <okaya@kernel.org>
To: Dongdong Liu <liudongdong3@huawei.com>,
helgaas@kernel.org, keith.busch@intel.com
Cc: linux-pci@vger.kernel.org, linuxarm@huawei.com,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] PCI/ERR: Fix run error recovery callbacks for all affected devices
Date: Thu, 24 Jan 2019 13:18:26 -0500 [thread overview]
Message-ID: <ea302148-7778-d295-4fca-cec436b64e28@kernel.org> (raw)
In-Reply-To: <1548337810-69892-1-git-send-email-liudongdong3@huawei.com>
On 1/24/2019 8:50 AM, Dongdong Liu wrote:
> The patch [1] PCI/ERR: Run error recovery callbacks for all affected
> devices have broken the non-fatal error handling logic in patch [2].
> For non-fatal error, link is reliable, so no need to reset link,
> handle non-fatal error for all subordinates seems incorrect.
> Restore the non-fatal errors process logic.
>
> [1] PCI/ERR: Run error recovery callbacks for all affected devices #4.20
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bfcb79fca19d267712e425af1dd48812c40dec0c
>
> [2] PCI/AER: Report non-fatal errors only to the affected endpoint #4.15
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.0-rc2&id=86acc790717fb60fb51ea3095084e331d8711c74
>
> Fixes: bfcb79fca19d ("PCI/ERR: Run error recovery callbacks for all affected devices")
> Reported-by: Xiaofei Tan<tanxiaofei@huawei.com>
> Signed-off-by: Dongdong Liu<liudongdong3@huawei.com>
> Cc: Keith Busch<keith.busch@intel.com>
> Cc: Bjorn Helgaas<bhelgaas@google.com>
According to what I see in the code, link will be reset only if the AER
severity is AER_FATAL.
} else if (info->severity == AER_NONFATAL)
pcie_do_recovery(dev, pci_channel_io_normal,
PCIE_PORT_SERVICE_AER);
else if (info->severity == AER_FATAL)
pcie_do_recovery(dev, pci_channel_io_frozen,
PCIE_PORT_SERVICE_AER);
Can you show the path where it leads to link reset and severity is AER_NONFATAL?
next prev parent reply other threads:[~2019-01-24 18:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 13:50 [PATCH] PCI/ERR: Fix run error recovery callbacks for all affected devices Dongdong Liu
2019-01-24 18:18 ` Sinan Kaya [this message]
2019-01-24 21:37 ` Keith Busch
2019-01-25 14:28 ` Dongdong Liu
2019-01-25 17:09 ` Sinan Kaya
2019-01-28 14:05 ` Dongdong Liu
2019-01-25 17:17 ` Keith Busch
2019-01-25 17:37 ` Sinan Kaya
2019-01-25 17:46 ` Keith Busch
2019-01-25 17:46 ` Sinan Kaya
2019-01-28 14:54 ` Dongdong Liu
2019-01-28 15:47 ` Sinan Kaya
2019-01-28 16:15 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea302148-7778-d295-4fca-cec436b64e28@kernel.org \
--to=okaya@kernel.org \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liudongdong3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.