* [PATCH v2] drm/i915: Disable -Wuninitialized
@ 2019-01-26 7:11 ` Nathan Chancellor
0 siblings, 0 replies; 14+ messages in thread
From: Nathan Chancellor @ 2019-01-26 7:11 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi
Cc: intel-gfx, Nick Desaulniers, linux-kernel, dri-devel,
Matthias Kaehlcke, Nathan Chancellor
This warning is disabled by default in scripts/Makefile.extrawarn when
W= is not provided but this Makefile adds -Wall after this warning is
disabled so it shows up in the build when it shouldn't:
In file included from drivers/gpu/drm/i915/intel_breadcrumbs.c:895:
drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c:350:34: error:
variable 'wq' is uninitialized when used within its own initialization
[-Werror,-Wuninitialized]
DECLARE_WAIT_QUEUE_HEAD_ONSTACK(wq);
^~
./include/linux/wait.h:74:63: note: expanded from macro
'DECLARE_WAIT_QUEUE_HEAD_ONSTACK'
struct wait_queue_head name = __WAIT_QUEUE_HEAD_INIT_ONSTACK(name)
~~~~ ^~~~
./include/linux/wait.h:72:33: note: expanded from macro
'__WAIT_QUEUE_HEAD_INIT_ONSTACK'
({ init_waitqueue_head(&name); name; })
^~~~
1 error generated.
Explicitly disable the warning like commit 46e2068081e9 ("drm/i915:
Disable some extra clang warnings").
Link: https://github.com/ClangBuiltLinux/linux/issues/220
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
v1 -> v2:
* Rather than disable the warning for the problematic folder, disable it
for the entire folder like Matthias's commit.
drivers/gpu/drm/i915/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
index 8300efe60fe1..210d0e8777b6 100644
--- a/drivers/gpu/drm/i915/Makefile
+++ b/drivers/gpu/drm/i915/Makefile
@@ -22,6 +22,7 @@ subdir-ccflags-y += $(call cc-disable-warning, unused-but-set-variable)
subdir-ccflags-y += $(call cc-disable-warning, sign-compare)
subdir-ccflags-y += $(call cc-disable-warning, sometimes-uninitialized)
subdir-ccflags-y += $(call cc-disable-warning, initializer-overrides)
+subdir-ccflags-y += $(call cc-disable-warning, uninitialized)
subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
# Fine grained warnings disable
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2] drm/i915: Disable -Wuninitialized
@ 2019-01-26 7:11 ` Nathan Chancellor
0 siblings, 0 replies; 14+ messages in thread
From: Nathan Chancellor @ 2019-01-26 7:11 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi
Cc: intel-gfx, dri-devel, linux-kernel, Nick Desaulniers,
Chris Wilson, Matthias Kaehlcke, Nathan Chancellor
This warning is disabled by default in scripts/Makefile.extrawarn when
W= is not provided but this Makefile adds -Wall after this warning is
disabled so it shows up in the build when it shouldn't:
In file included from drivers/gpu/drm/i915/intel_breadcrumbs.c:895:
drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c:350:34: error:
variable 'wq' is uninitialized when used within its own initialization
[-Werror,-Wuninitialized]
DECLARE_WAIT_QUEUE_HEAD_ONSTACK(wq);
^~
./include/linux/wait.h:74:63: note: expanded from macro
'DECLARE_WAIT_QUEUE_HEAD_ONSTACK'
struct wait_queue_head name = __WAIT_QUEUE_HEAD_INIT_ONSTACK(name)
~~~~ ^~~~
./include/linux/wait.h:72:33: note: expanded from macro
'__WAIT_QUEUE_HEAD_INIT_ONSTACK'
({ init_waitqueue_head(&name); name; })
^~~~
1 error generated.
Explicitly disable the warning like commit 46e2068081e9 ("drm/i915:
Disable some extra clang warnings").
Link: https://github.com/ClangBuiltLinux/linux/issues/220
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
v1 -> v2:
* Rather than disable the warning for the problematic folder, disable it
for the entire folder like Matthias's commit.
drivers/gpu/drm/i915/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
index 8300efe60fe1..210d0e8777b6 100644
--- a/drivers/gpu/drm/i915/Makefile
+++ b/drivers/gpu/drm/i915/Makefile
@@ -22,6 +22,7 @@ subdir-ccflags-y += $(call cc-disable-warning, unused-but-set-variable)
subdir-ccflags-y += $(call cc-disable-warning, sign-compare)
subdir-ccflags-y += $(call cc-disable-warning, sometimes-uninitialized)
subdir-ccflags-y += $(call cc-disable-warning, initializer-overrides)
+subdir-ccflags-y += $(call cc-disable-warning, uninitialized)
subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
# Fine grained warnings disable
--
2.20.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2] drm/i915: Disable -Wuninitialized
2019-01-26 7:11 ` Nathan Chancellor
@ 2019-01-26 7:17 ` Nathan Chancellor
-1 siblings, 0 replies; 14+ messages in thread
From: Nathan Chancellor @ 2019-01-26 7:17 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi
Cc: intel-gfx, Nick Desaulniers, linux-kernel, dri-devel,
Matthias Kaehlcke
On Sat, Jan 26, 2019 at 12:11:23AM -0700, Nathan Chancellor wrote:
> This warning is disabled by default in scripts/Makefile.extrawarn when
> W= is not provided but this Makefile adds -Wall after this warning is
> disabled so it shows up in the build when it shouldn't:
>
> In file included from drivers/gpu/drm/i915/intel_breadcrumbs.c:895:
> drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c:350:34: error:
> variable 'wq' is uninitialized when used within its own initialization
> [-Werror,-Wuninitialized]
> DECLARE_WAIT_QUEUE_HEAD_ONSTACK(wq);
> ^~
> ./include/linux/wait.h:74:63: note: expanded from macro
> 'DECLARE_WAIT_QUEUE_HEAD_ONSTACK'
> struct wait_queue_head name = __WAIT_QUEUE_HEAD_INIT_ONSTACK(name)
> ~~~~ ^~~~
> ./include/linux/wait.h:72:33: note: expanded from macro
> '__WAIT_QUEUE_HEAD_INIT_ONSTACK'
> ({ init_waitqueue_head(&name); name; })
> ^~~~
> 1 error generated.
>
> Explicitly disable the warning like commit 46e2068081e9 ("drm/i915:
> Disable some extra clang warnings").
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/220
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
>
> v1 -> v2:
>
> * Rather than disable the warning for the problematic folder, disable it
> for the entire folder like Matthias's commit.
>
Link to v1: https://lore.kernel.org/lkml/20181025193601.11746-1-natechancellor@gmail.com/
Since I forgot '--in-reply-to' :(
> drivers/gpu/drm/i915/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
> index 8300efe60fe1..210d0e8777b6 100644
> --- a/drivers/gpu/drm/i915/Makefile
> +++ b/drivers/gpu/drm/i915/Makefile
> @@ -22,6 +22,7 @@ subdir-ccflags-y += $(call cc-disable-warning, unused-but-set-variable)
> subdir-ccflags-y += $(call cc-disable-warning, sign-compare)
> subdir-ccflags-y += $(call cc-disable-warning, sometimes-uninitialized)
> subdir-ccflags-y += $(call cc-disable-warning, initializer-overrides)
> +subdir-ccflags-y += $(call cc-disable-warning, uninitialized)
> subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
>
> # Fine grained warnings disable
> --
> 2.20.1
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] drm/i915: Disable -Wuninitialized
@ 2019-01-26 7:17 ` Nathan Chancellor
0 siblings, 0 replies; 14+ messages in thread
From: Nathan Chancellor @ 2019-01-26 7:17 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi
Cc: intel-gfx, dri-devel, linux-kernel, Nick Desaulniers,
Chris Wilson, Matthias Kaehlcke
On Sat, Jan 26, 2019 at 12:11:23AM -0700, Nathan Chancellor wrote:
> This warning is disabled by default in scripts/Makefile.extrawarn when
> W= is not provided but this Makefile adds -Wall after this warning is
> disabled so it shows up in the build when it shouldn't:
>
> In file included from drivers/gpu/drm/i915/intel_breadcrumbs.c:895:
> drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c:350:34: error:
> variable 'wq' is uninitialized when used within its own initialization
> [-Werror,-Wuninitialized]
> DECLARE_WAIT_QUEUE_HEAD_ONSTACK(wq);
> ^~
> ./include/linux/wait.h:74:63: note: expanded from macro
> 'DECLARE_WAIT_QUEUE_HEAD_ONSTACK'
> struct wait_queue_head name = __WAIT_QUEUE_HEAD_INIT_ONSTACK(name)
> ~~~~ ^~~~
> ./include/linux/wait.h:72:33: note: expanded from macro
> '__WAIT_QUEUE_HEAD_INIT_ONSTACK'
> ({ init_waitqueue_head(&name); name; })
> ^~~~
> 1 error generated.
>
> Explicitly disable the warning like commit 46e2068081e9 ("drm/i915:
> Disable some extra clang warnings").
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/220
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
>
> v1 -> v2:
>
> * Rather than disable the warning for the problematic folder, disable it
> for the entire folder like Matthias's commit.
>
Link to v1: https://lore.kernel.org/lkml/20181025193601.11746-1-natechancellor@gmail.com/
Since I forgot '--in-reply-to' :(
> drivers/gpu/drm/i915/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
> index 8300efe60fe1..210d0e8777b6 100644
> --- a/drivers/gpu/drm/i915/Makefile
> +++ b/drivers/gpu/drm/i915/Makefile
> @@ -22,6 +22,7 @@ subdir-ccflags-y += $(call cc-disable-warning, unused-but-set-variable)
> subdir-ccflags-y += $(call cc-disable-warning, sign-compare)
> subdir-ccflags-y += $(call cc-disable-warning, sometimes-uninitialized)
> subdir-ccflags-y += $(call cc-disable-warning, initializer-overrides)
> +subdir-ccflags-y += $(call cc-disable-warning, uninitialized)
> subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
>
> # Fine grained warnings disable
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* ✗ Fi.CI.SPARSE: warning for drm/i915: Disable -Wuninitialized
2019-01-26 7:11 ` Nathan Chancellor
(?)
(?)
@ 2019-01-26 7:27 ` Patchwork
-1 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2019-01-26 7:27 UTC (permalink / raw)
To: Nathan Chancellor; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Disable -Wuninitialized
URL : https://patchwork.freedesktop.org/series/55769/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915: Disable -Wuninitialized
-
+./arch/x86/include/asm/pgtable_64.h:61:9: warning: cast from non-scalar
+./arch/x86/include/asm/pgtable_64.h:61:9: warning: cast to non-scalar
+drivers/gpu/drm/i915/gvt/gtt.c:757:9: expected void [noderef] <asn:4>**slot
+drivers/gpu/drm/i915/gvt/gtt.c:757:9: expected void **slot
+drivers/gpu/drm/i915/gvt/gtt.c:757:9: expected void **slot
+drivers/gpu/drm/i915/gvt/gtt.c:757:9: expected void **slot
+drivers/gpu/drm/i915/gvt/gtt.c:757:9: got void [noderef] <asn:4>**
+drivers/gpu/drm/i915/gvt/gtt.c:757:9: got void [noderef] <asn:4>**
+drivers/gpu/drm/i915/gvt/gtt.c:757:9: got void [noderef] <asn:4>**
+drivers/gpu/drm/i915/gvt/gtt.c:757:9: got void **slot
+drivers/gpu/drm/i915/gvt/gtt.c:757:9: warning: incorrect type in argument 1 (different address spaces)
+drivers/gpu/drm/i915/gvt/gtt.c:757:9: warning: incorrect type in assignment (different address spaces)
+drivers/gpu/drm/i915/gvt/gtt.c:757:9: warning: incorrect type in assignment (different address spaces)
+drivers/gpu/drm/i915/gvt/gtt.c:757:9: warning: incorrect type in assignment (different address spaces)
+drivers/gpu/drm/i915/gvt/gtt.c:758:45: expected void [noderef] <asn:4>**slot
+drivers/gpu/drm/i915/gvt/gtt.c:758:45: got void **slot
+drivers/gpu/drm/i915/gvt/gtt.c:758:45: warning: incorrect type in argument 1 (different address spaces)
+drivers/gpu/drm/i915/gvt/mmio.c:282:23: warning: memcpy with byte count of 279040
+drivers/gpu/drm/i915/gvt/mmio.c:283:23: warning: memcpy with byte count of 279040
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/gvt/vgpu.c:196:48: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_cmd_parser.c:1104:35: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_cmd_parser.c:1104:35: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_debugfs.c:4186:41: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_debugfs.c:4186:41: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_debugfs.c:4240:49: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_debugfs.c:4240:49: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_debugfs.c:4296:49: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_debugfs.c:4296:49: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_drv.c:1189:35: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_drv.c:1189:35: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_drv.c:349:25: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_drv.h:3541:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_drv.h:3541:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_drv.h:3541:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_drv.h:3541:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_drv.h:3541:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_drv.h:3541:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_drv.h:3541:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_drv.h:3551:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_fixed.h:42:43: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_fixed.h:42:43: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_fixed.h:50:43: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_fixed.h:50:43: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_fixed.h:50:43: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_fixed.h:50:43: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_fixed.h:50:43: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_fixed.h:50:43: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_fixed.h:50:43: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_fixed.h:50:43: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_fixed.h:50:43: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_fixed.h:50:43: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_fixed.h:50:43: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_fixed.h:50:43: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem.c:1025:39: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem.c:1025:39: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem.c:1431:39: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem.c:1431:39: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem.c:1832:17: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem.c:1832:17: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem.c:1832:17: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem.c:1832:17: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem.c:1957:32: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem.c:1957:32: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem.c:3752:34: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem.c:3752:34: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem.c:5489:36: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_execbuffer.c:1455:25: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:1376:9: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:1376:9: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:1413:9: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:1413:9: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:1464:9: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:1464:9: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:1500:9: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:1500:9: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:1515:9: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:1515:9: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:1676:42: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:1755:9: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:1755:9: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:2750:26: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:3389:34: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:3391:25: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:3391:25: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:3400:25: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:3400:25: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:348:14: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:348:14: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:3641:23: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:3641:23: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:852:9: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:852:9: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:894:9: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:894:9: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:943:9: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:943:9: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_internal.c:64:39: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_internal.c:66:37: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_internal.c:66:37: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_internal.c:94:29: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_internal.c:94:29: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_shrinker.c:344:25: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gpu_error.c:1037:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gpu_error.c:1037:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gpu_error.c:935:23: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gpu_error.c:935:23: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1273:22: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1273:22: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1354:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1354:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1354:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1354:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1354:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1354:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1354:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1354:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1354:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1354:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1354:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1354:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1354:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1354:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:940:20: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:940:20: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_perf.c:1422:15: warning: memset with byte count of 16777216
+drivers/gpu/drm/i915/i915_perf.c:1480:15: warning: memset with byte count of 16777216
+drivers/gpu/drm/i915/i915_sysfs.c:173:17: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:173:17: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:386:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:386:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:386:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:386:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:386:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:386:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:386:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:386:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:386:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:386:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:386:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:386:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:386:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:386:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:441:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:441:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:441:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:441:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:441:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:441:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:441:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:441:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:441:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:441:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:441:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:441:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:441:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:441:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:536:23: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_sysfs.c:536:23: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_vma.c:554:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_vma.c:554:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_vma.c:555:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_vma.c:555:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_vma.c:557:24: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_vma.c:557:24: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_vma.c:558:29: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_vma.c:558:29: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_vma.c:571:23: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_vma.c:571:23: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_vma.c:573:23: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_vma.c:644:37: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_vma.c:644:37: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/icl_dsi.c:129:33: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_audio.c:304:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_audio.c:304:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_audio.c:483:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_audio.c:602:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_audio.c:905:34: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_audio.c:905:34: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_cdclk.c:2180:37: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_cdclk.c:2183:37: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_cdclk.c:2203:29: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_cdclk.c:2211:29: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_cdclk.c:2244:29: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_cdclk.c:2244:29: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_cdclk.c:2280:37: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_cdclk.c:2280:37: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_cdclk.c:2482:17: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_cdclk.c:2482:17: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_cdclk.c:2518:17: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_cdclk.c:2518:17: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:101:33: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:101:33: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:101:33: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:101:33: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:101:33: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:101:33: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:101:33: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:180:37: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:180:37: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:180:37: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:180:37: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:180:37: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:180:37: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:180:37: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:188:41: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:188:41: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:188:41: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:188:41: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:188:41: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:188:41: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:188:41: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:191:41: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:191:41: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:191:41: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:191:41: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:191:41: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:191:41: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:191:41: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:194:41: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:194:41: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:194:41: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:194:41: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:194:41: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:194:41: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:194:41: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:196:46: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:196:46: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:196:46: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_color.c:196:46: warning: expression using si
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] drm/i915: Disable -Wuninitialized
2019-01-26 7:11 ` Nathan Chancellor
@ 2019-01-26 7:34 ` Nick Desaulniers
-1 siblings, 0 replies; 14+ messages in thread
From: Nick Desaulniers @ 2019-01-26 7:34 UTC (permalink / raw)
To: Nathan Chancellor; +Cc: intel-gfx, LKML, dri-devel, Matthias Kaehlcke
On Fri, Jan 25, 2019 at 11:13 PM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> This warning is disabled by default in scripts/Makefile.extrawarn when
> W= is not provided but this Makefile adds -Wall after this warning is
> disabled so it shows up in the build when it shouldn't:
>
> In file included from drivers/gpu/drm/i915/intel_breadcrumbs.c:895:
> drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c:350:34: error:
> variable 'wq' is uninitialized when used within its own initialization
> [-Werror,-Wuninitialized]
> DECLARE_WAIT_QUEUE_HEAD_ONSTACK(wq);
> ^~
> ./include/linux/wait.h:74:63: note: expanded from macro
> 'DECLARE_WAIT_QUEUE_HEAD_ONSTACK'
> struct wait_queue_head name = __WAIT_QUEUE_HEAD_INIT_ONSTACK(name)
> ~~~~ ^~~~
> ./include/linux/wait.h:72:33: note: expanded from macro
> '__WAIT_QUEUE_HEAD_INIT_ONSTACK'
> ({ init_waitqueue_head(&name); name; })
> ^~~~
> 1 error generated.
>
> Explicitly disable the warning like commit 46e2068081e9 ("drm/i915:
> Disable some extra clang warnings").
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/220
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <nick.desaulniers@gmail.com>
probably could give Chris Wilson the suggested by tag.
https://lore.kernel.org/lkml/154513398652.1108.7150969916024071452@skylake-alporthouse-com/
> ---
>
> v1 -> v2:
>
> * Rather than disable the warning for the problematic folder, disable it
> for the entire folder like Matthias's commit.
Thanks for following up with a v2.
--
Thanks,
~Nick Desaulniers
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] drm/i915: Disable -Wuninitialized
@ 2019-01-26 7:34 ` Nick Desaulniers
0 siblings, 0 replies; 14+ messages in thread
From: Nick Desaulniers @ 2019-01-26 7:34 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, intel-gfx, dri-devel,
LKML, Chris Wilson, Matthias Kaehlcke
On Fri, Jan 25, 2019 at 11:13 PM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> This warning is disabled by default in scripts/Makefile.extrawarn when
> W= is not provided but this Makefile adds -Wall after this warning is
> disabled so it shows up in the build when it shouldn't:
>
> In file included from drivers/gpu/drm/i915/intel_breadcrumbs.c:895:
> drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c:350:34: error:
> variable 'wq' is uninitialized when used within its own initialization
> [-Werror,-Wuninitialized]
> DECLARE_WAIT_QUEUE_HEAD_ONSTACK(wq);
> ^~
> ./include/linux/wait.h:74:63: note: expanded from macro
> 'DECLARE_WAIT_QUEUE_HEAD_ONSTACK'
> struct wait_queue_head name = __WAIT_QUEUE_HEAD_INIT_ONSTACK(name)
> ~~~~ ^~~~
> ./include/linux/wait.h:72:33: note: expanded from macro
> '__WAIT_QUEUE_HEAD_INIT_ONSTACK'
> ({ init_waitqueue_head(&name); name; })
> ^~~~
> 1 error generated.
>
> Explicitly disable the warning like commit 46e2068081e9 ("drm/i915:
> Disable some extra clang warnings").
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/220
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <nick.desaulniers@gmail.com>
probably could give Chris Wilson the suggested by tag.
https://lore.kernel.org/lkml/154513398652.1108.7150969916024071452@skylake-alporthouse-com/
> ---
>
> v1 -> v2:
>
> * Rather than disable the warning for the problematic folder, disable it
> for the entire folder like Matthias's commit.
Thanks for following up with a v2.
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] drm/i915: Disable -Wuninitialized
2019-01-26 7:34 ` Nick Desaulniers
@ 2019-01-26 7:35 ` Nick Desaulniers
-1 siblings, 0 replies; 14+ messages in thread
From: Nick Desaulniers @ 2019-01-26 7:35 UTC (permalink / raw)
To: Nathan Chancellor; +Cc: intel-gfx, LKML, dri-devel, Matthias Kaehlcke
On Fri, Jan 25, 2019 at 11:34 PM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> On Fri, Jan 25, 2019 at 11:13 PM Nathan Chancellor
> <natechancellor@gmail.com> wrote:
> >
> > This warning is disabled by default in scripts/Makefile.extrawarn when
> > W= is not provided but this Makefile adds -Wall after this warning is
> > disabled so it shows up in the build when it shouldn't:
> >
> > In file included from drivers/gpu/drm/i915/intel_breadcrumbs.c:895:
> > drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c:350:34: error:
> > variable 'wq' is uninitialized when used within its own initialization
> > [-Werror,-Wuninitialized]
> > DECLARE_WAIT_QUEUE_HEAD_ONSTACK(wq);
> > ^~
> > ./include/linux/wait.h:74:63: note: expanded from macro
> > 'DECLARE_WAIT_QUEUE_HEAD_ONSTACK'
> > struct wait_queue_head name = __WAIT_QUEUE_HEAD_INIT_ONSTACK(name)
> > ~~~~ ^~~~
> > ./include/linux/wait.h:72:33: note: expanded from macro
> > '__WAIT_QUEUE_HEAD_INIT_ONSTACK'
> > ({ init_waitqueue_head(&name); name; })
> > ^~~~
> > 1 error generated.
> >
> > Explicitly disable the warning like commit 46e2068081e9 ("drm/i915:
> > Disable some extra clang warnings").
> >
> > Link: https://github.com/ClangBuiltLinux/linux/issues/220
> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
>
> Reviewed-by: Nick Desaulniers <nick.desaulniers@gmail.com>
gah! I am on my work device, in that case it should be:
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
>
> probably could give Chris Wilson the suggested by tag.
> https://lore.kernel.org/lkml/154513398652.1108.7150969916024071452@skylake-alporthouse-com/
>
> > ---
> >
> > v1 -> v2:
> >
> > * Rather than disable the warning for the problematic folder, disable it
> > for the entire folder like Matthias's commit.
>
> Thanks for following up with a v2.
>
> --
> Thanks,
> ~Nick Desaulniers
--
Thanks,
~Nick Desaulniers
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] drm/i915: Disable -Wuninitialized
@ 2019-01-26 7:35 ` Nick Desaulniers
0 siblings, 0 replies; 14+ messages in thread
From: Nick Desaulniers @ 2019-01-26 7:35 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, intel-gfx, dri-devel,
LKML, Chris Wilson, Matthias Kaehlcke
On Fri, Jan 25, 2019 at 11:34 PM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> On Fri, Jan 25, 2019 at 11:13 PM Nathan Chancellor
> <natechancellor@gmail.com> wrote:
> >
> > This warning is disabled by default in scripts/Makefile.extrawarn when
> > W= is not provided but this Makefile adds -Wall after this warning is
> > disabled so it shows up in the build when it shouldn't:
> >
> > In file included from drivers/gpu/drm/i915/intel_breadcrumbs.c:895:
> > drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c:350:34: error:
> > variable 'wq' is uninitialized when used within its own initialization
> > [-Werror,-Wuninitialized]
> > DECLARE_WAIT_QUEUE_HEAD_ONSTACK(wq);
> > ^~
> > ./include/linux/wait.h:74:63: note: expanded from macro
> > 'DECLARE_WAIT_QUEUE_HEAD_ONSTACK'
> > struct wait_queue_head name = __WAIT_QUEUE_HEAD_INIT_ONSTACK(name)
> > ~~~~ ^~~~
> > ./include/linux/wait.h:72:33: note: expanded from macro
> > '__WAIT_QUEUE_HEAD_INIT_ONSTACK'
> > ({ init_waitqueue_head(&name); name; })
> > ^~~~
> > 1 error generated.
> >
> > Explicitly disable the warning like commit 46e2068081e9 ("drm/i915:
> > Disable some extra clang warnings").
> >
> > Link: https://github.com/ClangBuiltLinux/linux/issues/220
> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
>
> Reviewed-by: Nick Desaulniers <nick.desaulniers@gmail.com>
gah! I am on my work device, in that case it should be:
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
>
> probably could give Chris Wilson the suggested by tag.
> https://lore.kernel.org/lkml/154513398652.1108.7150969916024071452@skylake-alporthouse-com/
>
> > ---
> >
> > v1 -> v2:
> >
> > * Rather than disable the warning for the problematic folder, disable it
> > for the entire folder like Matthias's commit.
>
> Thanks for following up with a v2.
>
> --
> Thanks,
> ~Nick Desaulniers
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 14+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Disable -Wuninitialized
2019-01-26 7:11 ` Nathan Chancellor
` (3 preceding siblings ...)
(?)
@ 2019-01-26 7:50 ` Patchwork
-1 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2019-01-26 7:50 UTC (permalink / raw)
To: Nathan Chancellor; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Disable -Wuninitialized
URL : https://patchwork.freedesktop.org/series/55769/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5488 -> Patchwork_12051
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/55769/revisions/1/mbox/
Known issues
------------
Here are the changes found in Patchwork_12051 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
- fi-byt-clapper: PASS -> FAIL [fdo#107362]
* igt@prime_vgem@basic-fence-flip:
- fi-gdg-551: PASS -> FAIL [fdo#103182]
#### Possible fixes ####
* igt@kms_busy@basic-flip-a:
- fi-gdg-551: FAIL [fdo#103182] -> PASS
* igt@kms_chamelium@dp-edid-read:
- fi-kbl-7500u: WARN -> PASS
* igt@kms_pipe_crc_basic@read-crc-pipe-a:
- fi-byt-clapper: FAIL [fdo#107362] -> PASS
* igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS +1
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108915]: https://bugs.freedesktop.org/show_bug.cgi?id=108915
Participating hosts (44 -> 41)
------------------------------
Additional (1): fi-icl-y
Missing (4): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan
Build changes
-------------
* Linux: CI_DRM_5488 -> Patchwork_12051
CI_DRM_5488: f13eede6ea3e780d900c5220bf09d764a80a3a8f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4790: dcdf4b04e16312f8f52ad389388d834f9d74b8f0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12051: 5b4a07df5c73b2d846673614d4d508e6f378109c @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
5b4a07df5c73 drm/i915: Disable -Wuninitialized
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12051/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] drm/i915: Disable -Wuninitialized
2019-01-26 7:34 ` Nick Desaulniers
@ 2019-01-26 7:57 ` Nathan Chancellor
-1 siblings, 0 replies; 14+ messages in thread
From: Nathan Chancellor @ 2019-01-26 7:57 UTC (permalink / raw)
To: Nick Desaulniers; +Cc: intel-gfx, LKML, dri-devel, Matthias Kaehlcke
On Fri, Jan 25, 2019 at 11:34:19PM -0800, Nick Desaulniers wrote:
> On Fri, Jan 25, 2019 at 11:13 PM Nathan Chancellor
> <natechancellor@gmail.com> wrote:
> >
> > This warning is disabled by default in scripts/Makefile.extrawarn when
> > W= is not provided but this Makefile adds -Wall after this warning is
> > disabled so it shows up in the build when it shouldn't:
> >
> > In file included from drivers/gpu/drm/i915/intel_breadcrumbs.c:895:
> > drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c:350:34: error:
> > variable 'wq' is uninitialized when used within its own initialization
> > [-Werror,-Wuninitialized]
> > DECLARE_WAIT_QUEUE_HEAD_ONSTACK(wq);
> > ^~
> > ./include/linux/wait.h:74:63: note: expanded from macro
> > 'DECLARE_WAIT_QUEUE_HEAD_ONSTACK'
> > struct wait_queue_head name = __WAIT_QUEUE_HEAD_INIT_ONSTACK(name)
> > ~~~~ ^~~~
> > ./include/linux/wait.h:72:33: note: expanded from macro
> > '__WAIT_QUEUE_HEAD_INIT_ONSTACK'
> > ({ init_waitqueue_head(&name); name; })
> > ^~~~
> > 1 error generated.
> >
> > Explicitly disable the warning like commit 46e2068081e9 ("drm/i915:
> > Disable some extra clang warnings").
> >
> > Link: https://github.com/ClangBuiltLinux/linux/issues/220
> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
>
> Reviewed-by: Nick Desaulniers <nick.desaulniers@gmail.com>
>
> probably could give Chris Wilson the suggested by tag.
> https://lore.kernel.org/lkml/154513398652.1108.7150969916024071452@skylake-alporthouse-com/
>
Ugh you're right, completely slipped my mind.
Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> >
> > v1 -> v2:
> >
> > * Rather than disable the warning for the problematic folder, disable it
> > for the entire folder like Matthias's commit.
>
> Thanks for following up with a v2.
Thank you for the review!
Nathan
>
> --
> Thanks,
> ~Nick Desaulniers
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] drm/i915: Disable -Wuninitialized
@ 2019-01-26 7:57 ` Nathan Chancellor
0 siblings, 0 replies; 14+ messages in thread
From: Nathan Chancellor @ 2019-01-26 7:57 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, intel-gfx, dri-devel,
LKML, Chris Wilson, Matthias Kaehlcke
On Fri, Jan 25, 2019 at 11:34:19PM -0800, Nick Desaulniers wrote:
> On Fri, Jan 25, 2019 at 11:13 PM Nathan Chancellor
> <natechancellor@gmail.com> wrote:
> >
> > This warning is disabled by default in scripts/Makefile.extrawarn when
> > W= is not provided but this Makefile adds -Wall after this warning is
> > disabled so it shows up in the build when it shouldn't:
> >
> > In file included from drivers/gpu/drm/i915/intel_breadcrumbs.c:895:
> > drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c:350:34: error:
> > variable 'wq' is uninitialized when used within its own initialization
> > [-Werror,-Wuninitialized]
> > DECLARE_WAIT_QUEUE_HEAD_ONSTACK(wq);
> > ^~
> > ./include/linux/wait.h:74:63: note: expanded from macro
> > 'DECLARE_WAIT_QUEUE_HEAD_ONSTACK'
> > struct wait_queue_head name = __WAIT_QUEUE_HEAD_INIT_ONSTACK(name)
> > ~~~~ ^~~~
> > ./include/linux/wait.h:72:33: note: expanded from macro
> > '__WAIT_QUEUE_HEAD_INIT_ONSTACK'
> > ({ init_waitqueue_head(&name); name; })
> > ^~~~
> > 1 error generated.
> >
> > Explicitly disable the warning like commit 46e2068081e9 ("drm/i915:
> > Disable some extra clang warnings").
> >
> > Link: https://github.com/ClangBuiltLinux/linux/issues/220
> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
>
> Reviewed-by: Nick Desaulniers <nick.desaulniers@gmail.com>
>
> probably could give Chris Wilson the suggested by tag.
> https://lore.kernel.org/lkml/154513398652.1108.7150969916024071452@skylake-alporthouse-com/
>
Ugh you're right, completely slipped my mind.
Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> >
> > v1 -> v2:
> >
> > * Rather than disable the warning for the problematic folder, disable it
> > for the entire folder like Matthias's commit.
>
> Thanks for following up with a v2.
Thank you for the review!
Nathan
>
> --
> Thanks,
> ~Nick Desaulniers
^ permalink raw reply [flat|nested] 14+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Disable -Wuninitialized
2019-01-26 7:11 ` Nathan Chancellor
` (4 preceding siblings ...)
(?)
@ 2019-01-26 9:21 ` Patchwork
-1 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2019-01-26 9:21 UTC (permalink / raw)
To: Nathan Chancellor; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Disable -Wuninitialized
URL : https://patchwork.freedesktop.org/series/55769/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5488_full -> Patchwork_12051_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_12051_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@runner@aborted}:
- shard-kbl: ( 5 FAIL ) -> ( 4 FAIL )
Known issues
------------
Here are the changes found in Patchwork_12051_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@bcs0-s3:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
* igt@kms_cursor_crc@cursor-64x21-sliding:
- shard-apl: PASS -> FAIL [fdo#103232]
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166] +3
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-glk: PASS -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparant-fb:
- shard-kbl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
- shard-glk: PASS -> FAIL [fdo#103166]
#### Possible fixes ####
* igt@kms_color@pipe-c-degamma:
- shard-apl: FAIL [fdo#104782] -> PASS
* igt@kms_cursor_crc@cursor-64x21-onscreen:
- shard-glk: FAIL [fdo#103232] -> PASS
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-glk: FAIL [fdo#103166] -> PASS +2
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS +1
* igt@kms_setmode@basic:
- shard-kbl: FAIL [fdo#99912] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* Linux: CI_DRM_5488 -> Patchwork_12051
CI_DRM_5488: f13eede6ea3e780d900c5220bf09d764a80a3a8f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4790: dcdf4b04e16312f8f52ad389388d834f9d74b8f0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12051: 5b4a07df5c73b2d846673614d4d508e6f378109c @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12051/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] drm/i915: Disable -Wuninitialized
2019-01-26 7:57 ` Nathan Chancellor
(?)
@ 2019-01-26 17:09 ` Chris Wilson
-1 siblings, 0 replies; 14+ messages in thread
From: Chris Wilson @ 2019-01-26 17:09 UTC (permalink / raw)
To: Nathan Chancellor, Nick Desaulniers
Cc: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, intel-gfx, dri-devel,
LKML, Matthias Kaehlcke
Quoting Nathan Chancellor (2019-01-26 07:57:49)
> On Fri, Jan 25, 2019 at 11:34:19PM -0800, Nick Desaulniers wrote:
> > On Fri, Jan 25, 2019 at 11:13 PM Nathan Chancellor
> > <natechancellor@gmail.com> wrote:
> > >
> > > This warning is disabled by default in scripts/Makefile.extrawarn when
> > > W= is not provided but this Makefile adds -Wall after this warning is
> > > disabled so it shows up in the build when it shouldn't:
> > >
> > > In file included from drivers/gpu/drm/i915/intel_breadcrumbs.c:895:
> > > drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c:350:34: error:
> > > variable 'wq' is uninitialized when used within its own initialization
> > > [-Werror,-Wuninitialized]
> > > DECLARE_WAIT_QUEUE_HEAD_ONSTACK(wq);
> > > ^~
> > > ./include/linux/wait.h:74:63: note: expanded from macro
> > > 'DECLARE_WAIT_QUEUE_HEAD_ONSTACK'
> > > struct wait_queue_head name = __WAIT_QUEUE_HEAD_INIT_ONSTACK(name)
> > > ~~~~ ^~~~
> > > ./include/linux/wait.h:72:33: note: expanded from macro
> > > '__WAIT_QUEUE_HEAD_INIT_ONSTACK'
> > > ({ init_waitqueue_head(&name); name; })
> > > ^~~~
> > > 1 error generated.
> > >
> > > Explicitly disable the warning like commit 46e2068081e9 ("drm/i915:
> > > Disable some extra clang warnings").
> > >
> > > Link: https://github.com/ClangBuiltLinux/linux/issues/220
> > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> >
> > Reviewed-by: Nick Desaulniers <nick.desaulniers@gmail.com>
> >
> > probably could give Chris Wilson the suggested by tag.
> > https://lore.kernel.org/lkml/154513398652.1108.7150969916024071452@skylake-alporthouse-com/
> >
>
> Ugh you're right, completely slipped my mind.
>
> Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
Ignorance is bliss. Applied to dinq, thanks!
-Chris
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2019-01-26 17:09 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-26 7:11 [PATCH v2] drm/i915: Disable -Wuninitialized Nathan Chancellor
2019-01-26 7:11 ` Nathan Chancellor
2019-01-26 7:17 ` Nathan Chancellor
2019-01-26 7:17 ` Nathan Chancellor
2019-01-26 7:27 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2019-01-26 7:34 ` [PATCH v2] " Nick Desaulniers
2019-01-26 7:34 ` Nick Desaulniers
2019-01-26 7:35 ` Nick Desaulniers
2019-01-26 7:35 ` Nick Desaulniers
2019-01-26 7:57 ` Nathan Chancellor
2019-01-26 7:57 ` Nathan Chancellor
2019-01-26 17:09 ` Chris Wilson
2019-01-26 7:50 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-01-26 9:21 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.