All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: linux-crypto@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	herbert@gondor.apana.org.au
Subject: Re: [PATCH v2 0/4] crypto: fix crct10dif for ARM and arm64
Date: Sat, 26 Jan 2019 16:07:53 -0800	[thread overview]
Message-ID: <20190127000752.GC709@sol.localdomain> (raw)
In-Reply-To: <20190125084915.25411-1-ard.biesheuvel@linaro.org>

On Fri, Jan 25, 2019 at 09:49:11AM +0100, Ard Biesheuvel wrote:
> Fix the issues in both NEON implementations of the CRC-T10DIF routines,
> that were reported by Eric's new testing code.
> 
> v2:
> - keep alignment specifiers where possible (#1)
> - clarify/fix commit log (#2)
> - add fixes/cc-stable/etc tags
> - add patches that drop the now unreacheable code (#3 - #4)
> 
> Ard Biesheuvel (4):
>   crypto: arm/crct10dif - revert to C code for short inputs
>   crypto: arm64/crct10dif - revert to C code for short inputs
>   crypto: arm/crct10dif - remove dead code
>   crypto: arm64/crct10dif - remove dead code
> 
>  arch/arm/crypto/crct10dif-ce-core.S   | 27 +++++---------------
>  arch/arm/crypto/crct10dif-ce-glue.c   | 23 +++++------------
>  arch/arm64/crypto/crct10dif-ce-core.S | 11 --------
>  arch/arm64/crypto/crct10dif-ce-glue.c | 25 +++++-------------
>  4 files changed, 19 insertions(+), 67 deletions(-)
> 

In the commit message of patches 1-2, "more than 16 bytes" should be
"at least 16 bytes".

Otherwise for all 4 patches:

	Reviewed-by: Eric Biggers <ebiggers@kernel.org>

- Eric

WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: linux-crypto@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	herbert@gondor.apana.org.au
Subject: Re: [PATCH v2 0/4] crypto: fix crct10dif for ARM and arm64
Date: Sat, 26 Jan 2019 16:07:53 -0800	[thread overview]
Message-ID: <20190127000752.GC709@sol.localdomain> (raw)
In-Reply-To: <20190125084915.25411-1-ard.biesheuvel@linaro.org>

On Fri, Jan 25, 2019 at 09:49:11AM +0100, Ard Biesheuvel wrote:
> Fix the issues in both NEON implementations of the CRC-T10DIF routines,
> that were reported by Eric's new testing code.
> 
> v2:
> - keep alignment specifiers where possible (#1)
> - clarify/fix commit log (#2)
> - add fixes/cc-stable/etc tags
> - add patches that drop the now unreacheable code (#3 - #4)
> 
> Ard Biesheuvel (4):
>   crypto: arm/crct10dif - revert to C code for short inputs
>   crypto: arm64/crct10dif - revert to C code for short inputs
>   crypto: arm/crct10dif - remove dead code
>   crypto: arm64/crct10dif - remove dead code
> 
>  arch/arm/crypto/crct10dif-ce-core.S   | 27 +++++---------------
>  arch/arm/crypto/crct10dif-ce-glue.c   | 23 +++++------------
>  arch/arm64/crypto/crct10dif-ce-core.S | 11 --------
>  arch/arm64/crypto/crct10dif-ce-glue.c | 25 +++++-------------
>  4 files changed, 19 insertions(+), 67 deletions(-)
> 

In the commit message of patches 1-2, "more than 16 bytes" should be
"at least 16 bytes".

Otherwise for all 4 patches:

	Reviewed-by: Eric Biggers <ebiggers@kernel.org>

- Eric

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-01-27  0:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-25  8:49 [PATCH v2 0/4] crypto: fix crct10dif for ARM and arm64 Ard Biesheuvel
2019-01-25  8:49 ` Ard Biesheuvel
2019-01-25  8:49 ` [PATCH v2 1/4] crypto: arm/crct10dif - revert to C code for short inputs Ard Biesheuvel
2019-01-25  8:49   ` Ard Biesheuvel
2019-01-25  8:49 ` [PATCH v2 2/4] crypto: arm64/crct10dif " Ard Biesheuvel
2019-01-25  8:49   ` Ard Biesheuvel
2019-01-25  8:49 ` [PATCH v2 3/4] crypto: arm/crct10dif - remove dead code Ard Biesheuvel
2019-01-25  8:49   ` Ard Biesheuvel
2019-01-25  8:49 ` [PATCH v2 4/4] crypto: arm64/crct10dif " Ard Biesheuvel
2019-01-25  8:49   ` Ard Biesheuvel
2019-01-27  0:07 ` Eric Biggers [this message]
2019-01-27  0:07   ` [PATCH v2 0/4] crypto: fix crct10dif for ARM and arm64 Eric Biggers
2019-01-27  9:10   ` Ard Biesheuvel
2019-01-27  9:10     ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190127000752.GC709@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.