All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Carlo Caione <ccaione@baylibre.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	s.hauer@pengutronix.de, robh+dt@kernel.org, linux-imx@nxp.com,
	kernel@pengutronix.de, fabio.estevam@nxp.com,
	shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] arm64: dts: imx8mq-evk: add missing MDIO / PHY nodes
Date: Mon, 28 Jan 2019 18:58:44 +0100	[thread overview]
Message-ID: <20190128175844.GF28759@lunn.ch> (raw)
In-Reply-To: <20190128095212.14681-2-ccaione@baylibre.com>

On Mon, Jan 28, 2019 at 09:52:11AM +0000, Carlo Caione wrote:
> Populate the fec1 node with the missing MDIO and PHY entries.
> 
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> index 64acccc4bfcb..2641f777d0bb 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> @@ -37,7 +37,18 @@
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_fec1>;
>  	phy-mode = "rgmii-id";
> +	phy-handle = <&ethphy0>;
>  	status = "okay";
> +
> +	mdio {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		ethphy0: ethernet-phy@0 {
> +			compatible = "ethernet-phy-ieee802.3-c22";

Hi Carlo

This compatible string is optional. But having it does not harm
anything.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Carlo Caione <ccaione@baylibre.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	s.hauer@pengutronix.de, robh+dt@kernel.org, linux-imx@nxp.com,
	kernel@pengutronix.de, fabio.estevam@nxp.com,
	shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] arm64: dts: imx8mq-evk: add missing MDIO / PHY nodes
Date: Mon, 28 Jan 2019 18:58:44 +0100	[thread overview]
Message-ID: <20190128175844.GF28759@lunn.ch> (raw)
In-Reply-To: <20190128095212.14681-2-ccaione@baylibre.com>

On Mon, Jan 28, 2019 at 09:52:11AM +0000, Carlo Caione wrote:
> Populate the fec1 node with the missing MDIO and PHY entries.
> 
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> index 64acccc4bfcb..2641f777d0bb 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> @@ -37,7 +37,18 @@
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_fec1>;
>  	phy-mode = "rgmii-id";
> +	phy-handle = <&ethphy0>;
>  	status = "okay";
> +
> +	mdio {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		ethphy0: ethernet-phy@0 {
> +			compatible = "ethernet-phy-ieee802.3-c22";

Hi Carlo

This compatible string is optional. But having it does not harm
anything.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

  parent reply	other threads:[~2019-01-28 17:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-28  9:52 [PATCH v2 0/2] Add MDIO and PHY notes Carlo Caione
2019-01-28  9:52 ` Carlo Caione
2019-01-28  9:52 ` [PATCH v2 1/2] arm64: dts: imx8mq-evk: add missing MDIO / PHY nodes Carlo Caione
2019-01-28  9:52   ` Carlo Caione
2019-01-28 12:11   ` Fabio Estevam
2019-01-28 12:11     ` Fabio Estevam
2019-01-28 17:58   ` Andrew Lunn [this message]
2019-01-28 17:58     ` Andrew Lunn
2019-01-28  9:52 ` [PATCH v2 2/2] arm64: dts: imx8mq-evk: Add fsl,magic-packet property Carlo Caione
2019-01-28  9:52   ` Carlo Caione
2019-01-28 12:11   ` [PATCH v2 2/2] arm64: dts: imx8mq-evk: Add fsl, magic-packet property Fabio Estevam
2019-01-28 12:11     ` Fabio Estevam
2019-02-01 10:49     ` [PATCH v2 2/2] arm64: dts: imx8mq-evk: Add fsl,magic-packet property Shawn Guo
2019-02-01 10:49       ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190128175844.GF28759@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=ccaione@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.