From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chao Yu <chao@kernel.org>
Cc: Gao Xiang <gaoxiang25@huawei.com>, Chao Yu <yuchao0@huawei.com>,
devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Miao Xie <miaoxie@huawei.com>,
LKML <linux-kernel@vger.kernel.org>,
weidu.du@huawei.com, Fang Wei <fangwei1@huawei.com>,
linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH v2 2/2] staging: erofs: complete POSIX ACL support
Date: Mon, 28 Jan 2019 21:30:53 +0300 [thread overview]
Message-ID: <20190128183053.GK1795@kadam> (raw)
In-Reply-To: <1eed1e6b-f95e-aa8e-c3e7-e9870401ee23@kernel.org>
On Tue, Jan 29, 2019 at 12:41:55AM +0800, Chao Yu wrote:
> Hi Dan and Xiang,
>
> On 2019-1-28 21:48, Gao Xiang wrote:
> > Hi Dan,
> >
> > On 2019/1/28 21:33, Dan Carpenter wrote:
> >> Hopefully, regular kmalloc() is enough.
> >>
> >> Do really need the erofs_kmalloc() function? Regular kmalloc() has
> >> fault injection already. Have you tried to use it?
>
> Yes, I think we'd better to use erofs_kmalloc(). :)
>
> Actually, fault injection in erofs_kmalloc only affect erofs module, we can
> expect that the range of fault can be limited in erofs code, rather than whole
> kernel, so the test point can be aimed at more accurately.
>
Are you serious? The standard fault injection doesn't do that???
Please fix it instead of creating a duplicate better implementation
which only your filesystem can use. I would have thought that obviously
any fault injection framework could at least be configured to test
specific code...
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: dan.carpenter@oracle.com (Dan Carpenter)
Subject: [PATCH v2 2/2] staging: erofs: complete POSIX ACL support
Date: Mon, 28 Jan 2019 21:30:53 +0300 [thread overview]
Message-ID: <20190128183053.GK1795@kadam> (raw)
In-Reply-To: <1eed1e6b-f95e-aa8e-c3e7-e9870401ee23@kernel.org>
On Tue, Jan 29, 2019@12:41:55AM +0800, Chao Yu wrote:
> Hi Dan and Xiang,
>
> On 2019-1-28 21:48, Gao Xiang wrote:
> > Hi Dan,
> >
> > On 2019/1/28 21:33, Dan Carpenter wrote:
> >> Hopefully, regular kmalloc() is enough.
> >>
> >> Do really need the erofs_kmalloc() function? Regular kmalloc() has
> >> fault injection already. Have you tried to use it?
>
> Yes, I think we'd better to use erofs_kmalloc(). :)
>
> Actually, fault injection in erofs_kmalloc only affect erofs module, we can
> expect that the range of fault can be limited in erofs code, rather than whole
> kernel, so the test point can be aimed at more accurately.
>
Are you serious? The standard fault injection doesn't do that???
Please fix it instead of creating a duplicate better implementation
which only your filesystem can use. I would have thought that obviously
any fault injection framework could at least be configured to test
specific code...
regards,
dan carpenter
next prev parent reply other threads:[~2019-01-28 18:31 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 16:10 [PATCH v2 1/2] staging: erofs: use xattr_prefix to wrap up Gao Xiang
2019-01-25 16:10 ` Gao Xiang
2019-01-25 16:10 ` [PATCH v2 2/2] staging: erofs: complete POSIX ACL support Gao Xiang
2019-01-25 16:10 ` Gao Xiang
2019-01-26 2:48 ` Chao Yu
2019-01-26 2:48 ` Chao Yu
2019-01-26 3:06 ` Gao Xiang
2019-01-26 3:06 ` Gao Xiang
2019-01-28 13:33 ` Dan Carpenter
2019-01-28 13:33 ` Dan Carpenter
2019-01-28 13:48 ` Gao Xiang
2019-01-28 13:48 ` Gao Xiang
2019-01-28 14:28 ` Dan Carpenter
2019-01-28 14:28 ` Dan Carpenter
2019-01-28 15:04 ` Gao Xiang
2019-01-28 15:04 ` Gao Xiang
2019-01-28 16:41 ` Chao Yu
2019-01-28 16:41 ` Chao Yu
2019-01-28 18:30 ` Dan Carpenter [this message]
2019-01-28 18:30 ` Dan Carpenter
2019-01-29 8:03 ` Gao Xiang
2019-01-29 8:03 ` Gao Xiang
2019-02-03 2:52 ` Chao Yu
2019-02-03 2:52 ` Chao Yu
2019-02-15 2:10 ` Chao Yu
2019-02-15 2:10 ` Chao Yu
2019-02-15 7:36 ` Dan Carpenter
2019-02-15 7:36 ` Dan Carpenter
2019-02-15 9:31 ` Chao Yu
2019-02-15 9:31 ` Chao Yu
2019-01-26 2:08 ` [PATCH v2 1/2] staging: erofs: use xattr_prefix to wrap up Chao Yu
2019-01-26 2:08 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190128183053.GK1795@kadam \
--to=dan.carpenter@oracle.com \
--cc=chao@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=fangwei1@huawei.com \
--cc=gaoxiang25@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=weidu.du@huawei.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.