From: Greg KH <greg@kroah.com>
To: Niklas Cassel <niklas.cassel@linaro.org>
Cc: davem@davemloft.net, stable@vger.kernel.org,
netdev@vger.kernel.org, vinod.koul@linaro.org
Subject: Re: Request for stable backport: stmmac: Use correct values in TQS/RQS fields
Date: Tue, 29 Jan 2019 10:41:12 +0100 [thread overview]
Message-ID: <20190129094112.GA20645@kroah.com> (raw)
In-Reply-To: <20190129090955.GA16354@centauri.lan>
On Tue, Jan 29, 2019 at 10:09:55AM +0100, Niklas Cassel wrote:
> Adding stable since I see Greg's Sign-off-by on recent backports
> to this driver.
>
>
> On Wed, Dec 19, 2018 at 10:55:16AM +0100, Niklas Cassel wrote:
> > Hello David,
> >
> > I can observe a netdev watchdog timeout on kernel 4.14.78 when using stmmac
> > with multiple tx queues.
> >
> > Backporting the following commit:
> >
> > commit 52a76235d0c4dd259cd0df503afed4757c04ba1d
> > Author: Jose Abreu <Jose.Abreu@synopsys.com>
> > Date: Fri Oct 13 10:58:36 2017 +0100
> >
> > net: stmmac: Use correct values in TQS/RQS fields
> >
> > Currently we are using all the available fifo size in RQS and
> > TQS fields. This will not work correctly in multi-queues IP's
> > because total fifo size must be splitted to the enabled queues.
> >
> > Correct this by computing the available fifo size per queue and
> > setting the right value in TQS and RQS fields.
> >
> > Signed-off-by: Jose Abreu <joabreu@synopsys.com>
> > Cc: David S. Miller <davem@davemloft.net>
> > Cc: Joao Pinto <jpinto@synopsys.com>
> > Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> > Cc: Alexandre Torgue <alexandre.torgue@st.com>
> > Signed-off-by: David S. Miller <davem@davemloft.net>
> >
> >
> > resolves the issue.
> >
> > The fix was first included in v4.15
> > $ git tag --contains 52a76235d0c4dd259cd0df503afed4757c04ba1d
> > v4.15
> > v4.15-rc1
> > v4.15-rc2
> >
> > Could you please queue it up for 4.14 stable?
Netdev doesn't care about 4.14 anymore, so I'll just take it, thanks.
greg k-h
prev parent reply other threads:[~2019-01-29 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 9:55 Request for stable backport: stmmac: Use correct values in TQS/RQS fields Niklas Cassel
2019-01-29 9:09 ` Niklas Cassel
2019-01-29 9:41 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129094112.GA20645@kroah.com \
--to=greg@kroah.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
--cc=stable@vger.kernel.org \
--cc=vinod.koul@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.