All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: dzickus@redhat.com, Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
	maddy@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org,
	fowles@inreach.com, linux-kernel@vger.kernel.org,
	jmario@redhat.com, namhyung@kernel.org, jolsa@redhat.com
Subject: Re: [PATCH] perf mem/c2c: Fix perf_mem_events to support powerpc
Date: Tue, 29 Jan 2019 10:53:15 +0100	[thread overview]
Message-ID: <20190129095315.GH4344@kernel.org> (raw)
In-Reply-To: <874l9rsson.fsf@concordia.ellerman.id.au>

Em Tue, Jan 29, 2019 at 08:45:44PM +1100, Michael Ellerman escreveu:
> Ravi Bangoria <ravi.bangoria@linux.ibm.com> writes:
> 
> > On 1/14/19 9:44 AM, Ravi Bangoria wrote:
> >> Powerpc hw does not have inbuilt latency filter (--ldlat) for mem-load
> >> event and, perf_mem_events by default includes ldlat=30 which is
> >> causing failure on powerpc. Refactor code to support perf mem/c2c on
> >> powerpc.
> >> 
> >> This patch depends on kernel side changes done my Madhavan:
> >> https://lists.ozlabs.org/pipermail/linuxppc-dev/2018-December/182596.html
> >> 
> >> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
> >
> >
> > Arnaldo / Michael, Any thoughts?
> 
> I haven't merged the kernel patch, I think because Maddy told me not to
> because it would break the userspace tooling :)
> 
> What is the actual dependency between them? ie. should we merge the
> kernel fix first or second or what?

I think its just a tooling side, I haven't processed it because I'm
waiting for Ravi to address Jiri's comment, after that I'm happy to put
it in my perf/urgent branch that I'm brewing to push to Ingo today or
tomorrow.

- Arnaldo

WARNING: multiple messages have this Message-ID (diff)
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
	jolsa@redhat.com, namhyung@kernel.org, dzickus@redhat.com,
	fowles@inreach.com, jmario@redhat.com,
	linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	maddy@linux.vnet.ibm.com
Subject: Re: [PATCH] perf mem/c2c: Fix perf_mem_events to support powerpc
Date: Tue, 29 Jan 2019 10:53:15 +0100	[thread overview]
Message-ID: <20190129095315.GH4344@kernel.org> (raw)
In-Reply-To: <874l9rsson.fsf@concordia.ellerman.id.au>

Em Tue, Jan 29, 2019 at 08:45:44PM +1100, Michael Ellerman escreveu:
> Ravi Bangoria <ravi.bangoria@linux.ibm.com> writes:
> 
> > On 1/14/19 9:44 AM, Ravi Bangoria wrote:
> >> Powerpc hw does not have inbuilt latency filter (--ldlat) for mem-load
> >> event and, perf_mem_events by default includes ldlat=30 which is
> >> causing failure on powerpc. Refactor code to support perf mem/c2c on
> >> powerpc.
> >> 
> >> This patch depends on kernel side changes done my Madhavan:
> >> https://lists.ozlabs.org/pipermail/linuxppc-dev/2018-December/182596.html
> >> 
> >> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
> >
> >
> > Arnaldo / Michael, Any thoughts?
> 
> I haven't merged the kernel patch, I think because Maddy told me not to
> because it would break the userspace tooling :)
> 
> What is the actual dependency between them? ie. should we merge the
> kernel fix first or second or what?

I think its just a tooling side, I haven't processed it because I'm
waiting for Ravi to address Jiri's comment, after that I'm happy to put
it in my perf/urgent branch that I'm brewing to push to Ingo today or
tomorrow.

- Arnaldo

  reply	other threads:[~2019-01-29  9:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14  4:14 [PATCH] perf mem/c2c: Fix perf_mem_events to support powerpc Ravi Bangoria
2019-01-14  4:14 ` Ravi Bangoria
2019-01-28 10:08 ` Ravi Bangoria
2019-01-28 10:08   ` Ravi Bangoria
2019-01-29  9:45   ` Michael Ellerman
2019-01-29  9:45     ` Michael Ellerman
2019-01-29  9:53     ` Arnaldo Carvalho de Melo [this message]
2019-01-29  9:53       ` Arnaldo Carvalho de Melo
2019-01-29 10:40       ` Ravi Bangoria
2019-01-29 10:40         ` Ravi Bangoria
2019-01-29 13:24         ` [PATCH v2] " Ravi Bangoria
2019-01-29 13:24           ` Ravi Bangoria
2019-01-29 13:42           ` Jiri Olsa
2019-01-29 13:42             ` Jiri Olsa
2019-01-29 14:17             ` Arnaldo Carvalho de Melo
2019-01-29 14:17               ` Arnaldo Carvalho de Melo
2019-02-09 12:20           ` [tip:perf/urgent] " tip-bot for Ravi Bangoria
2019-01-28 11:07 ` [PATCH] " Jiri Olsa
2019-01-28 11:07   ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190129095315.GH4344@kernel.org \
    --to=acme@kernel.org \
    --cc=dzickus@redhat.com \
    --cc=fowles@inreach.com \
    --cc=jmario@redhat.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.vnet.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=namhyung@kernel.org \
    --cc=ravi.bangoria@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.