From: Anatolij Gustschin <agust@denx.de>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
trini@konsulko.com, linux-amlogic@lists.infradead.org
Subject: Re: [U-Boot] [PULL u-boot] Please pull u-boot-amlogic-20190128
Date: Tue, 29 Jan 2019 11:14:41 +0100 [thread overview]
Message-ID: <20190129111441.23a51645@crub> (raw)
In-Reply-To: <e2aa97d7-bd82-ba11-c881-5eb6861a12cc@baylibre.com>
Hi Neil,
On Mon, 28 Jan 2019 14:09:13 +0100
Neil Armstrong narmstrong@baylibre.com wrote:
...
> ----------------------------------------------------------------
> Adds pinconf support for the Amlogic pinctrl driver
>
> ----------------------------------------------------------------
> Jerome Brunet (1):
> pinctrl: meson: add pinconf support
>
> drivers/pinctrl/meson/Kconfig | 1 +
> drivers/pinctrl/meson/pinctrl-meson-axg-pmx.c | 10 +++
This change breaks building, please see error log here [1].
I think, a comma is missing after
.pinconf_params = meson_axg_pinconf_params
Please fix.
[1] https://travis-ci.org/trini/u-boot/jobs/485695412#L1033
--
Anatolij
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PULL u-boot] Please pull u-boot-amlogic-20190128
Date: Tue, 29 Jan 2019 11:14:41 +0100 [thread overview]
Message-ID: <20190129111441.23a51645@crub> (raw)
In-Reply-To: <e2aa97d7-bd82-ba11-c881-5eb6861a12cc@baylibre.com>
Hi Neil,
On Mon, 28 Jan 2019 14:09:13 +0100
Neil Armstrong narmstrong at baylibre.com wrote:
...
> ----------------------------------------------------------------
> Adds pinconf support for the Amlogic pinctrl driver
>
> ----------------------------------------------------------------
> Jerome Brunet (1):
> pinctrl: meson: add pinconf support
>
> drivers/pinctrl/meson/Kconfig | 1 +
> drivers/pinctrl/meson/pinctrl-meson-axg-pmx.c | 10 +++
This change breaks building, please see error log here [1].
I think, a comma is missing after
.pinconf_params = meson_axg_pinconf_params
Please fix.
[1] https://travis-ci.org/trini/u-boot/jobs/485695412#L1033
--
Anatolij
next prev parent reply other threads:[~2019-01-29 10:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 13:09 [PULL u-boot] Please pull u-boot-amlogic-20190128 Neil Armstrong
2019-01-28 13:09 ` [U-Boot] " Neil Armstrong
2019-01-29 10:14 ` Anatolij Gustschin [this message]
2019-01-29 10:14 ` Anatolij Gustschin
2019-01-29 10:18 ` Neil Armstrong
2019-01-29 10:18 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129111441.23a51645@crub \
--to=agust@denx.de \
--cc=linux-amlogic@lists.infradead.org \
--cc=narmstrong@baylibre.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.