From: Vinod Koul <vkoul@kernel.org>
To: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Cc: sboyd@kernel.org, bjorn.andersson@linaro.org,
andy.gross@linaro.org, david.brown@linaro.org,
jassisinghbrar@gmail.com, mark.rutland@arm.com,
mturquette@baylibre.com, robh+dt@kernel.org, will.deacon@arm.com,
arnd@arndb.de, horms+renesas@verge.net.au, heiko@sntech.de,
sibis@codeaurora.org, enric.balletbo@collabora.com,
jagan@amarulasolutions.com, olof@lixom.net,
niklas.cassel@linaro.org, georgi.djakov@linaro.org,
amit.kucheria@linaro.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-arm-msm@vger.kernel.org, khasim.mohammed@linaro.org
Subject: Re: [PATCH v2 10/14] arm64: dts: qcom: qcs404: Add OPP table
Date: Wed, 30 Jan 2019 10:11:12 +0530 [thread overview]
Message-ID: <20190130044112.GE4635@vkoul-mobl> (raw)
In-Reply-To: <1548700381-22376-11-git-send-email-jorge.ramirez-ortiz@linaro.org>
On 28-01-19, 19:32, Jorge Ramirez-Ortiz wrote:
> Add a CPU OPP table to qcs404
>
> Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/qcs404.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> index 9b5c165..4594fea7 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> @@ -62,6 +62,21 @@
> };
> };
>
> + cpu_opp_table: cpu_opp_table {
This should be:
cpu_opp_table: cpu-opp-table
IIRC node names are not supposed to have _ and tags not supposed to have
-, please compile with W=12 to trigger these warnings :)
> + compatible = "operating-points-v2";
> + opp-shared;
> +
> + opp-1094400000 {
> + opp-hz = /bits/ 64 <1094400000>;
> + };
> + opp-1248000000 {
> + opp-hz = /bits/ 64 <1248000000>;
> + };
> + opp-1401600000 {
> + opp-hz = /bits/ 64 <1401600000>;
> + };
> + };
> +
> firmware {
> scm: scm {
> compatible = "qcom,scm-qcs404", "qcom,scm";
> --
> 2.7.4
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Cc: mark.rutland@arm.com, heiko@sntech.de, mturquette@baylibre.com,
will.deacon@arm.com, bjorn.andersson@linaro.org,
david.brown@linaro.org, linux-clk@vger.kernel.org,
jassisinghbrar@gmail.com, sibis@codeaurora.org,
andy.gross@linaro.org, jagan@amarulasolutions.com,
devicetree@vger.kernel.org, niklas.cassel@linaro.org,
arnd@arndb.de, linux-arm-msm@vger.kernel.org, olof@lixom.net,
robh+dt@kernel.org, horms+renesas@verge.net.au,
linux-arm-kernel@lists.infradead.org, sboyd@kernel.org,
linux-kernel@vger.kernel.org, amit.kucheria@linaro.org,
khasim.mohammed@linaro.org, enric.balletbo@collabora.com,
georgi.djakov@linaro.org
Subject: Re: [PATCH v2 10/14] arm64: dts: qcom: qcs404: Add OPP table
Date: Wed, 30 Jan 2019 10:11:12 +0530 [thread overview]
Message-ID: <20190130044112.GE4635@vkoul-mobl> (raw)
In-Reply-To: <1548700381-22376-11-git-send-email-jorge.ramirez-ortiz@linaro.org>
On 28-01-19, 19:32, Jorge Ramirez-Ortiz wrote:
> Add a CPU OPP table to qcs404
>
> Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/qcs404.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> index 9b5c165..4594fea7 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> @@ -62,6 +62,21 @@
> };
> };
>
> + cpu_opp_table: cpu_opp_table {
This should be:
cpu_opp_table: cpu-opp-table
IIRC node names are not supposed to have _ and tags not supposed to have
-, please compile with W=12 to trigger these warnings :)
> + compatible = "operating-points-v2";
> + opp-shared;
> +
> + opp-1094400000 {
> + opp-hz = /bits/ 64 <1094400000>;
> + };
> + opp-1248000000 {
> + opp-hz = /bits/ 64 <1248000000>;
> + };
> + opp-1401600000 {
> + opp-hz = /bits/ 64 <1401600000>;
> + };
> + };
> +
> firmware {
> scm: scm {
> compatible = "qcom,scm-qcs404", "qcom,scm";
> --
> 2.7.4
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-30 4:41 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 18:32 [PATCH v2 00/14] Support CPU frequency scaling on QCS404 Jorge Ramirez-Ortiz
2019-01-28 18:32 ` Jorge Ramirez-Ortiz
2019-01-28 18:32 ` [PATCH v2 01/14] clk: qcom: gcc: limit GPLL0_AO_OUT operating frequency Jorge Ramirez-Ortiz
2019-01-28 18:32 ` Jorge Ramirez-Ortiz
2019-02-22 18:07 ` Stephen Boyd
2019-02-22 18:07 ` Stephen Boyd
2019-01-28 18:32 ` [PATCH v2 02/14] mbox: qcom: add APCS child device for QCS404 Jorge Ramirez-Ortiz
2019-01-28 18:32 ` Jorge Ramirez-Ortiz
2019-01-28 18:32 ` Jorge Ramirez-Ortiz
2019-02-22 18:09 ` Stephen Boyd
2019-02-22 18:09 ` Stephen Boyd
2019-01-28 18:32 ` [PATCH v2 03/14] mbox: qcom: replace integer with valid macro Jorge Ramirez-Ortiz
2019-01-28 18:32 ` Jorge Ramirez-Ortiz
2019-01-28 18:32 ` [PATCH v2 04/14] dt-bindings: mailbox: qcom: Add clock-name optional property Jorge Ramirez-Ortiz
2019-01-28 18:32 ` Jorge Ramirez-Ortiz
2019-01-30 15:50 ` Rob Herring
2019-01-30 15:50 ` Rob Herring
2019-01-30 15:50 ` Rob Herring
2019-01-28 18:32 ` [PATCH v2 05/14] clk: qcom: apcs-msm8916: get parent clock names from DT Jorge Ramirez-Ortiz
2019-01-28 18:32 ` Jorge Ramirez-Ortiz
2019-02-22 18:11 ` Stephen Boyd
2019-02-22 18:11 ` Stephen Boyd
2019-04-22 11:44 ` Jorge Ramirez
2019-04-22 11:44 ` Jorge Ramirez
2019-04-25 21:29 ` Stephen Boyd
2019-04-25 21:29 ` Stephen Boyd
2019-04-25 21:42 ` Jorge Ramirez
2019-04-25 21:42 ` Jorge Ramirez
2019-01-28 18:32 ` [PATCH v2 06/14] clk: qcom: hfpll: " Jorge Ramirez-Ortiz
2019-01-28 18:32 ` Jorge Ramirez-Ortiz
2019-01-28 18:32 ` [PATCH v2 07/14] clk: qcom: hfpll: register as clock provider Jorge Ramirez-Ortiz
2019-01-28 18:32 ` Jorge Ramirez-Ortiz
2019-02-22 18:06 ` Stephen Boyd
2019-02-22 18:06 ` Stephen Boyd
2019-01-28 18:32 ` [PATCH v2 08/14] clk: qcom: hfpll: CLK_IGNORE_UNUSED Jorge Ramirez-Ortiz
2019-01-28 18:32 ` Jorge Ramirez-Ortiz
2019-02-22 18:12 ` Stephen Boyd
2019-02-22 18:12 ` Stephen Boyd
2019-01-28 18:32 ` [PATCH v2 09/14] arm64: dts: qcom: msm8916: Add the clocks for the APCS mux/divider Jorge Ramirez-Ortiz
2019-01-28 18:32 ` Jorge Ramirez-Ortiz
2019-01-28 18:32 ` [PATCH v2 10/14] arm64: dts: qcom: qcs404: Add OPP table Jorge Ramirez-Ortiz
2019-01-28 18:32 ` Jorge Ramirez-Ortiz
2019-01-30 4:41 ` Vinod Koul [this message]
2019-01-30 4:41 ` Vinod Koul
2019-01-30 9:08 ` Jorge Ramirez
2019-01-30 9:08 ` Jorge Ramirez
2019-01-28 18:32 ` [PATCH v2 11/14] arm64: dts: qcom: qcs404: Add HFPLL node Jorge Ramirez-Ortiz
2019-01-28 18:32 ` Jorge Ramirez-Ortiz
2019-01-28 18:32 ` [PATCH v2 12/14] arm64: dts: qcom: qcs404: Add the clocks for APCS mux/divider Jorge Ramirez-Ortiz
2019-01-28 18:32 ` Jorge Ramirez-Ortiz
2019-01-28 18:33 ` [PATCH v2 13/14] arm64: dts: qcom: qcs404: Add cpufreq support Jorge Ramirez-Ortiz
2019-01-28 18:33 ` Jorge Ramirez-Ortiz
2019-01-28 18:33 ` [PATCH v2 14/14] arm64: defconfig: Enable HFPLL Jorge Ramirez-Ortiz
2019-01-28 18:33 ` Jorge Ramirez-Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130044112.GE4635@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=andy.gross@linaro.org \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=georgi.djakov@linaro.org \
--cc=heiko@sntech.de \
--cc=horms+renesas@verge.net.au \
--cc=jagan@amarulasolutions.com \
--cc=jassisinghbrar@gmail.com \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=khasim.mohammed@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=niklas.cassel@linaro.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sibis@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.