From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Carlos Henrique Lima Melara <charlesmelara@outlook.com>
Cc: "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"neil@brown.name" <neil@brown.name>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier
Date: Wed, 30 Jan 2019 16:29:56 +0100 [thread overview]
Message-ID: <20190130152956.GA4195@kroah.com> (raw)
In-Reply-To: <SC1P15201MB2014C3E0CAB4DA9ADF330797A8900@SC1P15201MB2014.LAMP152.PROD.OUTLOOK.COM>
On Wed, Jan 30, 2019 at 02:48:27PM +0000, Carlos Henrique Lima Melara wrote:
> This patch fix the checkpatch.p1 warning:
>
> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> +/*
Why did you not fix up the indentation that was already mentioned?
> It includes the SPDX expression for GPL-2.0 and corrects the comment format to suit the kernel's coding style.
Always properly line-wrap your comments.
>
> Signed-off-by: Carlos (Charles) Henrique Lima Melara <charlesmelara@outlook.com>
This needs to match your "From:" line.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Carlos Henrique Lima Melara <charlesmelara@outlook.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"neil@brown.name" <neil@brown.name>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier
Date: Wed, 30 Jan 2019 16:29:56 +0100 [thread overview]
Message-ID: <20190130152956.GA4195@kroah.com> (raw)
In-Reply-To: <SC1P15201MB2014C3E0CAB4DA9ADF330797A8900@SC1P15201MB2014.LAMP152.PROD.OUTLOOK.COM>
On Wed, Jan 30, 2019 at 02:48:27PM +0000, Carlos Henrique Lima Melara wrote:
> This patch fix the checkpatch.p1 warning:
>
> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> +/*
Why did you not fix up the indentation that was already mentioned?
> It includes the SPDX expression for GPL-2.0 and corrects the comment format to suit the kernel's coding style.
Always properly line-wrap your comments.
>
> Signed-off-by: Carlos (Charles) Henrique Lima Melara <charlesmelara@outlook.com>
This needs to match your "From:" line.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-30 15:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 14:48 [PATCH v2] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier Carlos Henrique Lima Melara
2019-01-30 14:48 ` Carlos Henrique Lima Melara
2019-01-30 15:29 ` gregkh [this message]
2019-01-30 15:29 ` gregkh
2019-01-30 20:01 ` Carlos Henrique Lima Melara
2019-01-30 20:01 ` Carlos Henrique Lima Melara
2019-01-30 21:12 ` gregkh
2019-01-30 21:12 ` gregkh
2019-01-30 16:38 ` Andrew Lunn
2019-01-30 16:38 ` Andrew Lunn
2019-01-30 18:10 ` gregkh
2019-01-30 18:10 ` gregkh
2019-01-30 18:48 ` Andrew Lunn
2019-01-30 18:48 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130152956.GA4195@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=charlesmelara@outlook.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=neil@brown.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.