From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Kyle Tso <kyletso@google.com>,
linux@roeck-us.net, badhri@google.com,
Adam.Thomson.Opensource@diasemi.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: usb: typec: tcpm: Correct the PPS out_volt calculation
Date: Thu, 31 Jan 2019 10:46:05 +0200 [thread overview]
Message-ID: <20190131084605.GN7262@kuha.fi.intel.com> (raw)
On Thu, Jan 31, 2019 at 09:01:00AM +0100, Greg KH wrote:
> On Thu, Jan 31, 2019 at 09:31:25AM +0200, Heikki Krogerus wrote:
> > On Wed, Jan 30, 2019 at 11:13:53AM +0800, Kyle Tso wrote:
> > > When Sink negotiates PPS, the voltage range of selected PPS APDO might
> > > not cover the previous voltage (out_volt). If the previous out_volt is
> > > lower than the new min_volt, the output voltage in RDO might be set to
> > > an invalid value. For instance, supposed that the previous voltage is
> > > 5V, and the new voltage range in the APDO is 7V-12V. Then the output
> > > voltage in the RDO should not be set to 5V which is lower than the
> > > possible min_volt 7V.
> > >
> > > Fix this by choosing the maximal value between the previous voltage and
> > > the new min_volt first. And ensure that this value will not exceed the
> > > new max_volt. The new out_volt will fall within the new voltage range
> > > while being the closest value compared to the previous out_volt.
> > >
> > > Signed-off-by: Kyle Tso <kyletso@google.com>
> >
> > Fixes: c710d0bb76ff0 ("usb: typec: tcpm: Extend the matching rules on PPS APDO selection")
> > Cc: stable...
>
> No need for stable, as c710d0bb76ff ("usb: typec: tcpm: Extend the
> matching rules on PPS APDO selection") only showed up in 5.0-rc1.
>
> Note, no need for the extra digit on your sha1 listing, here's the
> recommended way to show this:
> git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"
OK. Thanks for the hint!
Cheers,
WARNING: multiple messages have this Message-ID (diff)
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Kyle Tso <kyletso@google.com>,
linux@roeck-us.net, badhri@google.com,
Adam.Thomson.Opensource@diasemi.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: tcpm: Correct the PPS out_volt calculation
Date: Thu, 31 Jan 2019 10:46:05 +0200 [thread overview]
Message-ID: <20190131084605.GN7262@kuha.fi.intel.com> (raw)
In-Reply-To: <20190131080100.GA16000@kroah.com>
On Thu, Jan 31, 2019 at 09:01:00AM +0100, Greg KH wrote:
> On Thu, Jan 31, 2019 at 09:31:25AM +0200, Heikki Krogerus wrote:
> > On Wed, Jan 30, 2019 at 11:13:53AM +0800, Kyle Tso wrote:
> > > When Sink negotiates PPS, the voltage range of selected PPS APDO might
> > > not cover the previous voltage (out_volt). If the previous out_volt is
> > > lower than the new min_volt, the output voltage in RDO might be set to
> > > an invalid value. For instance, supposed that the previous voltage is
> > > 5V, and the new voltage range in the APDO is 7V-12V. Then the output
> > > voltage in the RDO should not be set to 5V which is lower than the
> > > possible min_volt 7V.
> > >
> > > Fix this by choosing the maximal value between the previous voltage and
> > > the new min_volt first. And ensure that this value will not exceed the
> > > new max_volt. The new out_volt will fall within the new voltage range
> > > while being the closest value compared to the previous out_volt.
> > >
> > > Signed-off-by: Kyle Tso <kyletso@google.com>
> >
> > Fixes: c710d0bb76ff0 ("usb: typec: tcpm: Extend the matching rules on PPS APDO selection")
> > Cc: stable...
>
> No need for stable, as c710d0bb76ff ("usb: typec: tcpm: Extend the
> matching rules on PPS APDO selection") only showed up in 5.0-rc1.
>
> Note, no need for the extra digit on your sha1 listing, here's the
> recommended way to show this:
> git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"
OK. Thanks for the hint!
Cheers,
--
heikki
next reply other threads:[~2019-01-31 8:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 8:46 Heikki Krogerus [this message]
2019-01-31 8:46 ` [PATCH] usb: typec: tcpm: Correct the PPS out_volt calculation Heikki Krogerus
-- strict thread matches above, loose matches on Subject: below --
2019-01-31 8:01 Greg Kroah-Hartman
2019-01-31 8:01 ` [PATCH] " Greg KH
2019-01-31 7:31 Heikki Krogerus
2019-01-31 7:31 ` [PATCH] " Heikki Krogerus
2019-01-30 17:12 Guenter Roeck
2019-01-30 17:12 ` [PATCH] " Guenter Roeck
2019-01-30 10:39 Opensource [Adam Thomson]
2019-01-30 10:39 ` [PATCH] " Adam Thomson
2019-01-30 3:13 Kyle Tso
2019-01-30 3:13 ` [PATCH] " Kyle Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131084605.GN7262@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=badhri@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.