All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Joseph Lo <josephl@nvidia.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
	linux-tegra@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 2/7] clocksource: tegra: add Tegra210 timer support
Date: Thu, 31 Jan 2019 12:23:44 +0100	[thread overview]
Message-ID: <20190131112344.GB23438@ulmo> (raw)
In-Reply-To: <20190131092410.28222-3-josephl@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 1117 bytes --]

On Thu, Jan 31, 2019 at 05:24:05PM +0800, Joseph Lo wrote:
> Add support for the Tegra210 timer that runs at oscillator clock
> (TMR10-TMR13). We need these timers to work as clock event device and to
> replace the ARMv8 architected timer due to it can't survive across the
> power cycle of the CPU core or CPUPORESET signal. So it can't be a wake-up
> source when CPU suspends in power down state.
> 
> Also convert the original driver to use timer-of API.
> 
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Joseph Lo <josephl@nvidia.com>
> ---
> v4:
>  * merge timer-tegra210.c in previous version into timer-tegra20.c
> v3:
>  * use timer-of API
> v2:
>  * add error clean-up code
> ---
>  drivers/clocksource/Kconfig         |   2 +-
>  drivers/clocksource/timer-tegra20.c | 369 ++++++++++++++++++++--------
>  include/linux/cpuhotplug.h          |   1 +
>  3 files changed, 272 insertions(+), 100 deletions(-)

Looks good to me:

Acked-by: Thierry Reding <treding@nvidia.com>

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Joseph Lo <josephl@nvidia.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
	linux-kernel@vger.kernel.org,
	Jonathan Hunter <jonathanh@nvidia.com>,
	linux-tegra@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V4 2/7] clocksource: tegra: add Tegra210 timer support
Date: Thu, 31 Jan 2019 12:23:44 +0100	[thread overview]
Message-ID: <20190131112344.GB23438@ulmo> (raw)
In-Reply-To: <20190131092410.28222-3-josephl@nvidia.com>


[-- Attachment #1.1: Type: text/plain, Size: 1117 bytes --]

On Thu, Jan 31, 2019 at 05:24:05PM +0800, Joseph Lo wrote:
> Add support for the Tegra210 timer that runs at oscillator clock
> (TMR10-TMR13). We need these timers to work as clock event device and to
> replace the ARMv8 architected timer due to it can't survive across the
> power cycle of the CPU core or CPUPORESET signal. So it can't be a wake-up
> source when CPU suspends in power down state.
> 
> Also convert the original driver to use timer-of API.
> 
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Joseph Lo <josephl@nvidia.com>
> ---
> v4:
>  * merge timer-tegra210.c in previous version into timer-tegra20.c
> v3:
>  * use timer-of API
> v2:
>  * add error clean-up code
> ---
>  drivers/clocksource/Kconfig         |   2 +-
>  drivers/clocksource/timer-tegra20.c | 369 ++++++++++++++++++++--------
>  include/linux/cpuhotplug.h          |   1 +
>  3 files changed, 272 insertions(+), 100 deletions(-)

Looks good to me:

Acked-by: Thierry Reding <treding@nvidia.com>

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-01-31 11:23 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-31  9:24 [PATCH V4 0/7] Add CPUidle support for Tegra210 Joseph Lo
2019-01-31  9:24 ` Joseph Lo
2019-01-31  9:24 ` [PATCH V4 1/7] dt-bindings: timer: add Tegra210 timer Joseph Lo
2019-01-31  9:24   ` Joseph Lo
2019-01-31  9:24   ` Joseph Lo
2019-01-31  9:24 ` [PATCH V4 2/7] clocksource: tegra: add Tegra210 timer support Joseph Lo
2019-01-31  9:24   ` Joseph Lo
2019-01-31  9:24   ` Joseph Lo
2019-01-31 11:23   ` Thierry Reding [this message]
2019-01-31 11:23     ` Thierry Reding
2019-01-31  9:24 ` [PATCH V4 3/7] soc/tegra: default select TEGRA_TIMER for Tegra210 Joseph Lo
2019-01-31  9:24   ` Joseph Lo
2019-01-31 11:26   ` Thierry Reding
2019-02-01  2:23     ` Joseph Lo
2019-02-01  2:23       ` Joseph Lo
2019-01-31  9:24 ` [PATCH V4 4/7] arm64: dts: tegra210: fix timer node Joseph Lo
2019-01-31  9:24   ` Joseph Lo
2019-01-31  9:24 ` [PATCH V4 5/7] arm64: dts: tegra210: add CPU idle states properties Joseph Lo
2019-01-31  9:24   ` Joseph Lo
2019-01-31  9:24 ` [PATCH V4 6/7] arm64: dts: tegra210-p2180: Enable CPU idle support Joseph Lo
2019-01-31  9:24   ` Joseph Lo
2019-01-31 12:57   ` Thierry Reding
2019-02-01  2:26     ` Joseph Lo
2019-02-01  2:26       ` Joseph Lo
2019-01-31  9:24 ` [PATCH V4 7/7] arm64: dts: tegra210-smaug: " Joseph Lo
2019-01-31  9:24   ` Joseph Lo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190131112344.GB23438@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=jonathanh@nvidia.com \
    --cc=josephl@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.