All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: lantianyu1986@gmail.com
Cc: Lan Tianyu <Tianyu.Lan@microsoft.com>,
	joro@8bytes.org, mchehab+samsung@kernel.org, davem@davemloft.net,
	akpm@linux-foundation.org, nicolas.ferre@microchip.com,
	arnd@arndb.de, linux-kernel@vger.kernel.org,
	iommu@lists.linux-foundation.org, michael.h.kelley@microsoft.com,
	kys@microsoft.com, vkuznets@redhat.com,
	alex.williamson@redhat.com
Subject: Re: [PATCH 2/3] HYPERV/IOMMU: Add Hyper-V stub IOMMU driver
Date: Thu, 31 Jan 2019 12:59:44 +0100	[thread overview]
Message-ID: <20190131115944.GB19969@kroah.com> (raw)
In-Reply-To: <1548929853-25877-3-git-send-email-Tianyu.Lan@microsoft.com>

On Thu, Jan 31, 2019 at 06:17:32PM +0800, lantianyu1986@gmail.com wrote:
> --- /dev/null
> +++ b/drivers/iommu/hyperv-iommu.c
> @@ -0,0 +1,189 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +#define pr_fmt(fmt)     "HYPERV-IR: " fmt

Minor nit, you never do any pr_*() calls, so this isn't needed, right?

> +static cpumask_t ioapic_max_cpumask = { CPU_BITS_NONE };
> +struct irq_domain *ioapic_ir_domain;

Global?  Why?

thanks,

greg k-h

  reply	other threads:[~2019-01-31 11:59 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-31 10:17 [PATCH 0/3] x86/Hyper-V/IOMMU: Add Hyper-V IOMMU driver to support x2apic mode lantianyu1986
2019-01-31 10:17 ` lantianyu1986
2019-01-31 10:17 ` [PATCH 1/3] x86/Hyper-V: Set x2apic destination mode to physical when x2apic is available lantianyu1986
2019-01-31 10:17   ` lantianyu1986
2019-01-31 11:57   ` Greg KH
2019-01-31 12:02     ` Tianyu Lan
2019-01-31 12:02       ` Tianyu Lan
2019-02-01  7:06   ` Dan Carpenter
2019-02-01  7:06     ` Dan Carpenter
2019-02-01  7:10     ` Tianyu Lan
2019-01-31 10:17 ` [PATCH 2/3] HYPERV/IOMMU: Add Hyper-V stub IOMMU driver lantianyu1986
2019-01-31 10:17   ` lantianyu1986
2019-01-31 11:59   ` Greg KH [this message]
2019-01-31 12:08     ` Tianyu Lan
2019-01-31 14:04   ` Vitaly Kuznetsov
2019-02-01  5:45     ` Tianyu Lan
     [not found]   ` <1548929853-25877-3-git-send-email-Tianyu.Lan-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>
2019-02-01 14:51     ` Sasha Levin
2019-02-02  6:02       ` Tianyu Lan
2019-02-02  6:02         ` Tianyu Lan
2019-02-01 16:34   ` Joerg Roedel
2019-02-02  2:51     ` Tianyu Lan
2019-02-01 17:00   ` Robin Murphy
2019-02-02  6:20     ` Tianyu Lan
2019-01-31 10:17 ` [PATCH 3/3] MAINTAINERS: Add Hyper-V IOMMU driver into Hyper-V CORE AND DRIVERS scope lantianyu1986

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190131115944.GB19969@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Tianyu.Lan@microsoft.com \
    --cc=akpm@linux-foundation.org \
    --cc=alex.williamson@redhat.com \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=kys@microsoft.com \
    --cc=lantianyu1986@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab+samsung@kernel.org \
    --cc=michael.h.kelley@microsoft.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.