From: Dan Carpenter <dan.carpenter@oracle.com>
To: lantianyu1986@gmail.com
Cc: nicolas.ferre@microchip.com, hpa@zytor.com,
mchehab+samsung@kernel.org, sashal@kernel.org,
sthemmin@microsoft.com, joro@8bytes.org, x86@kernel.org,
michael.h.kelley@microsoft.com, mingo@redhat.com,
Lan Tianyu <Tianyu.Lan@microsoft.com>,
arnd@arndb.de, haiyangz@microsoft.com,
alex.williamson@redhat.com, bp@alien8.de, tglx@linutronix.de,
vkuznets@redhat.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
devel@linuxdriverproject.org, akpm@linux-foundation.org,
davem@davemloft.net
Subject: Re: [PATCH 1/3] x86/Hyper-V: Set x2apic destination mode to physical when x2apic is available
Date: Fri, 1 Feb 2019 10:06:55 +0300 [thread overview]
Message-ID: <20190201070655.GA14343@kadam> (raw)
In-Reply-To: <1548929853-25877-2-git-send-email-Tianyu.Lan@microsoft.com>
On Thu, Jan 31, 2019 at 06:17:31PM +0800, lantianyu1986@gmail.com wrote:
>
>
This comment needs to be indented one tab or it looks like we're outside
the funciton.
> +/*
> + * Hyper-V doesn't provide irq remapping for IO-APIC. To enable x2apic,
> + * set x2apic destination mode to physcial mode when x2apic is available
> + * and Hyper-V IOMMU driver makes sure cpus assigned with IO-APIC irqs
> + * have 8-bit APIC id.
> + */
> +# if IS_ENABLED(CONFIG_HYPERV_IOMMU)
> + if (x2apic_supported())
> + x2apic_phys = 1;
> +# endif
The IS_ENABLED() macro is really magical. You could write this like so:
if (IS_ENABLED(CONFIG_HYPERV_IOMMU) && x2apic_supported())
x2apic_phys = 1;
It works the same and is slightly more pleasant to look at.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: lantianyu1986@gmail.com
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com,
mchehab+samsung@kernel.org, sashal@kernel.org,
sthemmin@microsoft.com, joro@8bytes.org, x86@kernel.org,
michael.h.kelley@microsoft.com, mingo@redhat.com,
Lan Tianyu <Tianyu.Lan@microsoft.com>,
arnd@arndb.de, haiyangz@microsoft.com,
alex.williamson@redhat.com, bp@alien8.de, tglx@linutronix.de,
vkuznets@redhat.com, gregkh@linuxfoundation.org,
nicolas.ferre@microchip.com, iommu@lists.linux-foundation.org,
devel@linuxdriverproject.org, akpm@linux-foundation.org,
davem@davemloft.net
Subject: Re: [PATCH 1/3] x86/Hyper-V: Set x2apic destination mode to physical when x2apic is available
Date: Fri, 1 Feb 2019 10:06:55 +0300 [thread overview]
Message-ID: <20190201070655.GA14343@kadam> (raw)
In-Reply-To: <1548929853-25877-2-git-send-email-Tianyu.Lan@microsoft.com>
On Thu, Jan 31, 2019 at 06:17:31PM +0800, lantianyu1986@gmail.com wrote:
>
>
This comment needs to be indented one tab or it looks like we're outside
the funciton.
> +/*
> + * Hyper-V doesn't provide irq remapping for IO-APIC. To enable x2apic,
> + * set x2apic destination mode to physcial mode when x2apic is available
> + * and Hyper-V IOMMU driver makes sure cpus assigned with IO-APIC irqs
> + * have 8-bit APIC id.
> + */
> +# if IS_ENABLED(CONFIG_HYPERV_IOMMU)
> + if (x2apic_supported())
> + x2apic_phys = 1;
> +# endif
The IS_ENABLED() macro is really magical. You could write this like so:
if (IS_ENABLED(CONFIG_HYPERV_IOMMU) && x2apic_supported())
x2apic_phys = 1;
It works the same and is slightly more pleasant to look at.
regards,
dan carpenter
next prev parent reply other threads:[~2019-02-01 7:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 10:17 [PATCH 0/3] x86/Hyper-V/IOMMU: Add Hyper-V IOMMU driver to support x2apic mode lantianyu1986
2019-01-31 10:17 ` lantianyu1986
2019-01-31 10:17 ` [PATCH 1/3] x86/Hyper-V: Set x2apic destination mode to physical when x2apic is available lantianyu1986
2019-01-31 10:17 ` lantianyu1986
2019-01-31 11:57 ` Greg KH
2019-01-31 12:02 ` Tianyu Lan
2019-01-31 12:02 ` Tianyu Lan
2019-02-01 7:06 ` Dan Carpenter [this message]
2019-02-01 7:06 ` Dan Carpenter
2019-02-01 7:10 ` Tianyu Lan
2019-01-31 10:17 ` [PATCH 2/3] HYPERV/IOMMU: Add Hyper-V stub IOMMU driver lantianyu1986
2019-01-31 10:17 ` lantianyu1986
2019-01-31 11:59 ` Greg KH
2019-01-31 12:08 ` Tianyu Lan
2019-01-31 14:04 ` Vitaly Kuznetsov
2019-02-01 5:45 ` Tianyu Lan
[not found] ` <1548929853-25877-3-git-send-email-Tianyu.Lan-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>
2019-02-01 14:51 ` Sasha Levin
2019-02-02 6:02 ` Tianyu Lan
2019-02-02 6:02 ` Tianyu Lan
2019-02-01 16:34 ` Joerg Roedel
2019-02-02 2:51 ` Tianyu Lan
2019-02-01 17:00 ` Robin Murphy
2019-02-02 6:20 ` Tianyu Lan
2019-01-31 10:17 ` [PATCH 3/3] MAINTAINERS: Add Hyper-V IOMMU driver into Hyper-V CORE AND DRIVERS scope lantianyu1986
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201070655.GA14343@kadam \
--to=dan.carpenter@oracle.com \
--cc=Tianyu.Lan@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=lantianyu1986@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=michael.h.kelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=nicolas.ferre@microchip.com \
--cc=sashal@kernel.org \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.