From: Christoph Hellwig <hch@lst.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Robin Murphy <robin.murphy@arm.com>,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
iommu@lists.linux-foundation.org,
Corentin Labbe <clabbe@baylibre.com>
Subject: Re: [PATCH] dma: debug: no need to check return value of debugfs_create functions
Date: Fri, 1 Feb 2019 10:04:02 +0100 [thread overview]
Message-ID: <20190201090402.GA16244@lst.de> (raw)
In-Reply-To: <20190122184847.GA32627@kroah.com>
On Tue, Jan 22, 2019 at 07:48:47PM +0100, Greg Kroah-Hartman wrote:
> > Does this actually need to be at file scope, or could it be punted to a
> > local in dma_debug_fs_init() while we're here?
>
> It can be moved to the function scope if you want me to, I was trying to
> do the least needed here :)
I've folded the scope move in when applying the patch to the
dma-mapping for-next tree.
Thanks!
next prev parent reply other threads:[~2019-02-01 9:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 15:21 [PATCH] dma: debug: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-01-22 18:44 ` Robin Murphy
2019-01-22 18:48 ` Greg Kroah-Hartman
2019-02-01 9:04 ` Christoph Hellwig [this message]
2019-02-01 9:12 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201090402.GA16244@lst.de \
--to=hch@lst.de \
--cc=clabbe@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.