From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Mimi Zohar <zohar@linux.ibm.com>, christophe.ricard@gmail.com
Cc: Roberto Sassu <roberto.sassu@huawei.com>,
david.safford@ge.com, monty.wiseman@ge.com,
matthewgarrett@google.com, linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
linux-kernel@vger.kernel.org, silviu.vlasceanu@huawei.com
Subject: Re: [PATCH v9 6/6] tpm: pass an array of tpm_extend_digest structures to tpm_pcr_extend()
Date: Fri, 01 Feb 2019 17:42:56 +0000 [thread overview]
Message-ID: <20190201174256.GA23559@linux.intel.com> (raw)
In-Reply-To: <20190201173330.GA5522@linux.intel.com>
On Fri, Feb 01, 2019 at 07:33:30PM +0200, Jarkko Sakkinen wrote:
> On Fri, Feb 01, 2019 at 09:33:09AM -0500, Mimi Zohar wrote:
> > Thanks! I just finished compiling, rebooting, and verifying the IMA
> > boot-aggregate matches.
> >
> > While compiling, I saw some messages that "TPM_BUFSIZE is redefined"
> > for tpm_i2c_infineon, tpm_i2c_nuvoton, and st33zp24. Didn't look to
> > see if this is a result of this patch set or not.
> >
> > The IMA boot-aggregate matches the PCRs.
> >
> > Tested-by: Mimi Zohar <zohar@linux.ibm.com> (on x86 for TPM 1.2 & PTT
> > TPM 2.0)
>
> Thank you.
>
> I found the reason for that warning. It is redefined, for reason unknown
> to me in drivers/char/tpm/st33zp24/st33zp24.h (commit bf38b8710892).
>
> I'll post a fix to that commit ASAP. After that commit has been applied
> I can apply Roberto's patches.
Just sent. No need to any testing for that one. Just need one
reviewed-by or even acked-by, and after that I will apply all Roberto's
patches.
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Mimi Zohar <zohar@linux.ibm.com>, christophe.ricard@gmail.com
Cc: Roberto Sassu <roberto.sassu@huawei.com>,
david.safford@ge.com, monty.wiseman@ge.com,
matthewgarrett@google.com, linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
linux-kernel@vger.kernel.org, silviu.vlasceanu@huawei.com
Subject: Re: [PATCH v9 6/6] tpm: pass an array of tpm_extend_digest structures to tpm_pcr_extend()
Date: Fri, 1 Feb 2019 19:42:56 +0200 [thread overview]
Message-ID: <20190201174256.GA23559@linux.intel.com> (raw)
In-Reply-To: <20190201173330.GA5522@linux.intel.com>
On Fri, Feb 01, 2019 at 07:33:30PM +0200, Jarkko Sakkinen wrote:
> On Fri, Feb 01, 2019 at 09:33:09AM -0500, Mimi Zohar wrote:
> > Thanks! I just finished compiling, rebooting, and verifying the IMA
> > boot-aggregate matches.
> >
> > While compiling, I saw some messages that "TPM_BUFSIZE is redefined"
> > for tpm_i2c_infineon, tpm_i2c_nuvoton, and st33zp24. Didn't look to
> > see if this is a result of this patch set or not.
> >
> > The IMA boot-aggregate matches the PCRs.
> >
> > Tested-by: Mimi Zohar <zohar@linux.ibm.com> (on x86 for TPM 1.2 & PTT
> > TPM 2.0)
>
> Thank you.
>
> I found the reason for that warning. It is redefined, for reason unknown
> to me in drivers/char/tpm/st33zp24/st33zp24.h (commit bf38b8710892).
>
> I'll post a fix to that commit ASAP. After that commit has been applied
> I can apply Roberto's patches.
Just sent. No need to any testing for that one. Just need one
reviewed-by or even acked-by, and after that I will apply all Roberto's
patches.
/Jarkko
next prev parent reply other threads:[~2019-02-01 17:42 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 10:06 [PATCH v9 0/6] tpm: retrieve digest size of unknown algorithms from TPM Roberto Sassu
2019-02-01 10:06 ` Roberto Sassu
2019-02-01 10:06 ` [PATCH v9 1/6] tpm: dynamically allocate the allocated_banks array Roberto Sassu
2019-02-01 10:06 ` Roberto Sassu
2019-02-01 13:34 ` Jarkko Sakkinen
2019-02-01 13:34 ` Jarkko Sakkinen
2019-02-01 10:06 ` [PATCH v9 2/6] tpm: rename and export tpm2_digest and tpm2_algorithms Roberto Sassu
2019-02-01 10:06 ` Roberto Sassu
2019-02-01 13:36 ` Jarkko Sakkinen
2019-02-01 13:36 ` Jarkko Sakkinen
2019-02-01 10:06 ` [PATCH v9 3/6] tpm: retrieve digest size of unknown algorithms with PCR read Roberto Sassu
2019-02-01 10:06 ` Roberto Sassu
2019-02-01 10:06 ` [PATCH v9 4/6] tpm: move tpm_chip definition to include/linux/tpm.h Roberto Sassu
2019-02-01 10:06 ` Roberto Sassu
2019-02-01 13:38 ` Jarkko Sakkinen
2019-02-01 13:38 ` Jarkko Sakkinen
2019-02-04 8:58 ` kbuild test robot
2019-02-04 8:58 ` kbuild test robot
2019-02-01 10:06 ` [PATCH v9 5/6] KEYS: trusted: explicitly use tpm_chip structure from tpm_default_chip() Roberto Sassu
2019-02-01 10:06 ` Roberto Sassu
2019-02-01 13:39 ` Jarkko Sakkinen
2019-02-01 13:39 ` Jarkko Sakkinen
2019-02-01 10:06 ` [PATCH v9 6/6] tpm: pass an array of tpm_extend_digest structures to tpm_pcr_extend() Roberto Sassu
2019-02-01 10:06 ` Roberto Sassu
2019-02-01 13:39 ` Jarkko Sakkinen
2019-02-01 13:39 ` Jarkko Sakkinen
2019-02-01 13:41 ` Jarkko Sakkinen
2019-02-01 13:41 ` Jarkko Sakkinen
2019-02-01 14:33 ` Mimi Zohar
2019-02-01 14:33 ` Mimi Zohar
2019-02-01 17:33 ` Jarkko Sakkinen
2019-02-01 17:33 ` Jarkko Sakkinen
2019-02-01 17:42 ` Jarkko Sakkinen [this message]
2019-02-01 17:42 ` Jarkko Sakkinen
2019-02-01 19:15 ` Mimi Zohar
2019-02-01 19:15 ` Mimi Zohar
2019-02-04 9:14 ` Roberto Sassu
2019-02-04 9:14 ` Roberto Sassu
2019-02-04 12:07 ` Jarkko Sakkinen
2019-02-04 12:07 ` Jarkko Sakkinen
2019-02-04 12:59 ` Mimi Zohar
2019-02-04 12:59 ` Mimi Zohar
2019-02-04 13:21 ` Roberto Sassu
2019-02-04 13:21 ` Roberto Sassu
2019-02-04 23:26 ` Jarkko Sakkinen
2019-02-04 23:26 ` Jarkko Sakkinen
2019-02-04 23:30 ` Jarkko Sakkinen
2019-02-04 23:30 ` Jarkko Sakkinen
2019-02-05 10:02 ` Roberto Sassu
2019-02-05 10:02 ` Roberto Sassu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201174256.GA23559@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=christophe.ricard@gmail.com \
--cc=david.safford@ge.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=matthewgarrett@google.com \
--cc=monty.wiseman@ge.com \
--cc=roberto.sassu@huawei.com \
--cc=silviu.vlasceanu@huawei.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.