From: Ido Schimmel <idosch@mellanox.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"jiri@resnulli.us" <jiri@resnulli.us>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"oss-drivers@netronome.com" <oss-drivers@netronome.com>
Subject: Re: [PATCH net-next] net: devlink: report cell size of shared buffers
Date: Sat, 2 Feb 2019 12:35:51 +0000 [thread overview]
Message-ID: <20190202123549.GA24795@splinter> (raw)
In-Reply-To: <20190202015628.30877-1-jakub.kicinski@netronome.com>
On Fri, Feb 01, 2019 at 05:56:28PM -0800, Jakub Kicinski wrote:
> Shared buffer allocation is usually done in cell increments.
> Drivers will either round up the allocation or refuse the
> configuration if it's not an exact multiple of cell size.
> Drivers know exactly the cell size of shared buffer, so help
> out users by providing this information in dumps.
>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
I assume you're going to patch iproute2. Consider explaining what is
cell size in devlink-sb manpage.
Thanks!
next prev parent reply other threads:[~2019-02-02 12:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-02 1:56 [PATCH net-next] net: devlink: report cell size of shared buffers Jakub Kicinski
2019-02-02 12:35 ` Ido Schimmel [this message]
2019-02-02 22:00 ` Jakub Kicinski
2019-02-03 19:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190202123549.GA24795@splinter \
--to=idosch@mellanox.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.