All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <bbrezillon@kernel.org>
To: Liu Jian <liujian56@huawei.com>, <ikegami@allied-telesis.co.jp>
Cc: keescook@chromium.org, Przemyslaw Sobon <psobon@amazon.com>,
	joakim.tjernlund@infinera.com, richard@nod.at,
	linux-kernel@vger.kernel.org, marek.vasut@gmail.com,
	linux-mtd@lists.infradead.org, computersforpeace@gmail.com,
	dwmw2@infradead.org
Subject: Re: [PATCH] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer
Date: Sun, 3 Feb 2019 09:35:09 +0100	[thread overview]
Message-ID: <20190203093509.269bf1e1@bbrezillon> (raw)
In-Reply-To: <20190203092645.18d1495b@bbrezillon>

On Sun, 3 Feb 2019 09:26:45 +0100
Boris Brezillon <bbrezillon@kernel.org> wrote:

> +Przemyslaw
> 
> On Fri, 1 Feb 2019 07:30:39 +0800
> Liu Jian <liujian56@huawei.com> wrote:
> 
> > In function do_write_buffer(), in the for loop, there is a case
> > chip_ready() returns 1 while chip_good() returns 0, so it never
> > break the loop.
> > To fix this, chip_good() is enough and it should timeout if it stay
> > bad for a while.  
> 
> Looks like Przemyslaw reported and fixed the same problem.
> 
> > 
> > Fixes: dfeae1073583(mtd: cfi_cmdset_0002: Change write buffer to check
> > correct value)  
> 
> Can you put the Fixes tag on a single, and the format is
> 
> Fixes: <hash> ("message")
> 
> > Signed-off-by: Yi Huaijie <yihuaijie@huawei.com>
> > Signed-off-by: Liu Jian <liujian56@huawei.com>  
> 
> [1]http://patchwork.ozlabs.org/patch/1025566/
> 
> > ---
> >  drivers/mtd/chips/cfi_cmdset_0002.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
> > index 72428b6..818e94b 100644
> > --- a/drivers/mtd/chips/cfi_cmdset_0002.c
> > +++ b/drivers/mtd/chips/cfi_cmdset_0002.c
> > @@ -1876,14 +1876,14 @@ static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip,
> >  			continue;
> >  		}
> >  
> > -		if (time_after(jiffies, timeo) && !chip_ready(map, adr))
> > -			break;
> > -
> >  		if (chip_good(map, adr, datum)) {
> >  			xip_enable(map, chip, adr);
> >  			goto op_done;
> >  		}
> >  
> > +		if (time_after(jiffies, timeo))
> > +			break;
> > +
> >  		/* Latency issues. Drop the lock, wait a while and retry */
> >  		UDELAY(map, chip, adr, 1);
> >  	}  
> 

BTW, the patch itself looks good to me. Ikegami, can you confirm it
does the right thing?

Thanks,

Boris

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <bbrezillon@kernel.org>
To: Liu Jian <liujian56@huawei.com>, <ikegami@allied-telesis.co.jp>
Cc: <dwmw2@infradead.org>, <computersforpeace@gmail.com>,
	<marek.vasut@gmail.com>, <richard@nod.at>,
	<joakim.tjernlund@infinera.com>, <keescook@chromium.org>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	Przemyslaw Sobon <psobon@amazon.com>
Subject: Re: [PATCH] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer
Date: Sun, 3 Feb 2019 09:35:09 +0100	[thread overview]
Message-ID: <20190203093509.269bf1e1@bbrezillon> (raw)
In-Reply-To: <20190203092645.18d1495b@bbrezillon>

On Sun, 3 Feb 2019 09:26:45 +0100
Boris Brezillon <bbrezillon@kernel.org> wrote:

> +Przemyslaw
> 
> On Fri, 1 Feb 2019 07:30:39 +0800
> Liu Jian <liujian56@huawei.com> wrote:
> 
> > In function do_write_buffer(), in the for loop, there is a case
> > chip_ready() returns 1 while chip_good() returns 0, so it never
> > break the loop.
> > To fix this, chip_good() is enough and it should timeout if it stay
> > bad for a while.  
> 
> Looks like Przemyslaw reported and fixed the same problem.
> 
> > 
> > Fixes: dfeae1073583(mtd: cfi_cmdset_0002: Change write buffer to check
> > correct value)  
> 
> Can you put the Fixes tag on a single, and the format is
> 
> Fixes: <hash> ("message")
> 
> > Signed-off-by: Yi Huaijie <yihuaijie@huawei.com>
> > Signed-off-by: Liu Jian <liujian56@huawei.com>  
> 
> [1]http://patchwork.ozlabs.org/patch/1025566/
> 
> > ---
> >  drivers/mtd/chips/cfi_cmdset_0002.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
> > index 72428b6..818e94b 100644
> > --- a/drivers/mtd/chips/cfi_cmdset_0002.c
> > +++ b/drivers/mtd/chips/cfi_cmdset_0002.c
> > @@ -1876,14 +1876,14 @@ static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip,
> >  			continue;
> >  		}
> >  
> > -		if (time_after(jiffies, timeo) && !chip_ready(map, adr))
> > -			break;
> > -
> >  		if (chip_good(map, adr, datum)) {
> >  			xip_enable(map, chip, adr);
> >  			goto op_done;
> >  		}
> >  
> > +		if (time_after(jiffies, timeo))
> > +			break;
> > +
> >  		/* Latency issues. Drop the lock, wait a while and retry */
> >  		UDELAY(map, chip, adr, 1);
> >  	}  
> 

BTW, the patch itself looks good to me. Ikegami, can you confirm it
does the right thing?

Thanks,

Boris

  reply	other threads:[~2019-02-03  8:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-31 23:30 [PATCH] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer Liu Jian
2019-01-31 23:30 ` Liu Jian
2019-02-03  8:26 ` Boris Brezillon
2019-02-03  8:26   ` Boris Brezillon
2019-02-03  8:35   ` Boris Brezillon [this message]
2019-02-03  8:35     ` Boris Brezillon
2019-02-05 22:28     ` Sobon, Przemyslaw
2019-02-05 22:28       ` Sobon, Przemyslaw
2019-02-05 23:03       ` ikegami_to
2019-02-07  8:56       ` Boris Brezillon
2019-02-07  8:56         ` Boris Brezillon
2019-02-07 22:59         ` ikegami_to
2019-02-07 23:50           ` Sobon, Przemyslaw
2019-02-07 23:50             ` Sobon, Przemyslaw
2019-02-08  8:45             ` Joakim Tjernlund
2019-02-08  8:45               ` Joakim Tjernlund
2019-02-08 14:23             ` Tokunori Ikegami
2019-02-08 14:23               ` Tokunori Ikegami
2019-02-14  1:34               ` liujian (CE)
2019-02-14  1:34                 ` liujian (CE)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190203093509.269bf1e1@bbrezillon \
    --to=bbrezillon@kernel.org \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=ikegami@allied-telesis.co.jp \
    --cc=joakim.tjernlund@infinera.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=liujian56@huawei.com \
    --cc=marek.vasut@gmail.com \
    --cc=psobon@amazon.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.