From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH v2] ui/sdl_keysym: Remove obsolete SDL1.2 related code
Date: Mon, 4 Feb 2019 12:52:54 +0000 [thread overview]
Message-ID: <20190204125254.GI1905@redhat.com> (raw)
In-Reply-To: <1549282241-23535-1-git-send-email-thuth@redhat.com>
On Mon, Feb 04, 2019 at 01:10:41PM +0100, Thomas Huth wrote:
> sdl_keysym.h has only been included by sdl.c which has recently been
> removed recently with this commit:
>
> 0015ca5cbabe0b31d31610ddfaafd90a9e5911a4
> ("ui: remove support for SDL1.2 in favour of SDL2")
>
> So we can drop this header file now completely, too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> v2: The file is now removed completely.
>
> ui/sdl_keysym.h | 278 --------------------------------------------------------
> 1 file changed, 278 deletions(-)
> delete mode 100644 ui/sdl_keysym.h
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
WARNING: multiple messages have this Message-ID (diff)
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] ui/sdl_keysym: Remove obsolete SDL1.2 related code
Date: Mon, 4 Feb 2019 12:52:54 +0000 [thread overview]
Message-ID: <20190204125254.GI1905@redhat.com> (raw)
In-Reply-To: <1549282241-23535-1-git-send-email-thuth@redhat.com>
On Mon, Feb 04, 2019 at 01:10:41PM +0100, Thomas Huth wrote:
> sdl_keysym.h has only been included by sdl.c which has recently been
> removed recently with this commit:
>
> 0015ca5cbabe0b31d31610ddfaafd90a9e5911a4
> ("ui: remove support for SDL1.2 in favour of SDL2")
>
> So we can drop this header file now completely, too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> v2: The file is now removed completely.
>
> ui/sdl_keysym.h | 278 --------------------------------------------------------
> 1 file changed, 278 deletions(-)
> delete mode 100644 ui/sdl_keysym.h
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2019-02-04 12:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 12:10 [Qemu-trivial] [PATCH v2] ui/sdl_keysym: Remove obsolete SDL1.2 related code Thomas Huth
2019-02-04 12:10 ` [Qemu-devel] " Thomas Huth
2019-02-04 12:29 ` [Qemu-trivial] " no-reply
2019-02-04 12:29 ` no-reply
2019-02-04 12:52 ` Daniel P. Berrangé [this message]
2019-02-04 12:52 ` Daniel P. Berrangé
2019-02-05 8:55 ` [Qemu-trivial] " Gerd Hoffmann
2019-02-05 8:55 ` [Qemu-devel] " Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204125254.GI1905@redhat.com \
--to=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.