* [PATCH] ath10k: fix S5 power consumption issue for QCA9377
@ 2019-01-15 6:31 ` Yu Wang
0 siblings, 0 replies; 6+ messages in thread
From: Yu Wang @ 2019-01-15 6:31 UTC (permalink / raw)
To: ath10k; +Cc: Yu Wang, linux-wireless
After system entering S5 (shut down but system still
providing power to QCA9377) on Ubuntu platform, power
consumption of QCA9377 is 69mA, which is too high.
The root cause is pci_soft_reset is not set for QCA9377
during pci probe.
To fix this issue, set 'pci_soft_reset' to 'th10k_pci_warm_reset',
and then the power consumption drops to a normal value(10mA).
Verified on Dell Ubuntu platform with firmware:
WLAN.TF.1.0-00002-QCATFSWPZ-5
Signed-off-by: Yu Wang <yyuwang@codeaurora.org>
---
drivers/net/wireless/ath/ath10k/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index 01b4edb..0a4ce98 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -3554,7 +3554,7 @@ static int ath10k_pci_probe(struct pci_dev *pdev,
case QCA9377_1_0_DEVICE_ID:
hw_rev = ATH10K_HW_QCA9377;
pci_ps = true;
- pci_soft_reset = NULL;
+ pci_soft_reset = ath10k_pci_warm_reset;
pci_hard_reset = ath10k_pci_qca6174_chip_reset;
targ_cpu_to_ce_addr = ath10k_pci_qca6174_targ_cpu_to_ce_addr;
break;
--
1.9.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ath10k: fix S5 power consumption issue for QCA9377
@ 2019-01-15 6:31 ` Yu Wang
0 siblings, 0 replies; 6+ messages in thread
From: Yu Wang @ 2019-01-15 6:31 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Yu Wang
After system entering S5 (shut down but system still
providing power to QCA9377) on Ubuntu platform, power
consumption of QCA9377 is 69mA, which is too high.
The root cause is pci_soft_reset is not set for QCA9377
during pci probe.
To fix this issue, set 'pci_soft_reset' to 'th10k_pci_warm_reset',
and then the power consumption drops to a normal value(10mA).
Verified on Dell Ubuntu platform with firmware:
WLAN.TF.1.0-00002-QCATFSWPZ-5
Signed-off-by: Yu Wang <yyuwang@codeaurora.org>
---
drivers/net/wireless/ath/ath10k/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index 01b4edb..0a4ce98 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -3554,7 +3554,7 @@ static int ath10k_pci_probe(struct pci_dev *pdev,
case QCA9377_1_0_DEVICE_ID:
hw_rev = ATH10K_HW_QCA9377;
pci_ps = true;
- pci_soft_reset = NULL;
+ pci_soft_reset = ath10k_pci_warm_reset;
pci_hard_reset = ath10k_pci_qca6174_chip_reset;
targ_cpu_to_ce_addr = ath10k_pci_qca6174_targ_cpu_to_ce_addr;
break;
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] ath10k: fix S5 power consumption issue for QCA9377
2019-01-15 6:31 ` Yu Wang
@ 2019-01-15 6:36 ` Robert Chang
-1 siblings, 0 replies; 6+ messages in thread
From: Robert Chang @ 2019-01-15 6:36 UTC (permalink / raw)
To: Yu Wang, ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org, Karen Huang (TAM)
+ Karen
Thanks,
Robert
-----Original Message-----
From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Yu Wang
Sent: Tuesday, January 15, 2019 2:31 PM
To: ath10k@lists.infradead.org
Cc: Yu Wang <yyuwang@codeaurora.org>; linux-wireless@vger.kernel.org
Subject: [EXT] [PATCH] ath10k: fix S5 power consumption issue for QCA9377
After system entering S5 (shut down but system still providing power to QCA9377) on Ubuntu platform, power consumption of QCA9377 is 69mA, which is too high.
The root cause is pci_soft_reset is not set for QCA9377 during pci probe.
To fix this issue, set 'pci_soft_reset' to 'th10k_pci_warm_reset', and then the power consumption drops to a normal value(10mA).
Verified on Dell Ubuntu platform with firmware:
WLAN.TF.1.0-00002-QCATFSWPZ-5
Signed-off-by: Yu Wang <yyuwang@codeaurora.org>
---
drivers/net/wireless/ath/ath10k/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index 01b4edb..0a4ce98 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -3554,7 +3554,7 @@ static int ath10k_pci_probe(struct pci_dev *pdev,
case QCA9377_1_0_DEVICE_ID:
hw_rev = ATH10K_HW_QCA9377;
pci_ps = true;
- pci_soft_reset = NULL;
+ pci_soft_reset = ath10k_pci_warm_reset;
pci_hard_reset = ath10k_pci_qca6174_chip_reset;
targ_cpu_to_ce_addr = ath10k_pci_qca6174_targ_cpu_to_ce_addr;
break;
--
1.9.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] ath10k: fix S5 power consumption issue for QCA9377
@ 2019-01-15 6:36 ` Robert Chang
0 siblings, 0 replies; 6+ messages in thread
From: Robert Chang @ 2019-01-15 6:36 UTC (permalink / raw)
To: Yu Wang, ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org, Karen Huang (TAM)
+ Karen
Thanks,
Robert
-----Original Message-----
From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Yu Wang
Sent: Tuesday, January 15, 2019 2:31 PM
To: ath10k@lists.infradead.org
Cc: Yu Wang <yyuwang@codeaurora.org>; linux-wireless@vger.kernel.org
Subject: [EXT] [PATCH] ath10k: fix S5 power consumption issue for QCA9377
After system entering S5 (shut down but system still providing power to QCA9377) on Ubuntu platform, power consumption of QCA9377 is 69mA, which is too high.
The root cause is pci_soft_reset is not set for QCA9377 during pci probe.
To fix this issue, set 'pci_soft_reset' to 'th10k_pci_warm_reset', and then the power consumption drops to a normal value(10mA).
Verified on Dell Ubuntu platform with firmware:
WLAN.TF.1.0-00002-QCATFSWPZ-5
Signed-off-by: Yu Wang <yyuwang@codeaurora.org>
---
drivers/net/wireless/ath/ath10k/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index 01b4edb..0a4ce98 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -3554,7 +3554,7 @@ static int ath10k_pci_probe(struct pci_dev *pdev,
case QCA9377_1_0_DEVICE_ID:
hw_rev = ATH10K_HW_QCA9377;
pci_ps = true;
- pci_soft_reset = NULL;
+ pci_soft_reset = ath10k_pci_warm_reset;
pci_hard_reset = ath10k_pci_qca6174_chip_reset;
targ_cpu_to_ce_addr = ath10k_pci_qca6174_targ_cpu_to_ce_addr;
break;
--
1.9.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: fix S5 power consumption issue for QCA9377
2019-01-15 6:31 ` Yu Wang
(?)
(?)
@ 2019-02-04 15:51 ` Kalle Valo
-1 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2019-02-04 15:51 UTC (permalink / raw)
To: Yu Wang; +Cc: linux-wireless, ath10k
Yu Wang <yyuwang@codeaurora.org> wrote:
> After system entering S5 (shut down but system still
> providing power to QCA9377) on Ubuntu platform, power
> consumption of QCA9377 is 69mA, which is too high.
> The root cause is pci_soft_reset is not set for QCA9377
> during pci probe.
> To fix this issue, set 'pci_soft_reset' to 'th10k_pci_warm_reset',
> and then the power consumption drops to a normal value(10mA).
> Verified on Dell Ubuntu platform with firmware:
> WLAN.TF.1.0-00002-QCATFSWPZ-5
>
> Signed-off-by: Yu Wang <yyuwang@codeaurora.org>
> Signed-off-by: Yu Wang <yyuwang@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
1a86be476cfa ath10k: fix S5 power consumption issue for QCA9377
--
https://patchwork.kernel.org/patch/10764017/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: fix S5 power consumption issue for QCA9377
2019-01-15 6:31 ` Yu Wang
` (2 preceding siblings ...)
(?)
@ 2019-02-04 15:51 ` Kalle Valo
-1 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2019-02-04 15:51 UTC (permalink / raw)
To: Yu Wang; +Cc: ath10k, linux-wireless, Yu Wang
Yu Wang <yyuwang@codeaurora.org> wrote:
> After system entering S5 (shut down but system still
> providing power to QCA9377) on Ubuntu platform, power
> consumption of QCA9377 is 69mA, which is too high.
> The root cause is pci_soft_reset is not set for QCA9377
> during pci probe.
> To fix this issue, set 'pci_soft_reset' to 'th10k_pci_warm_reset',
> and then the power consumption drops to a normal value(10mA).
> Verified on Dell Ubuntu platform with firmware:
> WLAN.TF.1.0-00002-QCATFSWPZ-5
>
> Signed-off-by: Yu Wang <yyuwang@codeaurora.org>
> Signed-off-by: Yu Wang <yyuwang@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
1a86be476cfa ath10k: fix S5 power consumption issue for QCA9377
--
https://patchwork.kernel.org/patch/10764017/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-04 15:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-15 6:31 [PATCH] ath10k: fix S5 power consumption issue for QCA9377 Yu Wang
2019-01-15 6:31 ` Yu Wang
2019-01-15 6:36 ` Robert Chang
2019-01-15 6:36 ` Robert Chang
2019-02-04 15:51 ` Kalle Valo
2019-02-04 15:51 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.