From: Kalle Valo <kvalo@codeaurora.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Yu Wang <yyuwang@codeaurora.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
ath10k@lists.infradead.org, Govind Singh <govinds@codeaurora.org>,
Rakesh Pillai <pillair@codeaurora.org>,
stable@vger.kernel.org
Subject: Re: [PATCH REGRESSION] Revert "ath10k: add quiet mode support for QCA6174/QCA9377"
Date: Mon, 4 Feb 2019 16:42:54 +0000 (UTC) [thread overview]
Message-ID: <20190204164254.BF5DD60721@smtp.codeaurora.org> (raw)
In-Reply-To: <20181107185643.240346-1-briannorris@chromium.org>
Brian Norris <briannorris@chromium.org> wrote:
> This reverts commit cfb353c0dc058bc1619cc226d3cbbda1f360bdd3.
>
> WCN3990 firmware does not yet implement this feature, and so it crashes
> like this:
>
> fatal error received: err_qdi.c:456:EX:wlan_process:1:WLAN RT:207a:PC=b001b4f0
>
> This feature can be re-implemented with a proper service bitmap or other
> feature-discovery mechanism in the future. But it should not break
> working boards.
>
> Fixes: cfb353c0dc05 ("ath10k: add quiet mode support for QCA6174/QCA9377")
> Cc: Yu Wang <yyuwang@codeaurora.org>
> Cc: Rakesh Pillai <pillair@codeaurora.org>
> Cc: Govind Singh <govinds@codeaurora.org>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
This regression should be fixed by (which is in v4.20):
53884577fbce ath10k: skip sending quiet mode cmd for WCN3990
So this revert should not be needed anymore and I'll drop this.
--
https://patchwork.kernel.org/patch/10672903/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2019-02-04 16:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 18:56 [PATCH REGRESSION] Revert "ath10k: add quiet mode support for QCA6174/QCA9377" Brian Norris
2018-11-07 18:56 ` Brian Norris
2018-11-07 21:30 ` Rajkumar Manoharan
2018-11-07 21:30 ` Rajkumar Manoharan
2018-11-08 4:31 ` Govind Singh
2018-11-08 4:31 ` Govind Singh
2018-11-08 17:30 ` Brian Norris
2018-11-08 17:30 ` Brian Norris
2018-11-08 19:52 ` Rajkumar Manoharan
2018-11-08 19:52 ` Rajkumar Manoharan
2018-11-16 10:14 ` Kalle Valo
2018-11-16 10:14 ` Kalle Valo
2018-11-16 21:15 ` Brian Norris
2018-11-16 21:15 ` Brian Norris
2019-02-04 16:42 ` Kalle Valo [this message]
2019-02-04 16:42 ` Kalle Valo
2019-02-04 22:54 ` Brian Norris
2019-02-04 22:54 ` Brian Norris
2019-02-05 4:49 ` Kalle Valo
2019-02-05 4:49 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204164254.BF5DD60721@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=briannorris@chromium.org \
--cc=govinds@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pillair@codeaurora.org \
--cc=stable@vger.kernel.org \
--cc=yyuwang@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.