From: Govind Singh <govinds@codeaurora.org>
To: Rajkumar Manoharan <rmanohar@codeaurora.org>
Cc: Yu Wang <yyuwang@codeaurora.org>,
linux-wireless-owner@vger.kernel.org,
Brian Norris <briannorris@chromium.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
ath10k@lists.infradead.org,
Rakesh Pillai <pillair@codeaurora.org>,
stable@vger.kernel.org
Subject: Re: [PATCH REGRESSION] Revert "ath10k: add quiet mode support for QCA6174/QCA9377"
Date: Thu, 08 Nov 2018 10:01:51 +0530 [thread overview]
Message-ID: <b1a64bd66fa25f274af8c018c6fc02f4@codeaurora.org> (raw)
In-Reply-To: <7f2ef494f4a2aba1845a157da8fec449@codeaurora.org>
On 2018-11-08 03:00, Rajkumar Manoharan wrote:
> On 2018-11-07 10:56, Brian Norris wrote:
>> This reverts commit cfb353c0dc058bc1619cc226d3cbbda1f360bdd3.
>>
>> WCN3990 firmware does not yet implement this feature, and so it
>> crashes
>> like this:
>>
>> fatal error received: err_qdi.c:456:EX:wlan_process:1:WLAN
>> RT:207a:PC=b001b4f0
>>
>> This feature can be re-implemented with a proper service bitmap or
>> other
>> feature-discovery mechanism in the future. But it should not break
>> working boards.
>>
> Brian,
>
> The change "ath10k: add quiet mode support for QCA6174/QCA9377" was
> merged even
> before full WCN3990 device support was added in ath10k. How come it
> could be regression
> for WCN3990. I know both are sharing same WMI-TLV interface but
> reverting this
> will break QCA6174/QCA9377. no?
>
This regression is found while we switched from 4.18 + WCN3990
back-ports to 4.19.
> I would prefer to handle this within WMI callback or upper layer.
>
IMO, we should use (WMI_SERVICE_THERMAL_MGMT | WMI_SERVICE_THERM_THROT )
service bitmap check and call
ath10k_thermal_set_throttling only if fw supports THERMAL THROTTLE
feature. But we need to ensure all
available ath10k fw's are reporting this service.
> -Rajkumar
BR,
Govind
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Govind Singh <govinds@codeaurora.org>
To: Rajkumar Manoharan <rmanohar@codeaurora.org>
Cc: Brian Norris <briannorris@chromium.org>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, Yu Wang <yyuwang@codeaurora.org>,
Rakesh Pillai <pillair@codeaurora.org>,
stable@vger.kernel.org, linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH REGRESSION] Revert "ath10k: add quiet mode support for QCA6174/QCA9377"
Date: Thu, 08 Nov 2018 10:01:51 +0530 [thread overview]
Message-ID: <b1a64bd66fa25f274af8c018c6fc02f4@codeaurora.org> (raw)
In-Reply-To: <7f2ef494f4a2aba1845a157da8fec449@codeaurora.org>
On 2018-11-08 03:00, Rajkumar Manoharan wrote:
> On 2018-11-07 10:56, Brian Norris wrote:
>> This reverts commit cfb353c0dc058bc1619cc226d3cbbda1f360bdd3.
>>
>> WCN3990 firmware does not yet implement this feature, and so it
>> crashes
>> like this:
>>
>> fatal error received: err_qdi.c:456:EX:wlan_process:1:WLAN
>> RT:207a:PC=b001b4f0
>>
>> This feature can be re-implemented with a proper service bitmap or
>> other
>> feature-discovery mechanism in the future. But it should not break
>> working boards.
>>
> Brian,
>
> The change "ath10k: add quiet mode support for QCA6174/QCA9377" was
> merged even
> before full WCN3990 device support was added in ath10k. How come it
> could be regression
> for WCN3990. I know both are sharing same WMI-TLV interface but
> reverting this
> will break QCA6174/QCA9377. no?
>
This regression is found while we switched from 4.18 + WCN3990
back-ports to 4.19.
> I would prefer to handle this within WMI callback or upper layer.
>
IMO, we should use (WMI_SERVICE_THERMAL_MGMT | WMI_SERVICE_THERM_THROT )
service bitmap check and call
ath10k_thermal_set_throttling only if fw supports THERMAL THROTTLE
feature. But we need to ensure all
available ath10k fw's are reporting this service.
> -Rajkumar
BR,
Govind
next prev parent reply other threads:[~2018-11-08 4:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 18:56 [PATCH REGRESSION] Revert "ath10k: add quiet mode support for QCA6174/QCA9377" Brian Norris
2018-11-07 18:56 ` Brian Norris
2018-11-07 21:30 ` Rajkumar Manoharan
2018-11-07 21:30 ` Rajkumar Manoharan
2018-11-08 4:31 ` Govind Singh [this message]
2018-11-08 4:31 ` Govind Singh
2018-11-08 17:30 ` Brian Norris
2018-11-08 17:30 ` Brian Norris
2018-11-08 19:52 ` Rajkumar Manoharan
2018-11-08 19:52 ` Rajkumar Manoharan
2018-11-16 10:14 ` Kalle Valo
2018-11-16 10:14 ` Kalle Valo
2018-11-16 21:15 ` Brian Norris
2018-11-16 21:15 ` Brian Norris
2019-02-04 16:42 ` Kalle Valo
2019-02-04 16:42 ` Kalle Valo
2019-02-04 22:54 ` Brian Norris
2019-02-04 22:54 ` Brian Norris
2019-02-05 4:49 ` Kalle Valo
2019-02-05 4:49 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1a64bd66fa25f274af8c018c6fc02f4@codeaurora.org \
--to=govinds@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=briannorris@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless-owner@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pillair@codeaurora.org \
--cc=rmanohar@codeaurora.org \
--cc=stable@vger.kernel.org \
--cc=yyuwang@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.