All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@mellanox.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Jakub Kicinski <jakub.kicinski@netronome.com>,
	John Hurley <john.hurley@netronome.com>,
	"open list:NETRONOME ETHERNET DRIVERS"
	<oss-drivers@netronome.com>, Eric Dumazet <edumazet@google.com>,
	Ioana Ciornei <ioana.ciornei@nxp.com>,
	Tyler Hicks <tyhicks@canonical.com>,
	Ivan Vecera <ivecera@redhat.com>, David Ahern <dsahern@gmail.com>,
	Ioana Radulescu <ruxandra.radulescu@nxp.com>,
	"open list:MELLANOX MLX5 core VPI driver"
	<linux-rdma@vger.kernel.org>,
	"moderated list:ETHERNET BRIDGE"
	<bridge@lists.linux-foundation.org>,
	Amritha Nambiar <amritha.nambiar@intel.com>,
	Saeed Mahameed <saeedm@mellanox.com>,
	Dirk van der Merwe <dirk.vandermerwe@netronome.com>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Alexander Duyck <alexander.h.duyck@intel.com>,
	"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
	Simon Horman <simon.horman@netronome.com>,
	Roopa Prabhu <roopa@cumulusnetworks.com>,
	Satanand Burla <sburla@marvell.com>,
	Felix Manlunas <fmanlunas@marvell.com>,
	Jiri Pirko <jiri@mellanox.com>,
	Kirill Tkhai <ktkhai@virtuozzo.com>,
	Edwin Peer <edwin.peer@netronome.com>,
	Michael Chan <michael.chan@broadcom.com>,
	Christian Brauner <christian@brauner.io>,
	Leon Romanovsky <leon@kernel.org>,
	Nic Viljoen <nick.viljoen@netronome.com>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	open list <linux-kernel@vger.kernel.org>,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Joe Perches <joe@perches.com>,
	Derek Chickles <dchickles@marvell.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH 00/12] net: Introduce ndo_get_port_parent_id()
Date: Tue, 5 Feb 2019 07:14:48 +0000	[thread overview]
Message-ID: <20190205071445.GA7480@splinter> (raw)
In-Reply-To: <20190204233633.20421-1-f.fainelli@gmail.com>

On Mon, Feb 04, 2019 at 03:36:21PM -0800, Florian Fainelli wrote:
> Hi all,
> 
> Based on discussion with Ido and feedback from Jakub there are clearly
> two classes of users that implement SWITCHDEV_ATTR_ID_PORT_PARENT_ID:
> 
> - PF/VF drivers which typically only implement return the port's parent
>   ID, yet have to implement switchdev_port_attr_get() just for that
> 
> - Ethernet switch drivers: mlxsw, ocelot, DSA, etc. which implement more
>   attributes which we want to be able to eventually veto in the context
>   of the caller, thus making them candidates for using a blocking notifier
>   chain

Florian, thanks for working on this.

I think you're missing implementation over stacked devices. At least
8021q, bond and team need to implement this ndo as well. For bond and
team we can return an error if not all the slaves have the same parent
ID. It would be consistent with what switchdev_port_attr_get() is doing.

WARNING: multiple messages have this Message-ID (diff)
From: Ido Schimmel <idosch@mellanox.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Jakub Kicinski <jakub.kicinski@netronome.com>,
	John Hurley <john.hurley@netronome.com>,
	"open list:NETRONOME ETHERNET DRIVERS"
	<oss-drivers@netronome.com>, Eric Dumazet <edumazet@google.com>,
	Ioana Ciornei <ioana.ciornei@nxp.com>,
	Tyler Hicks <tyhicks@canonical.com>,
	Ivan Vecera <ivecera@redhat.com>, David Ahern <dsahern@gmail.com>,
	Ioana Radulescu <ruxandra.radulescu@nxp.com>,
	"open list:MELLANOX MLX5 core VPI driver"
	<linux-rdma@vger.kernel.org>,
	"moderated list:ETHERNET BRIDGE"
	<bridge@lists.linux-foundation.org>,
	Amritha Nambiar <amritha.nambiar@intel.com>,
	Saeed Mahameed <saeedm@mellanox.com>,
	Dirk van der Merwe <dirk.vandermerwe@netronome.com>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Alexander Duyck <alexander.h.duyck@intel.com>open li
Subject: Re: [PATCH 00/12] net: Introduce ndo_get_port_parent_id()
Date: Tue, 5 Feb 2019 07:14:48 +0000	[thread overview]
Message-ID: <20190205071445.GA7480@splinter> (raw)
In-Reply-To: <20190204233633.20421-1-f.fainelli@gmail.com>

On Mon, Feb 04, 2019 at 03:36:21PM -0800, Florian Fainelli wrote:
> Hi all,
> 
> Based on discussion with Ido and feedback from Jakub there are clearly
> two classes of users that implement SWITCHDEV_ATTR_ID_PORT_PARENT_ID:
> 
> - PF/VF drivers which typically only implement return the port's parent
>   ID, yet have to implement switchdev_port_attr_get() just for that
> 
> - Ethernet switch drivers: mlxsw, ocelot, DSA, etc. which implement more
>   attributes which we want to be able to eventually veto in the context
>   of the caller, thus making them candidates for using a blocking notifier
>   chain

Florian, thanks for working on this.

I think you're missing implementation over stacked devices. At least
8021q, bond and team need to implement this ndo as well. For bond and
team we can return an error if not all the slaves have the same parent
ID. It would be consistent with what switchdev_port_attr_get() is doing.

  parent reply	other threads:[~2019-02-05  7:14 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-04 23:36 [Bridge] [PATCH 00/12] net: Introduce ndo_get_port_parent_id() Florian Fainelli
2019-02-04 23:36 ` Florian Fainelli
2019-02-04 23:36 ` [Bridge] [PATCH 01/12] " Florian Fainelli
2019-02-04 23:36   ` Florian Fainelli
2019-02-04 23:36 ` [Bridge] [PATCH 02/12] bnxt: Implement ndo_get_port_parent_id() Florian Fainelli
2019-02-04 23:36   ` Florian Fainelli
2019-02-05  9:48   ` kbuild test robot
2019-02-05 13:24   ` kbuild test robot
2019-02-04 23:36 ` [Bridge] [PATCH 03/12] liquidio: " Florian Fainelli
2019-02-04 23:36   ` Florian Fainelli
2019-02-04 23:36 ` [Bridge] [PATCH 04/12] net/mlx5e: " Florian Fainelli
2019-02-04 23:36   ` Florian Fainelli
2019-02-04 23:36 ` [Bridge] [PATCH 05/12] mlxsw: " Florian Fainelli
2019-02-04 23:36   ` Florian Fainelli
2019-02-04 23:36 ` [Bridge] [PATCH 06/12] mscc: ocelot: " Florian Fainelli
2019-02-04 23:36   ` Florian Fainelli
2019-02-04 23:36 ` [Bridge] [PATCH 07/12] nfp: " Florian Fainelli
2019-02-04 23:36   ` Florian Fainelli
2019-02-05  3:49   ` [Bridge] " Jakub Kicinski
2019-02-05  3:49     ` Jakub Kicinski
2019-02-04 23:36 ` [Bridge] [PATCH 08/12] rocker: " Florian Fainelli
2019-02-04 23:36   ` Florian Fainelli
2019-02-04 23:36 ` [Bridge] [PATCH 09/12] netdevsim: " Florian Fainelli
2019-02-04 23:36   ` Florian Fainelli
2019-02-05  3:51   ` [Bridge] " Jakub Kicinski
2019-02-05  3:51     ` Jakub Kicinski
2019-02-05  9:23   ` kbuild test robot
2019-02-05  9:30   ` kbuild test robot
2019-02-04 23:36 ` [Bridge] [PATCH 10/12] staging: fsl-dpaa2: ethsw: " Florian Fainelli
2019-02-04 23:36   ` Florian Fainelli
2019-02-04 23:36 ` [Bridge] [PATCH 11/12] net: dsa: " Florian Fainelli
2019-02-04 23:36   ` Florian Fainelli
2019-02-04 23:36 ` [Bridge] [PATCH 12/12] net: Get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID Florian Fainelli
2019-02-04 23:36   ` Florian Fainelli
2019-02-05  7:47   ` [Bridge] " Ido Schimmel
2019-02-05  7:47     ` Ido Schimmel
2019-02-05  9:23   ` kbuild test robot
2019-02-05 11:17   ` kbuild test robot
2019-02-05  2:24 ` [PATCH 00/12] net: Introduce ndo_get_port_parent_id() David Miller
2019-02-05  7:14 ` Ido Schimmel [this message]
2019-02-05  7:14   ` Ido Schimmel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190205071445.GA7480@splinter \
    --to=idosch@mellanox.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=amritha.nambiar@intel.com \
    --cc=andrew@lunn.ch \
    --cc=bridge@lists.linux-foundation.org \
    --cc=christian@brauner.io \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dchickles@marvell.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dirk.vandermerwe@netronome.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dsahern@gmail.com \
    --cc=edumazet@google.com \
    --cc=edwin.peer@netronome.com \
    --cc=f.fainelli@gmail.com \
    --cc=fmanlunas@marvell.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ioana.ciornei@nxp.com \
    --cc=ivecera@redhat.com \
    --cc=jakub.kicinski@netronome.com \
    --cc=jiri@mellanox.com \
    --cc=joe@perches.com \
    --cc=john.hurley@netronome.com \
    --cc=ktkhai@virtuozzo.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=nick.viljoen@netronome.com \
    --cc=nikolay@cumulusnetworks.com \
    --cc=oss-drivers@netronome.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=ruxandra.radulescu@nxp.com \
    --cc=saeedm@mellanox.com \
    --cc=sburla@marvell.com \
    --cc=simon.horman@netronome.com \
    --cc=tyhicks@canonical.com \
    --cc=vivien.didelot@gmail.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.