From: Dan Carpenter <dan.carpenter@oracle.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] dlm: Fix test for -ERESTARTSYS
Date: Tue, 5 Feb 2019 12:07:18 +0300 [thread overview]
Message-ID: <20190205090718.GA20043@kadam> (raw)
The minus sign is missing so this condition is never true.
Fixes: 5c1597bfeb2c ("dlm: retry wait_event_interruptible in event of ERESTARTSYS")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Static analysis. Not tested.
fs/dlm/lockspace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/dlm/lockspace.c b/fs/dlm/lockspace.c
index 7aae23afdd3a..738136a762d4 100644
--- a/fs/dlm/lockspace.c
+++ b/fs/dlm/lockspace.c
@@ -213,7 +213,7 @@ static int do_uevent(struct dlm_ls *ls, int in)
do {
error = wait_event_interruptible(ls->ls_uevent_wait,
test_and_clear_bit(LSFL_UEVENT_WAIT, &ls->ls_flags));
- } while (error == ERESTARTSYS);
+ } while (error == -ERESTARTSYS);
log_rinfo(ls, "group event done %d %d", error, ls->ls_uevent_result);
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [PATCH] dlm: Fix test for -ERESTARTSYS
Date: Tue, 05 Feb 2019 09:07:18 +0000 [thread overview]
Message-ID: <20190205090718.GA20043@kadam> (raw)
The minus sign is missing so this condition is never true.
Fixes: 5c1597bfeb2c ("dlm: retry wait_event_interruptible in event of ERESTARTSYS")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Static analysis. Not tested.
fs/dlm/lockspace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/dlm/lockspace.c b/fs/dlm/lockspace.c
index 7aae23afdd3a..738136a762d4 100644
--- a/fs/dlm/lockspace.c
+++ b/fs/dlm/lockspace.c
@@ -213,7 +213,7 @@ static int do_uevent(struct dlm_ls *ls, int in)
do {
error = wait_event_interruptible(ls->ls_uevent_wait,
test_and_clear_bit(LSFL_UEVENT_WAIT, &ls->ls_flags));
- } while (error = ERESTARTSYS);
+ } while (error = -ERESTARTSYS);
log_rinfo(ls, "group event done %d %d", error, ls->ls_uevent_result);
--
2.17.1
next reply other threads:[~2019-02-05 9:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 9:07 Dan Carpenter [this message]
2019-02-05 9:07 ` [PATCH] dlm: Fix test for -ERESTARTSYS Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190205090718.GA20043@kadam \
--to=dan.carpenter@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.