All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: wcd9335: remove some unnecessary NULL checks
@ 2019-02-05  9:09 ` Dan Carpenter
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2019-02-05  9:09 UTC (permalink / raw)
  To: Liam Girdwood, Srinivas Kandagatla
  Cc: alsa-devel, kernel-janitors, Takashi Iwai, Vinod Koul, Mark Brown

These are arrays, not pointers, and they can't be NULL.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 sound/soc/codecs/wcd9335.c | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c
index 3878187bb512..981f88a5f615 100644
--- a/sound/soc/codecs/wcd9335.c
+++ b/sound/soc/codecs/wcd9335.c
@@ -2001,20 +2001,16 @@ static int wcd9335_set_channel_map(struct snd_soc_dai *dai,
 		return -EINVAL;
 	}
 
-	if (wcd->rx_chs) {
-		wcd->num_rx_port = rx_num;
-		for (i = 0; i < rx_num; i++) {
-			wcd->rx_chs[i].ch_num = rx_slot[i];
-			INIT_LIST_HEAD(&wcd->rx_chs[i].list);
-		}
+	wcd->num_rx_port = rx_num;
+	for (i = 0; i < rx_num; i++) {
+		wcd->rx_chs[i].ch_num = rx_slot[i];
+		INIT_LIST_HEAD(&wcd->rx_chs[i].list);
 	}
 
-	if (wcd->tx_chs) {
-		wcd->num_tx_port = tx_num;
-		for (i = 0; i < tx_num; i++) {
-			wcd->tx_chs[i].ch_num = tx_slot[i];
-			INIT_LIST_HEAD(&wcd->tx_chs[i].list);
-		}
+	wcd->num_tx_port = tx_num;
+	for (i = 0; i < tx_num; i++) {
+		wcd->tx_chs[i].ch_num = tx_slot[i];
+		INIT_LIST_HEAD(&wcd->tx_chs[i].list);
 	}
 
 	return 0;
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] ASoC: wcd9335: remove some unnecessary NULL checks
@ 2019-02-05  9:09 ` Dan Carpenter
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2019-02-05  9:09 UTC (permalink / raw)
  To: Liam Girdwood, Srinivas Kandagatla
  Cc: alsa-devel, kernel-janitors, Takashi Iwai, Vinod Koul, Mark Brown

These are arrays, not pointers, and they can't be NULL.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 sound/soc/codecs/wcd9335.c | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c
index 3878187bb512..981f88a5f615 100644
--- a/sound/soc/codecs/wcd9335.c
+++ b/sound/soc/codecs/wcd9335.c
@@ -2001,20 +2001,16 @@ static int wcd9335_set_channel_map(struct snd_soc_dai *dai,
 		return -EINVAL;
 	}
 
-	if (wcd->rx_chs) {
-		wcd->num_rx_port = rx_num;
-		for (i = 0; i < rx_num; i++) {
-			wcd->rx_chs[i].ch_num = rx_slot[i];
-			INIT_LIST_HEAD(&wcd->rx_chs[i].list);
-		}
+	wcd->num_rx_port = rx_num;
+	for (i = 0; i < rx_num; i++) {
+		wcd->rx_chs[i].ch_num = rx_slot[i];
+		INIT_LIST_HEAD(&wcd->rx_chs[i].list);
 	}
 
-	if (wcd->tx_chs) {
-		wcd->num_tx_port = tx_num;
-		for (i = 0; i < tx_num; i++) {
-			wcd->tx_chs[i].ch_num = tx_slot[i];
-			INIT_LIST_HEAD(&wcd->tx_chs[i].list);
-		}
+	wcd->num_tx_port = tx_num;
+	for (i = 0; i < tx_num; i++) {
+		wcd->tx_chs[i].ch_num = tx_slot[i];
+		INIT_LIST_HEAD(&wcd->tx_chs[i].list);
 	}
 
 	return 0;
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: wcd9335: remove some unnecessary NULL checks
  2019-02-05  9:09 ` Dan Carpenter
@ 2019-02-05  9:58   ` Srinivas Kandagatla
  -1 siblings, 0 replies; 4+ messages in thread
From: Srinivas Kandagatla @ 2019-02-05  9:58 UTC (permalink / raw)
  To: Dan Carpenter, Liam Girdwood
  Cc: alsa-devel, kernel-janitors, Takashi Iwai, Vinod Koul, Mark Brown



On 05/02/2019 09:09, Dan Carpenter wrote:
> These are arrays, not pointers, and they can't be NULL.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks Dan,

There is already a patch on list to fix this:
https://patchwork.kernel.org/patch/10787281/

thanks,
srini

> ---
>   sound/soc/codecs/wcd9335.c | 20 ++++++++------------
>   1 file changed, 8 insertions(+), 12 deletions(-)
> 
> diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c
> index 3878187bb512..981f88a5f615 100644
> --- a/sound/soc/codecs/wcd9335.c
> +++ b/sound/soc/codecs/wcd9335.c
> @@ -2001,20 +2001,16 @@ static int wcd9335_set_channel_map(struct snd_soc_dai *dai,
>   		return -EINVAL;
>   	}
>   
> -	if (wcd->rx_chs) {
> -		wcd->num_rx_port = rx_num;
> -		for (i = 0; i < rx_num; i++) {
> -			wcd->rx_chs[i].ch_num = rx_slot[i];
> -			INIT_LIST_HEAD(&wcd->rx_chs[i].list);
> -		}
> +	wcd->num_rx_port = rx_num;
> +	for (i = 0; i < rx_num; i++) {
> +		wcd->rx_chs[i].ch_num = rx_slot[i];
> +		INIT_LIST_HEAD(&wcd->rx_chs[i].list);
>   	}
>   
> -	if (wcd->tx_chs) {
> -		wcd->num_tx_port = tx_num;
> -		for (i = 0; i < tx_num; i++) {
> -			wcd->tx_chs[i].ch_num = tx_slot[i];
> -			INIT_LIST_HEAD(&wcd->tx_chs[i].list);
> -		}
> +	wcd->num_tx_port = tx_num;
> +	for (i = 0; i < tx_num; i++) {
> +		wcd->tx_chs[i].ch_num = tx_slot[i];
> +		INIT_LIST_HEAD(&wcd->tx_chs[i].list);
>   	}
>   
>   	return 0;
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: wcd9335: remove some unnecessary NULL checks
@ 2019-02-05  9:58   ` Srinivas Kandagatla
  0 siblings, 0 replies; 4+ messages in thread
From: Srinivas Kandagatla @ 2019-02-05  9:58 UTC (permalink / raw)
  To: Dan Carpenter, Liam Girdwood
  Cc: alsa-devel, kernel-janitors, Takashi Iwai, Vinod Koul, Mark Brown



On 05/02/2019 09:09, Dan Carpenter wrote:
> These are arrays, not pointers, and they can't be NULL.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks Dan,

There is already a patch on list to fix this:
https://patchwork.kernel.org/patch/10787281/

thanks,
srini

> ---
>   sound/soc/codecs/wcd9335.c | 20 ++++++++------------
>   1 file changed, 8 insertions(+), 12 deletions(-)
> 
> diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c
> index 3878187bb512..981f88a5f615 100644
> --- a/sound/soc/codecs/wcd9335.c
> +++ b/sound/soc/codecs/wcd9335.c
> @@ -2001,20 +2001,16 @@ static int wcd9335_set_channel_map(struct snd_soc_dai *dai,
>   		return -EINVAL;
>   	}
>   
> -	if (wcd->rx_chs) {
> -		wcd->num_rx_port = rx_num;
> -		for (i = 0; i < rx_num; i++) {
> -			wcd->rx_chs[i].ch_num = rx_slot[i];
> -			INIT_LIST_HEAD(&wcd->rx_chs[i].list);
> -		}
> +	wcd->num_rx_port = rx_num;
> +	for (i = 0; i < rx_num; i++) {
> +		wcd->rx_chs[i].ch_num = rx_slot[i];
> +		INIT_LIST_HEAD(&wcd->rx_chs[i].list);
>   	}
>   
> -	if (wcd->tx_chs) {
> -		wcd->num_tx_port = tx_num;
> -		for (i = 0; i < tx_num; i++) {
> -			wcd->tx_chs[i].ch_num = tx_slot[i];
> -			INIT_LIST_HEAD(&wcd->tx_chs[i].list);
> -		}
> +	wcd->num_tx_port = tx_num;
> +	for (i = 0; i < tx_num; i++) {
> +		wcd->tx_chs[i].ch_num = tx_slot[i];
> +		INIT_LIST_HEAD(&wcd->tx_chs[i].list);
>   	}
>   
>   	return 0;
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-05  9:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-05  9:09 [PATCH] ASoC: wcd9335: remove some unnecessary NULL checks Dan Carpenter
2019-02-05  9:09 ` Dan Carpenter
2019-02-05  9:58 ` Srinivas Kandagatla
2019-02-05  9:58   ` Srinivas Kandagatla

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.