From: Boris Brezillon <boris.brezillon@collabora.com>
To: <Tudor.Ambarus@microchip.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org,
Cyrille.Pitchen@microchip.com, Nicolas.Ferre@microchip.com,
robh+dt@kernel.org, linux-spi@vger.kernel.org,
Ludovic.Desroches@microchip.com, broonie@kernel.org,
linux-mtd@lists.infradead.org, bugalski.piotr@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 13/13] spi: atmel-quadspi: add support for sam9x60 qspi controller
Date: Tue, 5 Feb 2019 17:26:38 +0100 [thread overview]
Message-ID: <20190205172638.11a69968@collabora.com> (raw)
In-Reply-To: <20190205154257.29529-14-tudor.ambarus@microchip.com>
On Tue, 5 Feb 2019 15:44:04 +0000
<Tudor.Ambarus@microchip.com> wrote:
> @@ -450,28 +499,49 @@ static int atmel_qspi_probe(struct
> platform_device *pdev) goto exit;
> }
>
> + aq->caps = of_device_get_match_data(&pdev->dev);
> + if (aq->caps && aq->caps->has_qspick) {
Can we add a caps instance to the sama5d2 entry instead of allowing
caps to be NULL?
The rest looks good to me, feel free to add
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
on your next version.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: <Tudor.Ambarus@microchip.com>
Cc: <broonie@kernel.org>, <robh+dt@kernel.org>,
<mark.rutland@arm.com>, <Nicolas.Ferre@microchip.com>,
<alexandre.belloni@bootlin.com>,
<Ludovic.Desroches@microchip.com>,
<Cyrille.Pitchen@microchip.com>, <bugalski.piotr@gmail.com>,
<linux-spi@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH v5 13/13] spi: atmel-quadspi: add support for sam9x60 qspi controller
Date: Tue, 5 Feb 2019 17:26:38 +0100 [thread overview]
Message-ID: <20190205172638.11a69968@collabora.com> (raw)
In-Reply-To: <20190205154257.29529-14-tudor.ambarus@microchip.com>
On Tue, 5 Feb 2019 15:44:04 +0000
<Tudor.Ambarus@microchip.com> wrote:
> @@ -450,28 +499,49 @@ static int atmel_qspi_probe(struct
> platform_device *pdev) goto exit;
> }
>
> + aq->caps = of_device_get_match_data(&pdev->dev);
> + if (aq->caps && aq->caps->has_qspick) {
Can we add a caps instance to the sama5d2 entry instead of allowing
caps to be NULL?
The rest looks good to me, feel free to add
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
on your next version.
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: <Tudor.Ambarus@microchip.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org,
Cyrille.Pitchen@microchip.com, robh+dt@kernel.org,
linux-spi@vger.kernel.org, Ludovic.Desroches@microchip.com,
broonie@kernel.org, linux-mtd@lists.infradead.org,
bugalski.piotr@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 13/13] spi: atmel-quadspi: add support for sam9x60 qspi controller
Date: Tue, 5 Feb 2019 17:26:38 +0100 [thread overview]
Message-ID: <20190205172638.11a69968@collabora.com> (raw)
In-Reply-To: <20190205154257.29529-14-tudor.ambarus@microchip.com>
On Tue, 5 Feb 2019 15:44:04 +0000
<Tudor.Ambarus@microchip.com> wrote:
> @@ -450,28 +499,49 @@ static int atmel_qspi_probe(struct
> platform_device *pdev) goto exit;
> }
>
> + aq->caps = of_device_get_match_data(&pdev->dev);
> + if (aq->caps && aq->caps->has_qspick) {
Can we add a caps instance to the sama5d2 entry instead of allowing
caps to be NULL?
The rest looks good to me, feel free to add
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
on your next version.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Tudor.Ambarus@microchip.com
Cc: broonie@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com,
Ludovic.Desroches@microchip.com, Cyrille.Pitchen@microchip.com,
bugalski.piotr@gmail.com, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH v5 13/13] spi: atmel-quadspi: add support for sam9x60 qspi controller
Date: Tue, 5 Feb 2019 17:26:38 +0100 [thread overview]
Message-ID: <20190205172638.11a69968@collabora.com> (raw)
In-Reply-To: <20190205154257.29529-14-tudor.ambarus@microchip.com>
On Tue, 5 Feb 2019 15:44:04 +0000
<Tudor.Ambarus@microchip.com> wrote:
> @@ -450,28 +499,49 @@ static int atmel_qspi_probe(struct
> platform_device *pdev) goto exit;
> }
>
> + aq->caps = of_device_get_match_data(&pdev->dev);
> + if (aq->caps && aq->caps->has_qspick) {
Can we add a caps instance to the sama5d2 entry instead of allowing
caps to be NULL?
The rest looks good to me, feel free to add
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
on your next version.
next prev parent reply other threads:[~2019-02-05 16:27 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 15:43 [PATCH v5 00/13] spi: atmel-quadspi: introduce sam9x60 qspi controller Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` [PATCH v5 01/13] spi: atmel-quadspi: cache MR value to avoid a write access Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` [PATCH v5 02/13] spi: atmel-quadspi: order header files inclusion alphabetically Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` [PATCH v5 03/13] spi: atmel-quadspi: drop wrappers for iomem accesses Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` [PATCH v5 04/13] spi: atmel-quadspi: fix naming scheme Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` [PATCH v5 05/13] spi: atmel-quadspi: remove unnecessary cast Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` [PATCH v5 06/13] spi: atmel-quadspi: return appropriate error code Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` [PATCH v5 07/13] spi: atmel-quadspi: switch to SPDX license identifiers Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` [PATCH v5 08/13] spi: atmel-quadspi: rework transfer macros Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` [PATCH v5 09/13] dt-bindings: spi: atmel-quadspi: update example to new clock binding Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` [PATCH v5 10/13] dt-bindings: spi: atmel-quadspi: make "pclk" mandatory Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` [PATCH v5 11/13] spi: atmel-quadspi: add support for named peripheral clock Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:43 ` Tudor.Ambarus
2019-02-05 15:44 ` [PATCH v5 12/13] dt-bindings: spi: atmel-quadspi: QuadSPI driver for Microchip SAM9X60 Tudor.Ambarus
2019-02-05 15:44 ` Tudor.Ambarus
2019-02-05 15:44 ` Tudor.Ambarus
2019-02-05 15:44 ` Tudor.Ambarus
2019-02-05 15:44 ` [PATCH v5 13/13] spi: atmel-quadspi: add support for sam9x60 qspi controller Tudor.Ambarus
2019-02-05 15:44 ` Tudor.Ambarus
2019-02-05 15:44 ` Tudor.Ambarus
2019-02-05 15:44 ` Tudor.Ambarus
2019-02-05 16:26 ` Boris Brezillon [this message]
2019-02-05 16:26 ` Boris Brezillon
2019-02-05 16:26 ` Boris Brezillon
2019-02-05 16:26 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190205172638.11a69968@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=Cyrille.Pitchen@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=bugalski.piotr@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.