From: Thierry Reding <thierry.reding@gmail.com>
To: Yash Shah <yash.shah@sifive.com>
Cc: palmer@sifive.com, linux-pwm@vger.kernel.org,
linux-riscv@lists.infradead.org, robh+dt@kernel.org,
mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, sachin.ghadi@sifive.com,
paul.walmsley@sifive.com
Subject: Re: [PATCH v5 2/2] pwm: sifive: Add a driver for SiFive SoC PWM
Date: Wed, 6 Feb 2019 13:44:42 +0100 [thread overview]
Message-ID: <20190206124442.GG21676@ulmo> (raw)
In-Reply-To: <1548762199-7065-3-git-send-email-yash.shah@sifive.com>
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
On Tue, Jan 29, 2019 at 05:13:19PM +0530, Yash Shah wrote:
[...]
> diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c
[...]
> +static void pwm_sifive_update_clock(struct pwm_sifive_ddata *pwm,
> + unsigned long rate)
> +{
> + /* (1 << (16+scale)) * 10^9/rate = real_period */
> + unsigned long scale_pow =
> + (pwm->approx_period * (u64)rate) / NSEC_PER_SEC;
I think you need another div64_ul() for this one to fix the linker error
that the 0-day builder was pointing out.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Yash Shah <yash.shah@sifive.com>
Cc: mark.rutland@arm.com, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, palmer@sifive.com,
linux-kernel@vger.kernel.org, sachin.ghadi@sifive.com,
robh+dt@kernel.org, paul.walmsley@sifive.com,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v5 2/2] pwm: sifive: Add a driver for SiFive SoC PWM
Date: Wed, 6 Feb 2019 13:44:42 +0100 [thread overview]
Message-ID: <20190206124442.GG21676@ulmo> (raw)
In-Reply-To: <1548762199-7065-3-git-send-email-yash.shah@sifive.com>
[-- Attachment #1.1: Type: text/plain, Size: 506 bytes --]
On Tue, Jan 29, 2019 at 05:13:19PM +0530, Yash Shah wrote:
[...]
> diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c
[...]
> +static void pwm_sifive_update_clock(struct pwm_sifive_ddata *pwm,
> + unsigned long rate)
> +{
> + /* (1 << (16+scale)) * 10^9/rate = real_period */
> + unsigned long scale_pow =
> + (pwm->approx_period * (u64)rate) / NSEC_PER_SEC;
I think you need another div64_ul() for this one to fix the linker error
that the 0-day builder was pointing out.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-02-06 12:44 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 11:43 [PATCH v5 0/2] PWM support for HiFive Unleashed Yash Shah
2019-01-29 11:43 ` Yash Shah
2019-01-29 11:43 ` Yash Shah
2019-01-29 11:43 ` [PATCH v5 1/2] pwm: sifive: Add DT documentation for SiFive PWM Controller Yash Shah
2019-01-29 11:43 ` Yash Shah
2019-01-30 8:14 ` Uwe Kleine-König
2019-01-30 8:14 ` Uwe Kleine-König
2019-02-06 10:48 ` Yash Shah
2019-02-06 10:48 ` Yash Shah
2019-02-06 11:07 ` Uwe Kleine-König
2019-02-06 11:07 ` Uwe Kleine-König
2019-02-06 11:07 ` Uwe Kleine-König
2019-02-06 12:40 ` Thierry Reding
2019-02-06 12:40 ` Thierry Reding
2019-02-06 15:38 ` Uwe Kleine-König
2019-02-06 15:38 ` Uwe Kleine-König
2019-02-06 16:16 ` Thierry Reding
2019-02-06 16:16 ` Thierry Reding
2019-02-06 16:35 ` Uwe Kleine-König
2019-02-06 16:35 ` Uwe Kleine-König
2019-01-29 11:43 ` [PATCH v5 2/2] pwm: sifive: Add a driver for SiFive SoC PWM Yash Shah
2019-01-29 11:43 ` Yash Shah
2019-01-29 11:43 ` Yash Shah
2019-02-05 8:21 ` kbuild test robot
2019-02-05 8:21 ` kbuild test robot
2019-02-05 8:21 ` kbuild test robot
2019-02-05 17:25 ` kbuild test robot
2019-02-05 17:25 ` kbuild test robot
2019-02-05 17:25 ` kbuild test robot
2019-02-06 12:44 ` Thierry Reding [this message]
2019-02-06 12:44 ` Thierry Reding
2019-02-07 8:24 ` Yash Shah
2019-02-07 8:24 ` Yash Shah
2019-02-07 8:24 ` Yash Shah
2019-02-07 10:16 ` Uwe Kleine-König
2019-02-07 10:16 ` Uwe Kleine-König
2019-02-11 11:26 ` Yash Shah
2019-02-11 11:26 ` Yash Shah
2019-02-11 12:29 ` Uwe Kleine-König
2019-02-11 12:29 ` Uwe Kleine-König
2019-02-13 12:34 ` Thierry Reding
2019-02-13 12:34 ` Thierry Reding
2019-02-13 17:39 ` Uwe Kleine-König
2019-02-13 17:39 ` Uwe Kleine-König
2019-02-13 17:39 ` Uwe Kleine-König
2019-02-13 12:37 ` Thierry Reding
2019-02-13 12:37 ` Thierry Reding
2019-02-14 15:59 ` Uwe Kleine-König
2019-02-14 15:59 ` Uwe Kleine-König
2019-02-14 15:59 ` Uwe Kleine-König
2019-03-12 7:27 ` Uwe Kleine-König
2019-03-12 7:27 ` Uwe Kleine-König
2019-03-12 7:27 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206124442.GG21676@ulmo \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sachin.ghadi@sifive.com \
--cc=yash.shah@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.