From: Thierry Reding <thierry.reding@gmail.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: jckuo <jckuo@nvidia.com>, Jonathan Hunter <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] phy: tegra: xusb: Add support for power supplies
Date: Thu, 7 Feb 2019 12:11:46 +0100 [thread overview]
Message-ID: <20190207111146.GB18518@ulmo> (raw)
In-Reply-To: <7838bb0d-af30-e2dc-8bfd-e1256590f9d3@ti.com>
[-- Attachment #1: Type: text/plain, Size: 925 bytes --]
On Tue, Feb 05, 2019 at 06:25:04PM +0530, Kishon Vijay Abraham I wrote:
> Hi,
>
> On 28/01/19 1:30 PM, Thierry Reding wrote:
> > On Mon, Jan 28, 2019 at 03:22:09PM +0800, jckuo wrote:
> >> Hi Thierry,
> >>
> >> I think any non-zero return value of
> >> regulator_bulk_enable()/devm_regulator_bulk_get() means error.
> >>
> >> Thanks,
> >>
> >> JC
> >
> > Theoretically I think only regulator_bulk_enable() could return a
> > positive value, but even so it never will in practice because all of the
> > regulator_enable() (see _regulator_enable()) calls will only ever return
> > negative error codes.
> >
> > I can change this and resend if you have strong concerns about this
> > possibly missing legitimate error cases.
>
> All error codes are negative, so this is fine IMO.
Hi Kishon,
did you have any other comments on this series? Anything keeping this
from going into v5.1?
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-02-07 11:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 11:25 [PATCH 1/5] dt-bindings: phy: tegra: Add Tegra186 support Thierry Reding
2019-01-25 11:25 ` [PATCH 2/5] phy: tegra: xusb: Skip single function lane programming Thierry Reding
2019-01-28 7:06 ` jckuo
2019-01-28 7:06 ` jckuo
2019-01-25 11:25 ` [PATCH 3/5] phy: tegra: xusb: Parse dual-role mode property Thierry Reding
2019-01-28 7:08 ` jckuo
2019-01-28 7:08 ` jckuo
2019-01-25 11:25 ` [PATCH 4/5] phy: tegra: xusb: Add support for power supplies Thierry Reding
2019-01-28 7:22 ` jckuo
2019-01-28 7:22 ` jckuo
2019-01-28 8:00 ` Thierry Reding
2019-01-29 6:50 ` jckuo
2019-01-29 6:50 ` jckuo
2019-02-05 12:55 ` Kishon Vijay Abraham I
2019-02-05 12:55 ` Kishon Vijay Abraham I
2019-02-07 11:11 ` Thierry Reding [this message]
2019-01-25 11:25 ` [PATCH 5/5] phy: tegra: xusb: Add Tegra186 support Thierry Reding
2019-01-28 7:45 ` jckuo
2019-01-28 7:45 ` jckuo
2019-02-07 11:47 ` Kishon Vijay Abraham I
2019-02-07 11:47 ` Kishon Vijay Abraham I
2019-02-07 12:17 ` Thierry Reding
2019-01-28 7:04 ` [PATCH 1/5] dt-bindings: phy: tegra: " jckuo
2019-01-28 7:04 ` jckuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207111146.GB18518@ulmo \
--to=thierry.reding@gmail.com \
--cc=jckuo@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.