All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm: tweak header name
Date: Fri, 8 Feb 2019 07:55:32 -0500	[thread overview]
Message-ID: <20190208075408-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20190208085659.GI23159@phenom.ffwll.local>

On Fri, Feb 08, 2019 at 09:56:59AM +0100, Daniel Vetter wrote:
> On Fri, Feb 08, 2019 at 01:02:58AM -0500, Michael S. Tsirkin wrote:
> > Use linux/mman.h to make sure we get all mmap flags we need.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> 
> drmP.h is seriously deprecated (and a monster mess). If this fixes
> anything, I think would be better to include the right header in the right
> places, and leave drmP.h to die quietly ...
> 
> What exactly does this fix?
> -Daniel

I don't know. I am moving flags from asm/mman.h and if there
are direct users which there should not be, some code
might break. Even if it's a bad header people copy
code around, so why leave wrong examples there?
What's the harm in being proactive?


> > ---
> >  include/drm/drmP.h | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/include/drm/drmP.h b/include/drm/drmP.h
> > index bdb0d5548f39..a3184416ddc5 100644
> > --- a/include/drm/drmP.h
> > +++ b/include/drm/drmP.h
> > @@ -57,8 +57,7 @@
> >  #include <linux/workqueue.h>
> >  #include <linux/dma-fence.h>
> >  #include <linux/module.h>
> > -
> > -#include <asm/mman.h>
> > +#include <linux/mman.h>
> >  #include <asm/pgalloc.h>
> >  #include <linux/uaccess.h>
> >  
> > -- 
> > MST
> > 
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm: tweak header name
Date: Fri, 8 Feb 2019 07:55:32 -0500	[thread overview]
Message-ID: <20190208075408-mutt-send-email-mst@kernel.org> (raw)
Message-ID: <20190208125532.fZzZsM6BD5mwZTOlZfuFd9zYjg6J1dgSDGGaVq5q8Z0@z> (raw)
In-Reply-To: <20190208085659.GI23159@phenom.ffwll.local>

On Fri, Feb 08, 2019 at 09:56:59AM +0100, Daniel Vetter wrote:
> On Fri, Feb 08, 2019 at 01:02:58AM -0500, Michael S. Tsirkin wrote:
> > Use linux/mman.h to make sure we get all mmap flags we need.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> 
> drmP.h is seriously deprecated (and a monster mess). If this fixes
> anything, I think would be better to include the right header in the right
> places, and leave drmP.h to die quietly ...
> 
> What exactly does this fix?
> -Daniel

I don't know. I am moving flags from asm/mman.h and if there
are direct users which there should not be, some code
might break. Even if it's a bad header people copy
code around, so why leave wrong examples there?
What's the harm in being proactive?


> > ---
> >  include/drm/drmP.h | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/include/drm/drmP.h b/include/drm/drmP.h
> > index bdb0d5548f39..a3184416ddc5 100644
> > --- a/include/drm/drmP.h
> > +++ b/include/drm/drmP.h
> > @@ -57,8 +57,7 @@
> >  #include <linux/workqueue.h>
> >  #include <linux/dma-fence.h>
> >  #include <linux/module.h>
> > -
> > -#include <asm/mman.h>
> > +#include <linux/mman.h>
> >  #include <asm/pgalloc.h>
> >  #include <linux/uaccess.h>
> >  
> > -- 
> > MST
> > 
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

  reply	other threads:[~2019-02-08 12:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-08  6:02 [PATCH 0/3] generic asm: mman cleanup Michael S. Tsirkin
2019-02-08  6:02 ` [PATCH 1/3] x86/mpx: tweak header name Michael S. Tsirkin
2019-02-08 15:42   ` Borislav Petkov
2019-02-08 21:43     ` Michael S. Tsirkin
2019-02-08 21:50       ` Dave Hansen
2019-02-08 21:52       ` Borislav Petkov
2019-02-10  0:20         ` Michael S. Tsirkin
2019-02-08  6:02 ` [PATCH 2/2] arch: move common mmap flags to linux/mman.h Michael S. Tsirkin
2019-02-08  6:02 ` [PATCH 2/3] drm: tweak header name Michael S. Tsirkin
2019-02-08  6:02   ` Michael S. Tsirkin
2019-02-08  8:56   ` Daniel Vetter
2019-02-08 12:55     ` Michael S. Tsirkin [this message]
2019-02-08 12:55       ` Michael S. Tsirkin
2019-02-08  6:03 ` [PATCH 3/3] arch: move common mmap flags to linux/mman.h Michael S. Tsirkin
2019-02-08 18:12 ` [PATCH 0/3] generic asm: mman cleanup Mike Rapoport
2019-02-08 21:19   ` Michael S. Tsirkin
2019-02-11  4:20 ` Michael S. Tsirkin
2019-02-18 14:03   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190208075408-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=airlied@linux.ie \
    --cc=arnd@arndb.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.