All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Christoph Hellwig <hch@lst.de>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	iommu@lists.linux-foundation.org,
	linux-arm-kernel@lists.infradead.org,
	linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH/RFC] driver core: Postpone DMA tear-down until after devres release
Date: Fri, 8 Feb 2019 17:40:19 +0100	[thread overview]
Message-ID: <20190208164019.GY32526@8bytes.org> (raw)
In-Reply-To: <20190207193653.18221-1-geert+renesas@glider.be>

Hi Geert,

On Thu, Feb 07, 2019 at 08:36:53PM +0100, Geert Uytterhoeven wrote:
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index 8ac10af17c0043a3..d62487d024559620 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -968,9 +968,9 @@ static void __device_release_driver(struct device *dev, struct device *parent)
>  			drv->remove(dev);
>  
>  		device_links_driver_cleanup(dev);
> -		arch_teardown_dma_ops(dev);
>  
>  		devres_release_all(dev);
> +		arch_teardown_dma_ops(dev);
>  		dev->driver = NULL;
>  		dev_set_drvdata(dev, NULL);
>  		if (dev->pm_domain && dev->pm_domain->dismiss)

Thanks for the fix! Should it also be tagged for stable and get a Fixes
tag? I know it only triggers with a fix in v5.0-rc, but still...

Regards,

	Joerg

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	iommu@lists.linux-foundation.org,
	Robin Murphy <robin.murphy@arm.com>,
	Christoph Hellwig <hch@lst.de>,
	linux-arm-kernel@lists.infradead.org,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH/RFC] driver core: Postpone DMA tear-down until after devres release
Date: Fri, 8 Feb 2019 17:40:19 +0100	[thread overview]
Message-ID: <20190208164019.GY32526@8bytes.org> (raw)
In-Reply-To: <20190207193653.18221-1-geert+renesas@glider.be>

Hi Geert,

On Thu, Feb 07, 2019 at 08:36:53PM +0100, Geert Uytterhoeven wrote:
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index 8ac10af17c0043a3..d62487d024559620 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -968,9 +968,9 @@ static void __device_release_driver(struct device *dev, struct device *parent)
>  			drv->remove(dev);
>  
>  		device_links_driver_cleanup(dev);
> -		arch_teardown_dma_ops(dev);
>  
>  		devres_release_all(dev);
> +		arch_teardown_dma_ops(dev);
>  		dev->driver = NULL;
>  		dev_set_drvdata(dev, NULL);
>  		if (dev->pm_domain && dev->pm_domain->dismiss)

Thanks for the fix! Should it also be tagged for stable and get a Fixes
tag? I know it only triggers with a fix in v5.0-rc, but still...

Regards,

	Joerg


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-02-08 16:40 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-07 19:36 [PATCH/RFC] driver core: Postpone DMA tear-down until after devres release Geert Uytterhoeven
2019-02-07 19:36 ` Geert Uytterhoeven
2019-02-08  7:52 ` Christoph Hellwig
2019-02-08  7:52   ` Christoph Hellwig
2019-02-08  9:41 ` Rafael J. Wysocki
2019-02-08  9:41   ` Rafael J. Wysocki
2019-02-08 11:34 ` Robin Murphy
2019-02-08 11:34   ` Robin Murphy
2019-02-08 16:40 ` Joerg Roedel [this message]
2019-02-08 16:40   ` Joerg Roedel
2019-02-08 17:55   ` Robin Murphy
2019-02-08 17:55     ` Robin Murphy
2019-02-08 18:55     ` Geert Uytterhoeven
2019-02-08 18:55       ` Geert Uytterhoeven
2019-02-11 10:22       ` Robin Murphy
2019-02-11 10:22         ` Robin Murphy
2019-03-07 14:45         ` John Garry
2019-03-07 14:45           ` John Garry
2019-03-07 14:52           ` Robin Murphy
2019-03-07 14:52             ` Robin Murphy
2019-03-07 14:58             ` John Garry
2019-03-07 14:58               ` John Garry
     [not found]             ` <ebc665cc-31c5-4ecd-6c48-6d14962b1f0c-5wv7dgnIgG8@public.gmane.org>
2019-03-07 15:12               ` Greg Kroah-Hartman
2019-03-07 15:12                 ` Greg Kroah-Hartman
2019-03-07 15:12                 ` Greg Kroah-Hartman
2019-03-26 11:41 ` John Garry
2019-03-26 11:41   ` John Garry
2019-03-26 11:41   ` John Garry
2019-03-26 12:31   ` Geert Uytterhoeven
2019-03-26 12:31     ` Geert Uytterhoeven
2019-03-26 17:36     ` John Garry
2019-03-26 17:36       ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190208164019.GY32526@8bytes.org \
    --to=joro@8bytes.org \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=rafael@kernel.org \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.