* [PATCH net-next] xen-netback: mark expected switch fall-through
@ 2019-02-08 19:58 Gustavo A. R. Silva
2019-02-08 20:21 ` David Miller
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-08 19:58 UTC (permalink / raw)
To: Wei Liu, Paul Durrant, David S. Miller
Cc: xen-devel, netdev, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/net/xen-netback/xenbus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c
index 2625740bdc4a..330ddb64930f 100644
--- a/drivers/net/xen-netback/xenbus.c
+++ b/drivers/net/xen-netback/xenbus.c
@@ -655,7 +655,7 @@ static void frontend_changed(struct xenbus_device *dev,
set_backend_state(be, XenbusStateClosed);
if (xenbus_dev_is_online(dev))
break;
- /* fall through if not online */
+ /* fall through - if not online */
case XenbusStateUnknown:
set_backend_state(be, XenbusStateClosed);
device_unregister(&dev->dev);
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH net-next] xen-netback: mark expected switch fall-through
@ 2019-02-08 19:58 Gustavo A. R. Silva
0 siblings, 0 replies; 8+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-08 19:58 UTC (permalink / raw)
To: Wei Liu, Paul Durrant, David S. Miller
Cc: xen-devel, Gustavo A. R. Silva, linux-kernel, netdev
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/net/xen-netback/xenbus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c
index 2625740bdc4a..330ddb64930f 100644
--- a/drivers/net/xen-netback/xenbus.c
+++ b/drivers/net/xen-netback/xenbus.c
@@ -655,7 +655,7 @@ static void frontend_changed(struct xenbus_device *dev,
set_backend_state(be, XenbusStateClosed);
if (xenbus_dev_is_online(dev))
break;
- /* fall through if not online */
+ /* fall through - if not online */
case XenbusStateUnknown:
set_backend_state(be, XenbusStateClosed);
device_unregister(&dev->dev);
--
2.20.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] xen-netback: mark expected switch fall-through
2019-02-08 19:58 [PATCH net-next] xen-netback: mark expected switch fall-through Gustavo A. R. Silva
2019-02-08 20:21 ` David Miller
@ 2019-02-08 20:21 ` David Miller
2019-02-11 9:50 ` [Xen-devel] " Jan Beulich
2019-02-11 9:50 ` Jan Beulich
3 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2019-02-08 20:21 UTC (permalink / raw)
To: gustavo; +Cc: xen-devel, paul.durrant, wei.liu2, linux-kernel, netdev
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Fri, 8 Feb 2019 13:58:38 -0600
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] xen-netback: mark expected switch fall-through
2019-02-08 19:58 [PATCH net-next] xen-netback: mark expected switch fall-through Gustavo A. R. Silva
@ 2019-02-08 20:21 ` David Miller
2019-02-08 21:00 ` Gustavo A. R. Silva
2019-02-08 21:00 ` Gustavo A. R. Silva
2019-02-08 20:21 ` David Miller
` (2 subsequent siblings)
3 siblings, 2 replies; 8+ messages in thread
From: David Miller @ 2019-02-08 20:21 UTC (permalink / raw)
To: gustavo; +Cc: wei.liu2, paul.durrant, xen-devel, netdev, linux-kernel
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Fri, 8 Feb 2019 13:58:38 -0600
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] xen-netback: mark expected switch fall-through
2019-02-08 20:21 ` David Miller
2019-02-08 21:00 ` Gustavo A. R. Silva
@ 2019-02-08 21:00 ` Gustavo A. R. Silva
1 sibling, 0 replies; 8+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-08 21:00 UTC (permalink / raw)
To: David Miller; +Cc: xen-devel, paul.durrant, wei.liu2, linux-kernel, netdev
On 2/8/19 2:21 PM, David Miller wrote:
> From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
> Date: Fri, 8 Feb 2019 13:58:38 -0600
>
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enabling
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Applied.
>
Thanks, Dave.
--
Gustavo
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] xen-netback: mark expected switch fall-through
2019-02-08 20:21 ` David Miller
@ 2019-02-08 21:00 ` Gustavo A. R. Silva
2019-02-08 21:00 ` Gustavo A. R. Silva
1 sibling, 0 replies; 8+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-08 21:00 UTC (permalink / raw)
To: David Miller; +Cc: wei.liu2, paul.durrant, xen-devel, netdev, linux-kernel
On 2/8/19 2:21 PM, David Miller wrote:
> From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
> Date: Fri, 8 Feb 2019 13:58:38 -0600
>
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enabling
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Applied.
>
Thanks, Dave.
--
Gustavo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] xen-netback: mark expected switch fall-through
2019-02-08 19:58 [PATCH net-next] xen-netback: mark expected switch fall-through Gustavo A. R. Silva
` (2 preceding siblings ...)
2019-02-11 9:50 ` [Xen-devel] " Jan Beulich
@ 2019-02-11 9:50 ` Jan Beulich
3 siblings, 0 replies; 8+ messages in thread
From: Jan Beulich @ 2019-02-11 9:50 UTC (permalink / raw)
To: Gustavo A.R.Silva
Cc: Wei Liu, netdev, linux-kernel, Paul Durrant, xen-devel, davem
>>> On 08.02.19 at 20:58, <gustavo@embeddedor.com> wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/net/xen-netback/xenbus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/xen-netback/xenbus.c
> b/drivers/net/xen-netback/xenbus.c
> index 2625740bdc4a..330ddb64930f 100644
> --- a/drivers/net/xen-netback/xenbus.c
> +++ b/drivers/net/xen-netback/xenbus.c
> @@ -655,7 +655,7 @@ static void frontend_changed(struct xenbus_device *dev,
> set_backend_state(be, XenbusStateClosed);
> if (xenbus_dev_is_online(dev))
> break;
> - /* fall through if not online */
> + /* fall through - if not online */
> case XenbusStateUnknown:
Considering the fall-through was already annotated, I don't think
title and description really justify the change. Is the compiler after
a particular wording here?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Xen-devel] [PATCH net-next] xen-netback: mark expected switch fall-through
2019-02-08 19:58 [PATCH net-next] xen-netback: mark expected switch fall-through Gustavo A. R. Silva
2019-02-08 20:21 ` David Miller
2019-02-08 20:21 ` David Miller
@ 2019-02-11 9:50 ` Jan Beulich
2019-02-11 9:50 ` Jan Beulich
3 siblings, 0 replies; 8+ messages in thread
From: Jan Beulich @ 2019-02-11 9:50 UTC (permalink / raw)
To: Gustavo A.R.Silva
Cc: Paul Durrant, Wei Liu, davem, xen-devel, linux-kernel, netdev
>>> On 08.02.19 at 20:58, <gustavo@embeddedor.com> wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/net/xen-netback/xenbus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/xen-netback/xenbus.c
> b/drivers/net/xen-netback/xenbus.c
> index 2625740bdc4a..330ddb64930f 100644
> --- a/drivers/net/xen-netback/xenbus.c
> +++ b/drivers/net/xen-netback/xenbus.c
> @@ -655,7 +655,7 @@ static void frontend_changed(struct xenbus_device *dev,
> set_backend_state(be, XenbusStateClosed);
> if (xenbus_dev_is_online(dev))
> break;
> - /* fall through if not online */
> + /* fall through - if not online */
> case XenbusStateUnknown:
Considering the fall-through was already annotated, I don't think
title and description really justify the change. Is the compiler after
a particular wording here?
Jan
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-02-11 9:50 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-08 19:58 [PATCH net-next] xen-netback: mark expected switch fall-through Gustavo A. R. Silva
2019-02-08 20:21 ` David Miller
2019-02-08 21:00 ` Gustavo A. R. Silva
2019-02-08 21:00 ` Gustavo A. R. Silva
2019-02-08 20:21 ` David Miller
2019-02-11 9:50 ` [Xen-devel] " Jan Beulich
2019-02-11 9:50 ` Jan Beulich
-- strict thread matches above, loose matches on Subject: below --
2019-02-08 19:58 Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.