From: Anand Moon <linux.amoon@gmail.com>
To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: [PATCHv2 1/1] ARM: dts: meson8b: odroidc1: fix USB power supplies for phy
Date: Sat, 9 Feb 2019 17:54:28 +0000 [thread overview]
Message-ID: <20190209175428.1199-2-linux.amoon@gmail.com> (raw)
In-Reply-To: <20190209175428.1199-1-linux.amoon@gmail.com>
From the shematics GPIOAO.BIT5 gpio input for the PWREN signal of the
USB_HOST controller (usb1), add missing phy-supply link for USB1 phy
controller this changes fixed the power issue on usb ports.
Changes help fix usb reset warning.
[ 59.693078] usb 1-1.3: reset high-speed USB device number 6 using dwc2
[ 62.703039] usb 1-1.3: reset high-speed USB device number 6 using dwc2
[ 65.693073] usb 1-1.3: reset high-speed USB device number 6 using dwc2
[ 68.703030] usb 1-1.3: reset high-speed USB device number 6 using dwc2
[ 72.080440] usb 1-1.3: USB disconnect, device number 6
Fixes: 2eb79a4d15ff ("ARM: dts: meson: enabling the USB Host controller on Odroid-C1/C1+ board")
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Kevin Hilman <khilman@baylibre.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
regulator use open bypass opmode voltage current min max
---------------------------------------------------------------------------------------
regulator-dummy 4 3 0 unknown 0mV 0mA 0mV 0mV
c90c0000.usb 1 0mA 0mV 0mV
c90c0000.usb 1 0mA 0mV 0mV
VCCK 1 1 0 unknown 860mV 0mA 860mV 1140mV
cpu0 0 0mA 860mV 860mV
P5V0 3 4 0 unknown 5000mV 0mA 5000mV 5000mV
VCC1V8 1 1 0 unknown 1800mV 0mA 1800mV 1800mV
c1108680.adc 1 0mA 0mV 0mV
VCC3V3 1 2 0 unknown 3300mV 0mA 3300mV 3300mV
VDD_RTC 0 0 0 unknown 900mV 0mA 900mV 900mV
TFLASH_VDD 1 1 0 unknown 3300mV 0mA 3300mV 3300mV
c1108c20.mmc:slot@1 1 0mA 3300mV 3400mV
DDR_VDDC 0 0 0 unknown 1500mV 0mA 1500mV 1500mV
USB_VBUS 2 1 0 unknown 5000mV 0mA 5000mV 5000mV
phy-c1108820.phy.0 2 0mA 0mV 0mV
---
arch/arm/boot/dts/meson8b-odroidc1.dts | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
index 0f0a46ddf3ff..00f2bb1a68f4 100644
--- a/arch/arm/boot/dts/meson8b-odroidc1.dts
+++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
@@ -83,6 +83,20 @@
regulator-max-microvolt = <5000000>;
};
+ usb_vbus: regulator-usb-vbus {
+ compatible = "regulator-fixed";
+
+ regulator-name = "USB_VBUS";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ /*
+ * signal name from schematics: PWREN
+ */
+ gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ vin-supply = <&p5v0>;
+ };
+
tflash_vdd: regulator-tflash_vdd {
/*
* signal name from schematics: TFLASH_VDD_EN
@@ -295,6 +309,7 @@
&usb1_phy {
status = "okay";
+ phy-supply = <&usb_vbus>;
};
&usb1 {
--
2.20.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Anand Moon <linux.amoon@gmail.com>
To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: [PATCHv2 1/1] ARM: dts: meson8b: odroidc1: fix USB power supplies for phy
Date: Sat, 9 Feb 2019 17:54:28 +0000 [thread overview]
Message-ID: <20190209175428.1199-2-linux.amoon@gmail.com> (raw)
In-Reply-To: <20190209175428.1199-1-linux.amoon@gmail.com>
From the shematics GPIOAO.BIT5 gpio input for the PWREN signal of the
USB_HOST controller (usb1), add missing phy-supply link for USB1 phy
controller this changes fixed the power issue on usb ports.
Changes help fix usb reset warning.
[ 59.693078] usb 1-1.3: reset high-speed USB device number 6 using dwc2
[ 62.703039] usb 1-1.3: reset high-speed USB device number 6 using dwc2
[ 65.693073] usb 1-1.3: reset high-speed USB device number 6 using dwc2
[ 68.703030] usb 1-1.3: reset high-speed USB device number 6 using dwc2
[ 72.080440] usb 1-1.3: USB disconnect, device number 6
Fixes: 2eb79a4d15ff ("ARM: dts: meson: enabling the USB Host controller on Odroid-C1/C1+ board")
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Kevin Hilman <khilman@baylibre.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
regulator use open bypass opmode voltage current min max
---------------------------------------------------------------------------------------
regulator-dummy 4 3 0 unknown 0mV 0mA 0mV 0mV
c90c0000.usb 1 0mA 0mV 0mV
c90c0000.usb 1 0mA 0mV 0mV
VCCK 1 1 0 unknown 860mV 0mA 860mV 1140mV
cpu0 0 0mA 860mV 860mV
P5V0 3 4 0 unknown 5000mV 0mA 5000mV 5000mV
VCC1V8 1 1 0 unknown 1800mV 0mA 1800mV 1800mV
c1108680.adc 1 0mA 0mV 0mV
VCC3V3 1 2 0 unknown 3300mV 0mA 3300mV 3300mV
VDD_RTC 0 0 0 unknown 900mV 0mA 900mV 900mV
TFLASH_VDD 1 1 0 unknown 3300mV 0mA 3300mV 3300mV
c1108c20.mmc:slot@1 1 0mA 3300mV 3400mV
DDR_VDDC 0 0 0 unknown 1500mV 0mA 1500mV 1500mV
USB_VBUS 2 1 0 unknown 5000mV 0mA 5000mV 5000mV
phy-c1108820.phy.0 2 0mA 0mV 0mV
---
arch/arm/boot/dts/meson8b-odroidc1.dts | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
index 0f0a46ddf3ff..00f2bb1a68f4 100644
--- a/arch/arm/boot/dts/meson8b-odroidc1.dts
+++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
@@ -83,6 +83,20 @@
regulator-max-microvolt = <5000000>;
};
+ usb_vbus: regulator-usb-vbus {
+ compatible = "regulator-fixed";
+
+ regulator-name = "USB_VBUS";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ /*
+ * signal name from schematics: PWREN
+ */
+ gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ vin-supply = <&p5v0>;
+ };
+
tflash_vdd: regulator-tflash_vdd {
/*
* signal name from schematics: TFLASH_VDD_EN
@@ -295,6 +309,7 @@
&usb1_phy {
status = "okay";
+ phy-supply = <&usb_vbus>;
};
&usb1 {
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Anand Moon <linux.amoon@gmail.com>
To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: [PATCHv2 1/1] ARM: dts: meson8b: odroidc1: fix USB power supplies for phy
Date: Sat, 9 Feb 2019 17:54:28 +0000 [thread overview]
Message-ID: <20190209175428.1199-2-linux.amoon@gmail.com> (raw)
In-Reply-To: <20190209175428.1199-1-linux.amoon@gmail.com>
>From the shematics GPIOAO.BIT5 gpio input for the PWREN signal of the
USB_HOST controller (usb1), add missing phy-supply link for USB1 phy
controller this changes fixed the power issue on usb ports.
Changes help fix usb reset warning.
[ 59.693078] usb 1-1.3: reset high-speed USB device number 6 using dwc2
[ 62.703039] usb 1-1.3: reset high-speed USB device number 6 using dwc2
[ 65.693073] usb 1-1.3: reset high-speed USB device number 6 using dwc2
[ 68.703030] usb 1-1.3: reset high-speed USB device number 6 using dwc2
[ 72.080440] usb 1-1.3: USB disconnect, device number 6
Fixes: 2eb79a4d15ff ("ARM: dts: meson: enabling the USB Host controller on Odroid-C1/C1+ board")
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Kevin Hilman <khilman@baylibre.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
regulator use open bypass opmode voltage current min max
---------------------------------------------------------------------------------------
regulator-dummy 4 3 0 unknown 0mV 0mA 0mV 0mV
c90c0000.usb 1 0mA 0mV 0mV
c90c0000.usb 1 0mA 0mV 0mV
VCCK 1 1 0 unknown 860mV 0mA 860mV 1140mV
cpu0 0 0mA 860mV 860mV
P5V0 3 4 0 unknown 5000mV 0mA 5000mV 5000mV
VCC1V8 1 1 0 unknown 1800mV 0mA 1800mV 1800mV
c1108680.adc 1 0mA 0mV 0mV
VCC3V3 1 2 0 unknown 3300mV 0mA 3300mV 3300mV
VDD_RTC 0 0 0 unknown 900mV 0mA 900mV 900mV
TFLASH_VDD 1 1 0 unknown 3300mV 0mA 3300mV 3300mV
c1108c20.mmc:slot@1 1 0mA 3300mV 3400mV
DDR_VDDC 0 0 0 unknown 1500mV 0mA 1500mV 1500mV
USB_VBUS 2 1 0 unknown 5000mV 0mA 5000mV 5000mV
phy-c1108820.phy.0 2 0mA 0mV 0mV
---
arch/arm/boot/dts/meson8b-odroidc1.dts | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
index 0f0a46ddf3ff..00f2bb1a68f4 100644
--- a/arch/arm/boot/dts/meson8b-odroidc1.dts
+++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
@@ -83,6 +83,20 @@
regulator-max-microvolt = <5000000>;
};
+ usb_vbus: regulator-usb-vbus {
+ compatible = "regulator-fixed";
+
+ regulator-name = "USB_VBUS";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ /*
+ * signal name from schematics: PWREN
+ */
+ gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ vin-supply = <&p5v0>;
+ };
+
tflash_vdd: regulator-tflash_vdd {
/*
* signal name from schematics: TFLASH_VDD_EN
@@ -295,6 +309,7 @@
&usb1_phy {
status = "okay";
+ phy-supply = <&usb_vbus>;
};
&usb1 {
--
2.20.1
next prev parent reply other threads:[~2019-02-09 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-09 17:54 [PATCHv2 0/1] PATCHv2 Odroid c1+ usb fixes Anand Moon
2019-02-09 17:54 ` Anand Moon
2019-02-09 17:54 ` Anand Moon
2019-02-09 17:54 ` Anand Moon [this message]
2019-02-09 17:54 ` [PATCHv2 1/1] ARM: dts: meson8b: odroidc1: fix USB power supplies for phy Anand Moon
2019-02-09 17:54 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190209175428.1199-2-linux.amoon@gmail.com \
--to=linux.amoon@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.