All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stuart Menefy <stuart.menefy@mathembedded.com>
To: linux-samsung-soc@vger.kernel.org,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Kukjin Kim <kgene@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Stuart Menefy <stuart.menefy@mathembedded.com>
Subject: [PATCH 2/2] clocksource: exynos_mct: Clear timer interrupt when shutdown
Date: Sun, 10 Feb 2019 22:51:14 +0000	[thread overview]
Message-ID: <20190210225114.20110-3-stuart.menefy@mathembedded.com> (raw)
In-Reply-To: <20190210225114.20110-1-stuart.menefy@mathembedded.com>

When shutting down the timer, ensure that after we have stopped the
timer any pending interrupts are cleared. This fixes a problem when
suspending, as interrupts are disabled before the timer is stopped,
so the timer interrupt may still be asserted, preventing the system
entering a low power state when the wfi is executed.

Signed-off-by: Stuart Menefy <stuart.menefy@mathembedded.com>
---
 drivers/clocksource/exynos_mct.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c
index 1e325f89d408..d55c30f6981d 100644
--- a/drivers/clocksource/exynos_mct.c
+++ b/drivers/clocksource/exynos_mct.c
@@ -411,6 +411,7 @@ static int set_state_shutdown(struct clock_event_device *evt)
 
 	mevt = container_of(evt, struct mct_clock_event_device, evt);
 	exynos4_mct_tick_stop(mevt);
+	exynos4_mct_tick_clear(mevt);
 	return 0;
 }
 
-- 
2.13.6

WARNING: multiple messages have this Message-ID (diff)
From: Stuart Menefy <stuart.menefy@mathembedded.com>
To: linux-samsung-soc@vger.kernel.org,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Kukjin Kim <kgene@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Stuart Menefy <stuart.menefy@mathembedded.com>
Subject: [PATCH 2/2] clocksource: exynos_mct: Clear timer interrupt when shutdown
Date: Sun, 10 Feb 2019 22:51:14 +0000	[thread overview]
Message-ID: <20190210225114.20110-3-stuart.menefy@mathembedded.com> (raw)
In-Reply-To: <20190210225114.20110-1-stuart.menefy@mathembedded.com>

When shutting down the timer, ensure that after we have stopped the
timer any pending interrupts are cleared. This fixes a problem when
suspending, as interrupts are disabled before the timer is stopped,
so the timer interrupt may still be asserted, preventing the system
entering a low power state when the wfi is executed.

Signed-off-by: Stuart Menefy <stuart.menefy@mathembedded.com>
---
 drivers/clocksource/exynos_mct.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c
index 1e325f89d408..d55c30f6981d 100644
--- a/drivers/clocksource/exynos_mct.c
+++ b/drivers/clocksource/exynos_mct.c
@@ -411,6 +411,7 @@ static int set_state_shutdown(struct clock_event_device *evt)
 
 	mevt = container_of(evt, struct mct_clock_event_device, evt);
 	exynos4_mct_tick_stop(mevt);
+	exynos4_mct_tick_clear(mevt);
 	return 0;
 }
 
-- 
2.13.6


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-02-10 22:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20190210225147epcas3p4cedebfc5692274bc6135ceabbcf2642d@epcas3p4.samsung.com>
2019-02-10 22:51 ` [PATCH 0/2] Subject: [PATCH 0/2] clocksource: exynos_mct: Clear timer interrupt when shutting down Stuart Menefy
2019-02-10 22:51   ` Stuart Menefy
2019-02-10 22:51   ` [PATCH 1/2] clocksource: exynos_mct: Move one-shot check from tick clear to ISR Stuart Menefy
2019-02-10 22:51     ` Stuart Menefy
2019-02-11  8:47     ` Krzysztof Kozlowski
2019-02-11  8:47       ` Krzysztof Kozlowski
2019-02-10 22:51   ` Stuart Menefy [this message]
2019-02-10 22:51     ` [PATCH 2/2] clocksource: exynos_mct: Clear timer interrupt when shutdown Stuart Menefy
2019-02-11  8:47     ` Krzysztof Kozlowski
2019-02-11  8:47       ` Krzysztof Kozlowski
2019-02-11  7:14   ` [PATCH 0/2] Subject: [PATCH 0/2] clocksource: exynos_mct: Clear timer interrupt when shutting down Marek Szyprowski
2019-02-11  7:14     ` Marek Szyprowski
2019-02-11 11:23     ` Daniel Lezcano
2019-02-11 11:23       ` Daniel Lezcano
2019-02-11 11:34       ` Krzysztof Kozlowski
2019-02-11 11:34         ` Krzysztof Kozlowski
2019-02-11  8:45   ` Krzysztof Kozlowski
2019-02-11  8:45     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190210225114.20110-3-stuart.menefy@mathembedded.com \
    --to=stuart.menefy@mathembedded.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.