All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-trace-devel@vger.kernel.org
Cc: Yordan Karadzhov <ykaradzhov@vmware.com>
Subject: [PATCH 0/4] kernel-shark: Add sched_waking event for sched plugin processing
Date: Sun, 10 Feb 2019 20:18:07 -0500	[thread overview]
Message-ID: <20190211011807.714634783@goodmis.org> (raw)

Hi Yordan,

I was using kernel shark to examine vsock events, and noticed that when I
only enabled sched_waking events, it did not give me the wake up boxes in
the task plots. I decided to look at the code and modify it to handle it.

When doing that, I noticed that the "success" field of the event was being
used. This is an obsolete field that will hopefully someday be removed. So I
added a patch to remove that. I also did not want to just add cut and paste
code to add the sched_waking, and instead made helper functions to process
the events all the same. And finally, I added the sched_waking code.

Can you review these patches and if they are fine by you, give your
"Reviewed-by" tag. Otherwise let me know if there's an issue that I should
fix.

Thanks!

-- Steve



Tag SHA1: 746c45bb20a4c860d36c48d279286c67202248a0
Head SHA1: 746c45bb20a4c860d36c48d279286c67202248a0


Steven Rostedt (VMware) (4):
      kernel-shark: Remove testing of "success" field of wakeup events
      kernel-shark: Consolidate duplicate code of the sched_wakeup events
      kernel-shark: Remove plugin_get_rec_wakeup_pid()
      kernel-shark: Add sched_waking event processing to sched_waking

----
 kernel-shark/src/plugins/sched_events.c | 147 +++++++++++++++-----------------
 kernel-shark/src/plugins/sched_events.h |  12 ++-
 2 files changed, 76 insertions(+), 83 deletions(-)

             reply	other threads:[~2019-02-11  1:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-11  1:18 Steven Rostedt [this message]
2019-02-11  1:18 ` [PATCH 1/4] kernel-shark: Remove testing of "success" field of wakeup events Steven Rostedt
2019-02-11  1:18 ` [PATCH 2/4] kernel-shark: Consolidate duplicate code of the sched_wakeup events Steven Rostedt
2019-02-11  8:53   ` Yordan Karadzhov
2019-02-11 14:44     ` Steven Rostedt
2019-02-12 17:09       ` Yordan Karadzhov
2019-02-11  1:18 ` [PATCH 3/4] kernel-shark: Remove plugin_get_rec_wakeup_pid() Steven Rostedt
2019-02-11  1:18 ` [PATCH 4/4] kernel-shark: Add sched_waking event processing to sched_waking Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190211011807.714634783@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=ykaradzhov@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.