From: Steven Rostedt <rostedt@goodmis.org>
To: linux-trace-devel@vger.kernel.org
Cc: Yordan Karadzhov <ykaradzhov@vmware.com>
Subject: [PATCH 4/4] kernel-shark: Add sched_waking event processing to sched_waking
Date: Sun, 10 Feb 2019 20:18:11 -0500 [thread overview]
Message-ID: <20190211012154.262506802@goodmis.org> (raw)
In-Reply-To: 20190211011807.714634783@goodmis.org
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
It is now more common to enable the sched_waking event than to use the
sched_wakeup or sched_wakeup_new, as it encompasses both. But the sched
plugin does not handle that. Fix that by including the sched_waking event as
an event to use for processing schedule wakeup events.
Signen-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
kernel-shark/src/plugins/sched_events.c | 6 ++++++
kernel-shark/src/plugins/sched_events.h | 6 ++++++
2 files changed, 12 insertions(+)
diff --git a/kernel-shark/src/plugins/sched_events.c b/kernel-shark/src/plugins/sched_events.c
index 0cfe5b5367e2..14f8edb2836b 100644
--- a/kernel-shark/src/plugins/sched_events.c
+++ b/kernel-shark/src/plugins/sched_events.c
@@ -85,6 +85,10 @@ static bool plugin_sched_init_context(struct kshark_context *kshark_ctx)
&plugin_ctx->sched_wakeup_new_event,
&plugin_ctx->sched_wakeup_new_pid_field);
+ wakeup_found |= define_wakeup_event(kshark_ctx->pevent, "sched_waking",
+ &plugin_ctx->sched_waking_event,
+ &plugin_ctx->sched_waking_pid_field);
+
if (!wakeup_found)
return false;
@@ -158,10 +162,12 @@ static bool wakeup_match_rec_pid(struct plugin_sched_context *plugin_ctx,
int pid)
{
struct tep_event *wakeup_events[] = {
+ plugin_ctx->sched_waking_event,
plugin_ctx->sched_wakeup_event,
plugin_ctx->sched_wakeup_new_event,
};
struct tep_format_field *wakeup_fields[] = {
+ plugin_ctx->sched_waking_pid_field,
plugin_ctx->sched_wakeup_pid_field,
plugin_ctx->sched_wakeup_new_pid_field,
};
diff --git a/kernel-shark/src/plugins/sched_events.h b/kernel-shark/src/plugins/sched_events.h
index 0beb63fe2b48..dbc9963cbc4e 100644
--- a/kernel-shark/src/plugins/sched_events.h
+++ b/kernel-shark/src/plugins/sched_events.h
@@ -51,6 +51,12 @@ struct plugin_sched_context {
/** Pointer to the sched_wakeup_new_pid_field format descriptor. */
struct tep_format_field *sched_wakeup_new_pid_field;
+ /** Pointer to the sched_waking_event object. */
+ struct tep_event *sched_waking_event;
+
+ /** Pointer to the sched_waking_pid_field format descriptor. */
+ struct tep_format_field *sched_waking_pid_field;
+
/** List of Data collections used by this plugin. */
struct kshark_entry_collection *collections;
--
2.20.1
prev parent reply other threads:[~2019-02-11 1:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 1:18 [PATCH 0/4] kernel-shark: Add sched_waking event for sched plugin processing Steven Rostedt
2019-02-11 1:18 ` [PATCH 1/4] kernel-shark: Remove testing of "success" field of wakeup events Steven Rostedt
2019-02-11 1:18 ` [PATCH 2/4] kernel-shark: Consolidate duplicate code of the sched_wakeup events Steven Rostedt
2019-02-11 8:53 ` Yordan Karadzhov
2019-02-11 14:44 ` Steven Rostedt
2019-02-12 17:09 ` Yordan Karadzhov
2019-02-11 1:18 ` [PATCH 3/4] kernel-shark: Remove plugin_get_rec_wakeup_pid() Steven Rostedt
2019-02-11 1:18 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211012154.262506802@goodmis.org \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=ykaradzhov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.