* [PATCH] systemd: RDEPENDS on util-linux-umount
@ 2019-02-11 12:04 André Draszik
2019-02-11 12:08 ` André Draszik
0 siblings, 1 reply; 6+ messages in thread
From: André Draszik @ 2019-02-11 12:04 UTC (permalink / raw)
To: openembedded-core
From: André Draszik <andre.draszik@jci.com>
It looks like there is an implicit dependency on util-linux'
umount - as otherwise when using busybox' umount we see a
long delay on shutdown / reboot.
[YOCTO #13058]
Signed-off-by: André Draszik <andre.draszik@jci.com>
---
this should only be merged with or after the util-linux
packaging rework
---
meta/recipes-core/systemd/systemd_239.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-core/systemd/systemd_239.bb b/meta/recipes-core/systemd/systemd_239.bb
index f843f588bd..e2dfe639b3 100644
--- a/meta/recipes-core/systemd/systemd_239.bb
+++ b/meta/recipes-core/systemd/systemd_239.bb
@@ -556,7 +556,7 @@ FILES_${PN} = " ${base_bindir}/* \
FILES_${PN}-dev += "${base_libdir}/security/*.la ${datadir}/dbus-1/interfaces/ ${sysconfdir}/rpm/macros.systemd"
-RDEPENDS_${PN} += "kmod dbus util-linux-mount udev (= ${EXTENDPKGV}) util-linux-agetty util-linux-fsck"
+RDEPENDS_${PN} += "kmod dbus util-linux-mount util-linux-umount udev (= ${EXTENDPKGV}) util-linux-agetty util-linux-fsck"
RDEPENDS_${PN} += "${@bb.utils.contains('PACKAGECONFIG', 'serial-getty-generator', '', 'systemd-serialgetty', d)}"
RDEPENDS_${PN} += "volatile-binds update-rc.d systemd-conf"
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] systemd: RDEPENDS on util-linux-umount
2019-02-11 12:04 [PATCH] systemd: RDEPENDS on util-linux-umount André Draszik
@ 2019-02-11 12:08 ` André Draszik
2019-02-11 12:15 ` Mikko.Rapeli
0 siblings, 1 reply; 6+ messages in thread
From: André Draszik @ 2019-02-11 12:08 UTC (permalink / raw)
To: openembedded-core
Please ignore this patch. Looks like a red-herring. Sorry for the noise.
On Mon, 2019-02-11 at 12:04 +0000, André Draszik wrote:
> From: André Draszik <andre.draszik@jci.com>
>
> It looks like there is an implicit dependency on util-linux'
> umount - as otherwise when using busybox' umount we see a
> long delay on shutdown / reboot.
>
> [YOCTO #13058]
>
> Signed-off-by: André Draszik <andre.draszik@jci.com>
>
> ---
> this should only be merged with or after the util-linux
> packaging rework
> ---
> meta/recipes-core/systemd/systemd_239.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/systemd/systemd_239.bb b/meta/recipes-
> core/systemd/systemd_239.bb
> index f843f588bd..e2dfe639b3 100644
> --- a/meta/recipes-core/systemd/systemd_239.bb
> +++ b/meta/recipes-core/systemd/systemd_239.bb
> @@ -556,7 +556,7 @@ FILES_${PN} = " ${base_bindir}/* \
>
> FILES_${PN}-dev += "${base_libdir}/security/*.la ${datadir}/dbus-
> 1/interfaces/ ${sysconfdir}/rpm/macros.systemd"
>
> -RDEPENDS_${PN} += "kmod dbus util-linux-mount udev (= ${EXTENDPKGV})
> util-linux-agetty util-linux-fsck"
> +RDEPENDS_${PN} += "kmod dbus util-linux-mount util-linux-umount udev (=
> ${EXTENDPKGV}) util-linux-agetty util-linux-fsck"
> RDEPENDS_${PN} += "${@bb.utils.contains('PACKAGECONFIG', 'serial-getty-
> generator', '', 'systemd-serialgetty', d)}"
> RDEPENDS_${PN} += "volatile-binds update-rc.d systemd-conf"
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] systemd: RDEPENDS on util-linux-umount
2019-02-11 12:08 ` André Draszik
@ 2019-02-11 12:15 ` Mikko.Rapeli
2019-02-13 10:00 ` Jonas Bonn
0 siblings, 1 reply; 6+ messages in thread
From: Mikko.Rapeli @ 2019-02-11 12:15 UTC (permalink / raw)
To: git; +Cc: openembedded-core
On Mon, Feb 11, 2019 at 12:08:46PM +0000, André Draszik wrote:
> Please ignore this patch. Looks like a red-herring. Sorry for the noise.
FWIW, I would like to see this patch merged. Had some issues in the past
with busybox umount and added same change as a bbappend.
-Mikko
> On Mon, 2019-02-11 at 12:04 +0000, André Draszik wrote:
> > From: André Draszik <andre.draszik@jci.com>
> >
> > It looks like there is an implicit dependency on util-linux'
> > umount - as otherwise when using busybox' umount we see a
> > long delay on shutdown / reboot.
> >
> > [YOCTO #13058]
> >
> > Signed-off-by: André Draszik <andre.draszik@jci.com>
> >
> > ---
> > this should only be merged with or after the util-linux
> > packaging rework
> > ---
> > meta/recipes-core/systemd/systemd_239.bb | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-core/systemd/systemd_239.bb b/meta/recipes-
> > core/systemd/systemd_239.bb
> > index f843f588bd..e2dfe639b3 100644
> > --- a/meta/recipes-core/systemd/systemd_239.bb
> > +++ b/meta/recipes-core/systemd/systemd_239.bb
> > @@ -556,7 +556,7 @@ FILES_${PN} = " ${base_bindir}/* \
> >
> > FILES_${PN}-dev += "${base_libdir}/security/*.la ${datadir}/dbus-
> > 1/interfaces/ ${sysconfdir}/rpm/macros.systemd"
> >
> > -RDEPENDS_${PN} += "kmod dbus util-linux-mount udev (= ${EXTENDPKGV})
> > util-linux-agetty util-linux-fsck"
> > +RDEPENDS_${PN} += "kmod dbus util-linux-mount util-linux-umount udev (=
> > ${EXTENDPKGV}) util-linux-agetty util-linux-fsck"
> > RDEPENDS_${PN} += "${@bb.utils.contains('PACKAGECONFIG', 'serial-getty-
> > generator', '', 'systemd-serialgetty', d)}"
> > RDEPENDS_${PN} += "volatile-binds update-rc.d systemd-conf"
> >
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] systemd: RDEPENDS on util-linux-umount
2019-02-11 12:15 ` Mikko.Rapeli
@ 2019-02-13 10:00 ` Jonas Bonn
2019-02-13 20:45 ` Randy MacLeod
0 siblings, 1 reply; 6+ messages in thread
From: Jonas Bonn @ 2019-02-13 10:00 UTC (permalink / raw)
To: Mikko.Rapeli, git; +Cc: openembedded-core
On 11/02/2019 13:15, Mikko.Rapeli@bmw.de wrote:
> On Mon, Feb 11, 2019 at 12:08:46PM +0000, André Draszik wrote:
>> Please ignore this patch. Looks like a red-herring. Sorry for the noise.
>
> FWIW, I would like to see this patch merged. Had some issues in the past
> with busybox umount and added same change as a bbappend.
I'm also carrying a patch locally for this with the following explanation:
systemd passes the "-c" parameter (do not canonicalize) to the umount
command and busybox's umount does not understand this parameter.
/Jonas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] systemd: RDEPENDS on util-linux-umount
2019-02-13 10:00 ` Jonas Bonn
@ 2019-02-13 20:45 ` Randy MacLeod
2019-02-14 9:15 ` Jonas Bonn
0 siblings, 1 reply; 6+ messages in thread
From: Randy MacLeod @ 2019-02-13 20:45 UTC (permalink / raw)
To: Jonas Bonn, Mikko.Rapeli, git; +Cc: openembedded-core
On 2/13/19 5:00 AM, Jonas Bonn wrote:
>
>
> On 11/02/2019 13:15, Mikko.Rapeli@bmw.de wrote:
>> On Mon, Feb 11, 2019 at 12:08:46PM +0000, André Draszik wrote:
>>> Please ignore this patch. Looks like a red-herring. Sorry for the noise.
>>
>> FWIW, I would like to see this patch merged. Had some issues in the past
>> with busybox umount and added same change as a bbappend.
>
> I'm also carrying a patch locally for this with the following explanation:
>
> systemd passes the "-c" parameter (do not canonicalize) to the umount
> command and busybox's umount does not understand this parameter.
With the current busybox do you really still see a problem since
busybox umount has been told to ignore "-c" now:
https://git.busybox.net/busybox/commit/?id=426134128112738c97a665170b21153ef0764b7d
umount: ignore -c
"-c, --no-canonicalize: Do not canonicalize paths."
As busybox doesn't canonicalize paths in the first place it is safe to
ignore
this option.
See https://github.com/systemd/systemd/issues/7786
Signed-off-by: Shawn Landden <slandden@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
and that's released in:
$ git tag --contains 426134128112738c97a665170b21153ef0764b7d
1_29_0
1_29_1
1_29_2
1_29_3
1_30_0
and we have:
meta/recipes-core/busybox/busybox_1.29.3.bb
--
# Randy MacLeod
# Wind River Linux
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] systemd: RDEPENDS on util-linux-umount
2019-02-13 20:45 ` Randy MacLeod
@ 2019-02-14 9:15 ` Jonas Bonn
0 siblings, 0 replies; 6+ messages in thread
From: Jonas Bonn @ 2019-02-14 9:15 UTC (permalink / raw)
To: Randy MacLeod, Mikko.Rapeli, git; +Cc: openembedded-core
On 13/02/2019 21:45, Randy MacLeod wrote:
> On 2/13/19 5:00 AM, Jonas Bonn wrote:
>>
>>
>> On 11/02/2019 13:15, Mikko.Rapeli@bmw.de wrote:
>>> On Mon, Feb 11, 2019 at 12:08:46PM +0000, André Draszik wrote:
>>>> Please ignore this patch. Looks like a red-herring. Sorry for the
>>>> noise.
>>>
>>> FWIW, I would like to see this patch merged. Had some issues in the past
>>> with busybox umount and added same change as a bbappend.
>>
>> I'm also carrying a patch locally for this with the following
>> explanation:
>>
>> systemd passes the "-c" parameter (do not canonicalize) to the umount
>> command and busybox's umount does not understand this parameter.
>
> With the current busybox do you really still see a problem since
> busybox umount has been told to ignore "-c" now:
OK, my patch predates the fix in busybox and I haven't tested without it
recently. Previously umount would error out due to the unknown option
and systemd-mount would fail rather inelegantly; the busybox fix should
be sufficient to rectify this.
/Jonas
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-14 9:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-11 12:04 [PATCH] systemd: RDEPENDS on util-linux-umount André Draszik
2019-02-11 12:08 ` André Draszik
2019-02-11 12:15 ` Mikko.Rapeli
2019-02-13 10:00 ` Jonas Bonn
2019-02-13 20:45 ` Randy MacLeod
2019-02-14 9:15 ` Jonas Bonn
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.